Access to modified closure in razor syntax?

Question

In the following code I am getting this warning from Reshaper. I wonder if I must change something in the code, or just hide all warnings from this type.

The warning is in each DisplayFor line

@foreach (var item in Model) {
    <tr>
        <td>
            @Html.DisplayFor(modelItem => item.Name)
        </td>
        <td>
            @Html.DisplayFor(modelItem => item.Telephone)
        </td>
        <td>
            @Html.DisplayFor(modelItem => item.Skypeuser)
        </td>
        <td>
            @Html.ActionLink("Edit", "Edit", new { id=item.ApplicantID }) |
            @Html.ActionLink("Details", "Details", new { id=item.ApplicantID }) |
            @Html.ActionLink("Delete", "Delete", new { id=item.ApplicantID })
        </td>
    </tr>
}

See: [Outer Variable Trap](http://stackoverflow.com/questions/3416758/outer-variable-trap) — dtb, Oct 31 '11 at 08:13

score 2 · Accepted Answer · edited Jun 02 '15 at 19:38

You can safely ignore the warning.

This being said I would replace this foreach loop in your view by a display template:

@model IEnumerable<MyViewModel>
<table>
    <thead>
        <tr>
            <th>Name</th>
            <th>Telephone</th>
            <th>Skypeuser</th>
            <th></th>
        </tr>
    </thead>
    <tbody>
        @Html.DisplayForModel()
    </tbody>
</table>

and then define the corresponding display template that will automatically be rendered for each element of the collection (~/Views.Shared/DisplayTemplates/MyViewModel.cshtml):

@model MyViewModel
<tr>
    <td>
        @Html.DisplayFor(x => x.Name)
    </td>
    <td>
        @Html.DisplayFor(x => x.Telephone)
    </td>
    <td>
        @Html.DisplayFor(x => x.Skypeuser)
    </td>
    <td>
        @Html.ActionLink("Edit", "Edit", new { id = Model.ApplicantID }) |
        @Html.ActionLink("Details", "Details", new { id = Model.ApplicantID }) |
        @Html.ActionLink("Delete", "Delete", new { id = Model.ApplicantID })
    </td>
</tr>

No more warnings.

score 0 · Answer 2 · answered Oct 31 '11 at 20:42

0

That warning is bug here and fixed in ReSharper 6.1

answered Oct 31 '11 at 20:42

derigel

3,218
2
19
31

Access to modified closure in razor syntax?

2 Answers2