Trying to post data to php but data is not being read correctly

Question

Here is the code for the php server:

?php


    //from the online tutorial:

    $usr = "bikemap";
      $pwd = "pedalhard";
      $db = "test";
      $host = "localhost";

      $cid = mysql_connect($host,$usr,$pwd);

      if (!$cid) { echo("ERROR: " . mysql_error() . "\n"); }

      $userID = $_POST['userID'];
      $date = $_POST['date'];
      $time = $_POST['time'];

      $lat = $_POST['lat'];
      $long = $_POST['longi'];
      $alt = $_POST['alt'];
       mysql_select_db("test");
      mysql_query("INSERT INTO gpsdata (userID, date, time, lat, longi, alt) VALUES ('$userID', '$date', '$time', '$lat','$longi','$alt') ") or die(mysql_error()); 

      /*$SQL = " INSERT INTO gpsdata ";
    $SQL = $SQL . " (userID, date, time, lat, longi, alt) VALUES ";
    $SQL = $SQL . " ('$userID', '$date', '$time', '$lat','$longi','$alt') ";
    $result = mysql_query("$SQL");

    if (!$result) {
        echo("ERROR: " . mysql_error() . "\n$SQL\n"); } */

    //echo ("New Link Added\n");



    mysql_close($cid); 
    ?>

Data sent from my android app:

 [userID=Loren, date=today, time=now, lat=bit 1, longi=bit 2, alt=bit 3]

For some reason my php doesnt read the data sent from the android app (shown above) properly but if I send the same data from a local web page the data posted parses as it should.

public static void sendAccelerationData(String userIDArg, String dateArg, String timeArg,
            String timeStamp, String lat, String longi, String alt)
    {


        //Add data to be send.
        ArrayList<NameValuePair> nameValuePairs = new ArrayList<NameValuePair>(6);
        nameValuePairs.add(new BasicNameValuePair("userID", userIDArg));
        nameValuePairs.add(new BasicNameValuePair("date",dateArg));
        nameValuePairs.add(new BasicNameValuePair("time",timeArg));
        //nameValuePairs.add(new BasicNameValuePair("timeStamp",timeStamp));

        nameValuePairs.add(new BasicNameValuePair("lat",lat));
        nameValuePairs.add(new BasicNameValuePair("longi",longi));
        nameValuePairs.add(new BasicNameValuePair("alt",alt));

        //this.sendData(nameValuePairs);
        try
        {
            TextLog.addLogStuff("SERV Trying to connect to Server");
            HttpClient httpclient = new DefaultHttpClient();
            HttpPost httppost = new      
            HttpPost("http://myserver.php");
            httppost.setEntity(new UrlEncodedFormEntity(nameValuePairs));
            HttpResponse response = httpclient.execute(httppost);
            Log.i("ServerConn", response.getStatusLine().toString());
            TextLog.addLogStuff("SERV PostData:  "  +response.getStatusLine().toString());
                //Could do something better with response.
        }
        catch(Exception e)
        {
            Log.e("log_tag", "Error:  "+e.toString());
            TextLog.addLogStuff("SERV Connection error:  " +e.toString());
        }  
    }

Take that tutorial out back and torture it to death. It's left you wide open to SQL injection attacks — Marc B, Nov 11 '11 at 22:35
What they are trying to say is go use PDO... Seriously tho guys.. for a tutorial you don't care about sql injection — Zak, Nov 11 '11 at 22:40
except it's so insecure, the code should be functional after-all. Can you please take a look at the logs to see if you receive a request and use var_dump($_POST) to see what are you actually get from android. — Narcis Radu, Nov 11 '11 at 22:42
If you go for a tutorial, most likely is because you're beginning with that topic. And correcting a bad habit is ten times more difficult then developing a good one. If you don't know from the beginning this threats, chances are you'll know them too late in your career, or when the damage is done. So a tutorial that doens't tutorize (or whatever english word should be used here) is just someone showing you a faulty way of doing something with the intention of teaching you how to do it right — Damien Pirsy, Nov 11 '11 at 22:42
omg lol just found out there is a ban on lmgtfy (.) com in the comments section!!! — Zak, Nov 11 '11 at 23:30
Its obvious after some logging that the android isn't giving the php server the data formatted the way it needs to be. Any thoughts? — Loren Zimmer, Nov 12 '11 at 01:17

score 0 · Answer 1 · edited May 23 '17 at 12:29

0

I'd need to see the code you are using in Android to POST the data to know for sure, but it seems like your Android app isn't posting the data in the correct format. You should be doing it something like this: Android, Java: HTTP POST Request.

edited May 23 '17 at 12:29

Community

1
1

answered Nov 11 '11 at 23:26

John Watson

2,554
1
17
13

7seb · Answer 2 · 2011-11-12T00:52:50.927

0

As @John Watson said, it's because your android app doesn't send the data as your 'local web page'. You can post your android app code (i won't help with that) or log the sent data somewhere else to see what's incorrect. write them to a log file or send them by mail. I recommand log it.

<?php
$post = var_export($_POST, true);
$f= fopen('log', 'a+');
fwrite($f, $post);
fclose($f);

Correct file rights needed. Then watch your log file 'log'

As Said, this script is not for production, because sent data need to be checked/escaped to avoid sql injections.

edited Nov 12 '11 at 00:52

answered Nov 11 '11 at 23:55

7seb

172
10

I get an error for this line: post = var_export($_POST); sorry I'm a noob – Loren Zimmer Nov 12 '11 at 00:09
file_put_contents("post.txt",print_r($_POST,true)); gets array () your log gets me no text at all. – Loren Zimmer Nov 12 '11 at 00:45
sorry again, now it tested it. – 7seb Nov 12 '11 at 00:53

score 0 · Answer 3 · answered Nov 12 '11 at 17:11

0

I think a server redirect was messing up the information.

answered Nov 12 '11 at 17:11

Loren Zimmer

482
1
6
29

Trying to post data to php but data is not being read correctly

3 Answers3