Searching in folder

Question

I want to create a method that will search files by name. I have variable with a name and I need method that search file with that name in one folder. This is my sample code:

public class Searching {

    File file = new File("C:/Dane DMS/");
    static ArrayList <String>listaPlikowJava = new ArrayList <String> ();
    public void szukanie(File file)
    {
        for (File szukany : file.listFiles())
        {
            if(szukany.isDirectory())
                szukanie(szukany);
            else {
                String temp[] = szukany.getName().split(".");
                if (temp[1].equals("a")) listaPlikowJava.add(szukany.getName());
            }           
        }
    }
}

What do you think about this idea?

I think you're trolling the people here, posting code with naming different than English. — hovanessyan, Nov 12 '11 at 15:42
The variable names are part of the code documentation and if you're sharing code, you should make sure your documentation is understandable by the people you're sharing code with. — Beat, Nov 12 '11 at 15:56
Rather than putting the found files in a static member, you should probably return the `List` from the method. This will make your code easier to maintain and understand. — erickson, Nov 12 '11 at 15:58
Ok. Next time I named my variables in English for better understanding. — edi233, Nov 12 '11 at 16:00

score 3 · Accepted Answer · edited Nov 12 '11 at 16:34

3

Good one, but it is a more clear to use listFiles(FileFilter filter)

public class MyFileFilter implements FileFilter {
   public boolean accept(File pathname) {
     if (pathname.isDirectory())
       return false;
     else {
       String temp[] = pathname.getName().split(".");
       if (temp[1].equals("a")) return true;
     }
   }
}

edited Nov 12 '11 at 16:34

Mat

202,337
40
393
406

answered Nov 12 '11 at 15:43

itun

3,439
12
51
75

Searching in folder

1 Answers1

Linked