Prevent dialog to be opened multiple times when resuming activity

Question

In my Android application, in order to ask the user if he/she wants to resume a current game, I display a dialog saying "Do you want to resume current game? Yes - No" on the main game activity.

The thing is that if I resume various times this activity without answering the dialog, then I get several dialogs, on top of each other, which is obviously not my goal.

I could easily avoid this behavior using a Boolean var, but I was wondering if the Dialog class had a kind of option preventing to be duplicated or something of the kind.

when you exit app and open again, the activity is restarted and, i assume, because of your code formation, dialog is restarted again, but maybe been never closed before.. maybe if you put onPause(){ Dialog.dismiss();} it couldhelp your issue — , Nov 15 '11 at 10:59

Caner · Answer 1 · 2011-11-17T20:01:11.620

8

You can use singleton pattern, could be roughly like this:

Dialog myDialog = null;


public void showDialog() {
    if(myDialog == null) {
        /* show your dialog here... */
        myDialog = ...
    }
}


public void hideDialog() {
    if(myDialog != null) {
        /* hide your dialog here... */
        myDialog = null;
    }
}

edited Nov 17 '11 at 20:01

answered Nov 15 '11 at 11:03

Caner

57,267
35
174
180

2

Hi Sam Am facing same problem but am using alertdialogbuilder to create dialog, any solution..?? – Vishwanath.M Nov 06 '12 at 10:50

score 5 · Answer 2 · answered Dec 22 '16 at 01:57

private Dialog mDialog;

private void showDialog(String title, String message) {
    AlertDialog.Builder dialogBuilder = new AlertDialog.Builder(this)
            .setTitle(title)
            .setMessage(message);

    // Dismiss any old dialog.
    if (mDialog != null) {
        mDialog.dismiss();
    }

    // Show the new dialog.
    mDialog = dialogBuilder.show();
}

score 4 · Answer 3 · answered Apr 08 '15 at 18:14

4

Rather then doing hacks or using booleans you can use the method given by google itself

public boolean isShowing ()

it Returns a boolean value Whether the dialog is currently showing.

answered Apr 08 '15 at 18:14

Rahul Aswani

85
2
5

score 2 · Answer 4 · answered Jul 15 '19 at 13:04

I also encountered such a problem when I tried to override the onDismiss() method without super.onDismiss(dialog);

It turns out I deleted super.onDismiss(dialog) and because of this, the dialogs were duplicated

Back added, the error disappeared.

I hope someone will help

score 1 · Answer 5 · edited Dec 07 '20 at 09:13

Check Dialog already showing or not

private Dialog mDialog;

private void showDialog(String title, String message) {
    //stop multiple dialog window
    if(dialog != null && dialog.isShowing()) {
        return;
    }
    
    AlertDialog.Builder dialogBuilder = new AlertDialog.Builder(this)
            .setTitle(title)
            .setMessage(message);

    dialog = dialogBuilder.show();
}

score 0 · Answer 6 · edited Jan 07 '19 at 13:34

0

Use isAdded() method,

Kotlin example:

view.button.setOnClickListener({
            if (!dialog.isAdded) {
                dialogShow(dialog)
            }
        })

and somewhere in the fragment or activity

private fun dialogShow(dialog: DialogFragment?) {
        val fragmentManager: FragmentManager = (context as MyActivity).fragmentManager
        dialog?.show( fragmentManager,TAG)
    }

edited Jan 07 '19 at 13:34

IntelliJ Amiya

74,896
15
165
198

answered May 31 '18 at 12:02

alekshandru

169
1
3

Prevent dialog to be opened multiple times when resuming activity

6 Answers6

Linked