Android delete files folder from Internal Storage not working

Question

I'm trying to delete my files folder from Internal Storage, but the code which I'm using is not actually working. Any ideas why?

Button login = (Button) findViewById(R.id.login_btn);
        login.setOnClickListener(new View.OnClickListener() {

            @Override
            public void onClick(View v) {
                String name = "/data/data/"+context.getPackageName()+"/files/";
                Log.e("","path : "+name);
                File myDir = new File(name);
                myDir.delete();
                boolean iff = myDir.delete();
                Log.e("","iff : "+iff);
            }
        });

The result which I get after button click :

11-17 13:09:58.869: E/(15952): path : /data/data/com.android.test/files/
11-17 13:09:58.869: E/(15952): iff : false

just a reminder, debugging won't show the correct output! you actually need to run the code and see the results! — AmiNadimi, Apr 07 '18 at 07:29

score 7 · Accepted Answer · answered Nov 17 '11 at 11:16

7

You are deleting the file twice and only checking the return value of the second delete.

If a file does not exist and you call delete() on it you get "false" as result (file was not deleted because it did not exist).

answered Nov 17 '11 at 11:16

Torben

3,805
26
31

1

In addition check for if file.exists(); – ingsaurabh Nov 17 '11 at 11:52
I didn't notices that I'm deleting the file twice.Thanks! – Android-Droid Nov 17 '11 at 11:55

score 4 · Answer 2 · edited May 23 '17 at 12:13

4

File.delete() will only delete empty directories. You will need to (recursively) delete the directory's contents first. That has been answered here. (Since that's an SO answer I'm not copying and pasting that answer to here)

edited May 23 '17 at 12:13

Community

1
1

answered Nov 17 '11 at 11:21

olafure

3,518
2
33
45

Android delete files folder from Internal Storage not working

2 Answers2