How to remove comma from this json object?

Question

I have a search query as

$sql="SELECT user_id,user_name,user_occupation FROM profile WHERE user_email LIKE '%peace%'";

$result=mysql_query($sql);
$jsonResult = '{"results" : [ ';
while ($data=mysql_fetch_assoc($result))
{
$jsonResult .=json_encode($data).',';
}
$jsonResult .= ']}';

echo $jsonResult;

After referring How to remove last comma (,) from array? , i added

$sql="SELECT user_id,user_name,user_occupation FROM profile WHERE user_email LIKE '%peace%'";

$result=mysql_query($sql);
$jsonResult = '{"results" : [ ';
while ($data=mysql_fetch_assoc($result))
{
$jsonResult .=json_encode($data).',';
}
$jsonResult .= ']}';

$finalResult = rtrim(',',$jsonResult);
echo $finalResult;

This gives me an output as ...

{"results" : [ {"user_id":"2","user_name":"peace","user_occupation":"Web Developer"},  
               {"user_id":"3","user_name":"lover","user_occupation":"Web Developer"}
               {"user_id":"4","user_name":"User4","user_occupation":"Developer"},
               {"user_id":"5","user_name":"User5","user_occupation":"Developer"},]}

I want to remove the last comma from the results array

When you iterate over your results, instead of appending to a JSON string, add the results to an array. Then when you are done iterating, convert that array to json via `json_encode`. You avoid any JSON syntax issues this way. — cheeken, Nov 18 '11 at 06:53

score 5 · Answer 1 · answered Nov 18 '11 at 06:52

5

Instead of building a string within the loop, populate an array instead, with each element being a single associative array (row) from your result set. Then, after the loop, simply json_encode the array you've built.

answered Nov 18 '11 at 06:52

Christopher

764
4
6

...and blast if cheeken didn't manage to type that faster than I did. :) – Christopher Nov 18 '11 at 06:53
No worries, it looks like you won the race! :) – cheeken Nov 18 '11 at 06:54
Thank you for your quick answer. But i found @selvakumar answer helpful. Eventhough u remind me with the best logic... – Peace Lover Nov 18 '11 at 07:04

score 2 · Accepted Answer · answered Nov 18 '11 at 06:56

2

Do like this

$result=mysql_query($sql);
$jsonResult = '{"results" : [ ';
$i=0;
while ($data=mysql_fetch_assoc($result)) {
   if($i != 0){
       $jsonResult .=',';
   }
   $jsonResult .=json_encode($data);
   i++;
}
$jsonResult .= ']}';

answered Nov 18 '11 at 06:56

Selvakumar Ponnusamy

5,363
7
40
78

score 1 · Answer 3 · answered Nov 18 '11 at 06:54

rtrim() removes characters from the end of the string. As you've added ]}, the comma is no longer at the end.

Trim the comma before adding the last part:

$finalResult = rtrim(',',$jsonResult);
$finalResult .= ']}';

Although, as Christopher says, it's not a very good idea to build a JSON string manually.

score 0 · Answer 4 · answered May 05 '22 at 15:13

0

Push your INNER array into another array like this:

...
$result=mysql_query($sql);
$final_result=json_encode(['result' => $result]);

All done. Have fun!

answered May 05 '22 at 15:13

MojSkin

81
1
5

score 0 · Answer 5 · answered Nov 18 '11 at 06:57

0

can u try like filling some array from the incoming result and then just json encode that array like

..push result row arrays to $result ..
$data = array('results' => $results);
json_encode($data);

answered Nov 18 '11 at 06:57

satin

697
2
7
19

score 0 · Answer 6 · answered Nov 18 '11 at 07:26

$sql="SELECT user_id,user_name,user_occupation FROM profile WHERE user_email LIKE '%peace%'";

$result=mysql_query($sql);
$jsonResult = '{"results" : [ ';
$counter = 1;
while ($data=mysql_fetch_assoc($result))
{
if($counter!=1)
 {
 $jsonResult .= ','.json_encode($data);
 }
else
 {
 $jsonResult .=json_encode($data);
 }
$counter++;
}
$jsonResult .= ']}';
$finalResult = rtrim(',',$jsonResult);
echo $finalResult;

How to remove comma from this json object?

6 Answers6