InvalidOperationException and NullReferenceException

Question

When I am debugging my Application, I got lots of InvalidOperationException and NullReferenceException Like this:

A first chance exception of type 'System.NullReferenceException' occurred in XGen.Framework.DLL
A first chance exception of type 'System.InvalidOperationException' occurred in System.Core.dll
A first chance exception of type 'System.InvalidOperationException' occurred in System.Core.dll
A first chance exception of type 'System.NullReferenceException' occurred in XGen.Framework.DLL
A first chance exception of type 'System.InvalidOperationException' occurred in System.Core.dll
A first chance exception of type 'System.InvalidOperationException' occurred in System.Core.dll
A first chance exception of type 'System.NullReferenceException' occurred in XGen.Framework.DLL
A first chance exception of type 'System.InvalidOperationException' occurred in System.Core.dll
A first chance exception of type 'System.InvalidOperationException' occurred in System.Core.dll
A first chance exception of type 'System.NullReferenceException' occurred in XGen.Framework.DLL
A first chance exception of type 'System.InvalidOperationException' occurred in System.Core.dll
A first chance exception of type 'System.InvalidOperationException' occurred in System.Core.dll
A first chance exception of type 'System.NullReferenceException' occurred in XGen.Framework.DLL
A first chance exception of type 'System.InvalidOperationException' occurred in System.Core.dll
A first chance exception of type 'System.InvalidOperationException' occurred in System.Core.dll
A first chance exception of type 'System.NullReferenceException' occurred in XGen.Framework.DLL
A first chance exception of type 'System.InvalidOperationException' occurred in System.Core.dll
A first chance exception of type 'System.InvalidOperationException' occurred in System.Core.dll
A first chance exception of type 'System.NullReferenceException' occurred in XGen.Framework.DLL

Does it makes application slower some how?

Edited:

Found where the InvalidOperationException is Happening

public static Value.Locale Get(string value)
    {
        try
        { return _Items.First(itm => itm.ID.ToUpper() == value.ToUpper() || itm.Name.ToUpper() == value.ToUpper()); }
        catch (Exception)
        { return new XGen.Framework.Value.Locale(); }
    }

Translated text: The sequence contains no elements match

Should I check if _Items.Count > 0?

Have you been able to track down where these exceptions are thrown? — James Johnson, Nov 23 '11 at 19:06
nope... I have no idea where they are happening, but I have no problem at all with the application... I think I will have a lot of work looking for them... :( — ShadowG, Nov 23 '11 at 19:08

score 3 · Answer 1 · answered Nov 23 '11 at 19:09

3

It can't possibly make your application faster, so yes, it would make it slower, but of course "slower" is relative. I would be more concerned as to those exceptions being a result of a logical bug in your application than the speed at which it runs.

answered Nov 23 '11 at 19:09

Daryl

18,592
9
78
145

since I'm having lots of this exceptions... I think it must be somewhere in the base class or base component class. by the way when I say lots, i mean really a lot – ShadowG Nov 23 '11 at 19:12

score 2 · Accepted Answer · answered Nov 23 '11 at 19:46

2

Well if they don't make your program slower, they should be exceptional. If you know that your _items can be empty that's not an exception, that's a normal flow, and it should not be handled with exceptions. You can check the count, or just call FirstOrDefault instead of First...

answered Nov 23 '11 at 19:46

MBen

3,956
21
25

I was about to answer my own question. The problem was in front of me and i didn't see. All I had to do was to use FirstOrDefault instead of First. – ShadowG Nov 23 '11 at 19:51
it happens, sometimes we need an external eye :) – MBen Nov 23 '11 at 20:06

score 1 · Answer 3 · answered Nov 23 '11 at 19:16

1

You'll have to start narrowing those down, to figure out what's happening. My guess is the cause is this XGen.Framework.DLL doing something bad (causing an InvalidOperationException in System.Core), but handling it gracefully for you, which is why the application continues to function.

You can tell the debugger to stop on first change exceptions, and check the stack trace.

answered Nov 23 '11 at 19:16

zmbq

38,013
14
101
171

How do I tell the debugger to do that? – ShadowG Nov 23 '11 at 19:18
You have to uncheck "Just My Code" in the debugger options. Read this (Visual Studio 2005 related, but it's the same in 2010 AFAIK) http://msdn.microsoft.com/en-us/library/d14azbfh(v=vs.80).aspx – zmbq Nov 23 '11 at 19:21
thx It helped me to find where they are happening.. Edited the code showing where – ShadowG Nov 23 '11 at 19:30
I had to use FirstOrDefault() instead of First() – ShadowG Nov 23 '11 at 19:52

score 1 · Answer 4 · edited May 23 '17 at 11:48

1

See this answer from the Jon Skeet, he feels they do not slow down the application when used reasonably, however you situation doesn't seem normal:

If you ever get to the point where exceptions are significantly hurting your performance, you have problems in terms of your use of exceptions beyond just the performance.

How slow are .NET exceptions?

edited May 23 '17 at 11:48

Community

1
1

answered Nov 23 '11 at 19:33

rick schott

21,012
5
52
81

score 0 · Answer 5 · answered Nov 23 '11 at 19:18

first chance exception means that somehwere in the code an exception was thrown but caught and handled. In your case you get a lot of NullReferenceException and InvalidOperationException which most of the times indicate a bug somewhere (property or field not initialized, calling an object in an invalid state). So I would not be worried so much about the speed but more about the correctness in your case.

InvalidOperationException and NullReferenceException

5 Answers5