return dereferenced new - memory leak?

Question

I want to know if this causes a memory leak:

std::string test() {
    return *(new std::string(""));
}

A similar question got [a very detailed answer + explanation here](http://stackoverflow.com/a/8840302/85371) — sehe, Feb 05 '12 at 23:36

score 12 · Accepted Answer · answered Nov 27 '11 at 20:56

12

Yes, it's a memory leak. When the function returns, a copy is made of the original string object.

Then the original new'ed pointer falls out of scope and is lost - a leak.

answered Nov 27 '11 at 20:56

Mysticial

score 0 · Answer 2 · answered Nov 27 '11 at 21:38

0

To make it less leaking make it return a reference:

std::string& test() {
   return *(new std::string(""));
}

answered Nov 27 '11 at 21:38

1

so when I for example have std::string& abc = test(); and I call delete &abc; There won't be any leak ? – Zaffy Dec 02 '11 at 17:21

2 Answers2