setNeedsDisplay not working inside a block

Question

I'm using CMMotionManager for retrieving accelerometer data. The thing is that the accelerometer data gets printed periodically, the instance variables are changed in the view, but the view doesn't get redrawn. I have checked that hv is not nil and that everything is hooked. Is there a problem with calling setNeedsDisplay within a block?

-(void) viewDidAppear:(BOOL) animated
{
    [super viewDidAppear: animated];

    [motionManager startAccelerometerUpdatesToQueue:motionQueue withHandler:
     ^(CMAccelerometerData *accelerometerData, NSError *error)
    {

        NSLog(@"%@",accelerometerData);

        HypnosisView *hv = (HypnosisView *) [self view];

        hv.xShift = 10.0 * accelerometerData.acceleration.x;
        hv.yShift = -10.0 * accelerometerData.acceleration.y;

        [hv setNeedsDisplay];

    }];    
}

score 12 · Accepted Answer · answered Nov 29 '11 at 15:36

12

It's because your calling a UI method on a thread different from the main thread.

Add this to your block:

dispatch_async(dispatch_get_main_queue(), ^{
    [hv setNeedsDisplay];
});

Remember that any method dealing with user interface elements must be called from the main thread.

answered Nov 29 '11 at 15:36

cocoahero

1,302
9
12

thanks the solution. as I being an outsider, it is really good to have people knowledgeable around here. – Hayati Guvence May 29 '12 at 02:52

score 4 · Answer 2 · answered Nov 29 '11 at 15:36

I have done the same in other blocks and it did work, though not with the callback you use here. Maybe the block is not executed on the main thread? You can check that with:

NSLog(@"Main thread? %d", [NSThread isMainThread]);

If it is not, you could force setNeedsDisplay to run on the main thread.

score 0 · Answer 3 · edited May 23 '17 at 11:44

Just wanted to test @cocoahero's answer. I tried to call setTitle for a UIButton in a non main thread. And the title did changed. I tried this both targeting iOS 5.1 and 7.0 using Xcode 5.0.1. Also I called setNeedsDisplay from a non main thread and it worked too.

[NSThread isMainThread] was how I made sure that my calls were not from main thread. I am not sure calling from non main thread was the cause to your problem but at least there are other possibilities there. You can take a look at my answer for another question.

setNeedsDisplay not working inside a block

3 Answers3