Android Delete Directory Not Working

Question

I am trying o delete an entire directory. I have searched and I am using this code and I am able to delete everything in the directory, but the directory still remains. Here is the exact code I have just in case I am missing something.

public boolean DeletePoint(String JobName, String PointName){
    //Delete actual contents and file
    File folder = new File(rootSaveFolder "/" + PointName+"/");
    boolean returnBool = false; 
    try{
        returnBool = deleteDirectory(folder);
        folder.delete();
    } catch (SecurityException e){
        e.printStackTrace();
    }   
}

static public boolean deleteDirectory(File path) {
    if( path.exists() ) {
      File[] files = path.listFiles();
      if (files == null) {
          return true;
      }
      for(int i=0; i<files.length; i++) {
         if(files[i].isDirectory()) {
           deleteDirectory(files[i]);
         }
         else {
           files[i].delete();
         }
      }
    }
    return(path.delete());
  }

The string for the file I am deleting is: /mnt/sdcard/test/gg/

I have tried it with out the final '/' and that didn't work either.

Ethan Sherr · Answer 1 · 2012-04-03T18:16:22.377

Here is your problem;

Your recursion is almost right... Here's the problem.

If files[i] is a directory, (you rightfully go to clear everything in it) However, once "everything" in files[i] is deleted, you do not actually delete files[i] itself.

So the recursion is incomplete; What you need to do is remove the "else" within the forloop.

That way when files[i] which is a directory, will be cleaned up after all things in it have been removed. You were just leaving it.

To be more specific:

public void deleteFile(String uri)
{
     File currentFile = new File(uri);
     File files[] = currentFile.listFiles();
     for (int i = 0; i < files.length; i++)
     {
          if (files[i].isDirectorty())
          {
              deleteFiles(files[i].toString());
          }
          //no else, or you'll never get rid of this folder!
          files[i].delete();
     }
}

score 0 · Answer 2 · edited Dec 02 '17 at 14:53

0

try {
    File tempFolder = new File(path);

    for (File f : tempFolder.listFiles()){
        if (!f.isDirectory()) {
            f.delete();
        }
        tempFolder.delete();
    }

} catch (Exception e) {
    e.printStackTrace();
}

edited Dec 02 '17 at 14:53

Ivar

6,138
12
49
61

answered Dec 02 '17 at 13:08

swati kapoor

131
13

score 0 · Answer 3 · edited May 23 '17 at 10:08

0

Have you set the proper permissions - WRITE_EXTERNAL_STORAGE in your manifest. Easy to overlook sometimes :/

Look at the source topic, I think that guy got it to work...

Source: Delete a folder on SD card

edited May 23 '17 at 10:08

Community

1
1

answered Dec 02 '11 at 22:05

Rawr

2,206
3
25
53

Yes, I have this defined in my manifest. It still deletes everything else, but it leaves just the folder. – CornCat Dec 02 '11 at 22:40

score 0 · Answer 4 · answered Dec 02 '11 at 22:49

0

How are you verifying that the folder is left over? Sometimes the DDMS file explorer is out of sync and you need to refresh it before you see the directory go away.

answered Dec 02 '11 at 22:49

Justin Breitfeller

13,737
4
39
47

I am using Atro to view the SD card and I have also mounted the SD to my computer. Both still show the directory – CornCat Dec 02 '11 at 23:43

Android Delete Directory Not Working

4 Answers4

Linked