48

I can easily disable a javascript button, and it works properly. My issue is that when I try to re-enable that button, it does not re-enable. Here's what I'm doing:

<script type="text/javascript">
    function startCombine(startButton) {

        startButton.disabled = 'true';

        startButton.disabled = 'false';

    }
</script>
<input type='button' id='start' value='Combine Selected Videos'
onclick='startCombine(this);'>

Why isn't this working, and what can I do to make it work?

Arturs
  • 1,258
  • 5
  • 21
  • 28
Adam
  • 913
  • 1
  • 9
  • 26

3 Answers3

85

true and false are not meant to be strings in this context.

You want the literal true and false Boolean values.

startButton.disabled = true;

startButton.disabled = false;

The reason it sort of works (disables the element) is because a non empty string is truthy. So assigning 'false' to the disabled property has the same effect of setting it to true.

alex
  • 479,566
  • 201
  • 878
  • 984
6
<script>
function checkusers()
{
   var shouldEnable = document.getElementById('checkbox').value == 0;
   document.getElementById('add_button').disabled = shouldEnable;
}
</script>
Stephan Schinkel
  • 5,270
  • 1
  • 25
  • 42
debasish
  • 735
  • 1
  • 9
  • 14
1

you can try with

document.getElementById('btn').disabled = !this.checked"

<input type="submit" name="btn"  id="btn" value="submit" disabled/>

<input type="checkbox"  onchange="document.getElementById('btn').disabled = !this.checked"/>
Narendra
  • 127
  • 3
  • 11