1

I have this piece of code : 

Dictionary<string, object> tempDict = new Dictionary<string, object>();

if(xDicionary.TryGetValue(...., out tempDict)
{
tempDict.Add(...);
}
else
{
tempDict.Add(..);
}

If the code passes to the else block then I got and exception that cannot perform add because tempDict points to null. Why is this happening ? I know how to bypass it in an ugly way by allocating new Dictionary also in the else block but is there any better way of doing this ?

Patryk
  • 22,602
  • 44
  • 128
  • 244
  • 1
    By design. TryGetValue() failed so tempDict is null. Rethink your logic. – Hans Passant Dec 10 '11 at 12:42
  • It doesn't deallocate, though it sest the `out` parameter to `null`. –  Dec 10 '11 at 12:42
  • You wouldn't want this design anyway. You only want to instantiate the new dictionary after you discover there is none, i.e. in the else clause, otherwise you're only wasting resources whenever there actually is already one in the dictionary. – jnm2 Jun 27 '13 at 20:25

5 Answers5

3

Because methods that have an out parameter, must assign a value to the out parameter. That means that when you call xDicionary.TryGetValue tempDict is always overwritten, and when nothing is found, it is set to null. Therefore, in your else, tempDict will always be null.

Klaus Byskov Pedersen
  • 117,245
  • 29
  • 183
  • 222
1

That's how TryGetValue works because it uses an out parameter. An out parameter is always assigned a value in a method and so whatever you initialise the parameter to, it will be overwritten.

The documentation makes this point by stating:

This parameter is passed uninitialized.

So you have to use a temporary.

David Heffernan
  • 601,492
  • 42
  • 1,072
  • 1,490
1

TryGetValue will return false and set the tempDict to null if it could not get the value.

This happens because an out parameter must be definitely assigned in the method being called, and when a value can't be retried for a value type, null is the logical default to assign to it.

This is the normal semantics of all BCL TryGet* methods.

Oded
  • 489,969
  • 99
  • 883
  • 1,009
0

Because if xDictionary does not contain the value requested, TryGetValue returns false and the out value is set to null. Hence, when you try do Add something to null you get NullReferenceException.

Tudor
  • 61,523
  • 12
  • 102
  • 142
0

You should put tempDict = new ... within the else {} block. If TryGetValue returns false then you cannot rely on the value in the out parameter.

shunty
  • 3,699
  • 1
  • 22
  • 27