Fragment's onSaveInstanceState() is never called

Question

I'm trying to save data in a Fragment's onSaveInstanceState(), but the method is never called.

Can someone help?

public class MyFragment extends Fragment {

    @Override
    public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {
        ScrollView content = (ScrollView) inflater.inflate(R.layout.content, container, false);
        // More stuff
        return content;
    }

    @Override
    public void onSaveInstanceState(Bundle icicle) {
        // NEVER CALLED
        super.onSaveInstanceState(icicle);
        //More stuff
    }

}

are you using actionbar sherlock? I just checked to make sure I had the latest support package, and realized I'm using actionbar sherlock. I did update to the latest ABS, but I'm still having the problem. Not sure if maybe ABS is the culprit? — James, Jan 05 '12 at 23:05
I just tried Mark Murphy's EU4You ( https://github.com/commonsguy/cw-android/tree/master/Fragments/EU4You_6 ) with the normal support library and also with ActionBarSherlock. It called onSaveInstanceState and passed the bundle to onActivityCreated as expected in both cases. So, still need to id the cause of this. — James, Jan 06 '12 at 00:23

score 70 · Accepted Answer · answered Jan 06 '12 at 01:34

70

I finally figured out the problem, at least in my case. I had an overridden onSaveInstanceState in my FragmentActivity that did not call super.onSaveInstanceState(Bundle outState). Once I added that in, the Fragment.onSaveInstanceState(Bundle outState) functioned normally.

answered Jan 06 '12 at 01:34

James

1,736
2
23
25

8

Hehehe... and that's a bug in EU4You_6 too. Thanks for posting this! – CommonsWare Jan 06 '12 at 23:28
sorry, i found this answer is true but can you explain more about this answer, i am facing this problem too, many thanks – famfamfam Jun 11 '15 at 09:31
1

@famfamfam How can you find "this answer is true" when you didn't understand it? – The incredible Jan Feb 14 '19 at 13:26

score 34 · Answer 2 · answered Jan 02 '14 at 21:14

34

I encountered the same question with you, and tried onSaveInstanceState() method, but did not work.

I think onSaveInstanceState() only works for the scenario that user jumps from one activity to another activity and back, it does not work in the scenario that user jumps among fragments in the same activity.

here is the guide document from Google. http://developer.android.com/guide/components/tasks-and-back-stack.html#ActivityState

answered Jan 02 '14 at 21:14

Zephyr

6,123
34
33

3

that's true. Fragment.onSaveInstanceState will not be called until the activity hosting it needs to save its state as stated here: http://developer.android.com/reference/android/app/Fragment.html#onSaveInstanceState(android.os.Bundle) – Pedro Andrade Sep 24 '14 at 16:25
2

Then what should I do if I would like to save the data in the current fragment? – benleung Oct 04 '15 at 14:36
1

@benleung, I would like to use an object which has an independent life cycle compared to the fragment to save the data. For example, a singleton data manager, a sticky service, or even the SharedPreferences or a File, the last two may not be the best choices due to the overhead. – Zephyr Oct 05 '15 at 17:32
2

@Zephyr Your suggestion might not suit my case, I really want the same set of data when I swap out and swap back the fragment. But I would prefer a new set of data if the activity and fragment are freshly created. It seems that it would difficult to distinguish this two cases. – benleung Oct 06 '15 at 00:14
@benleung, it maybe not that difficult, you can tell an activity is freshly created if the onCreated() is called for the activity, and you can invalidate the cached data when the onDestroy() is called for the activity, right ? (I used this method in my project) – Zephyr Oct 06 '15 at 13:48
2

You can use onStop and onResume callbacks (of the fragment, not the activity). These two work even if you are switching between fragments on the same activity. If your app goes to the background, onSaveInstanceState and onRestoreInstanceState are called so you can you them. If they are by some circumstances not called, you might actually pass some information using method setArguments() and this information should preserve even if your app is in the background and you need to recreate the fragment again. If you don't need this functionality just store the data as regular fields. – vanomart May 13 '16 at 08:56

score 9 · Answer 3 · edited May 23 '17 at 12:25

9

In some situations you might find it helpful to use fragment arguments instead of savedInstanceState. Further explanation.

edited May 23 '17 at 12:25

Community

1
1

answered Aug 02 '14 at 14:48

Fyodor Volchyok

5,610
4
28
45

score 6 · Answer 4 · answered Dec 14 '11 at 12:04

6

One thing to check is to make sure the Activity that contains the fragment is not preventing a restart by including the android:configChanges flag in the AndroidManifest.xml.

answered Dec 14 '11 at 12:04

Scott

1,263
1
12
23

DECEMD · Answer 5 · 2023-01-07T08:15:38.973

0

just restore Bundle in onCreate not in onCreateView

edited Jan 07 '23 at 08:15

answered Jan 07 '23 at 08:14

DECEMD

1
1
1

score -1 · Answer 6 · answered Oct 17 '13 at 08:34

Try calling FragmentManager#saveFragmentInstanceState and Fragment#setInitialSavedState in Activity. You call saveFragmentInstanceState, then framework will call onSaveInstanceState. And you call setInitialSavedState, then framework will call onCreateView with no null argument 'Bundle savedInstanceState'.

score -7 · Answer 7 · answered Dec 14 '11 at 11:23

-7

Try calling setRetainInstance(true) in onCreate(Bundle savedInstanceState).

answered Dec 14 '11 at 11:23

Felix

88,392
43
149
167

1

When are you expecting `onSaveInstanceState` to be called? Maybe you're just not triggering it right. – Felix Dec 14 '11 at 12:25
I expect it to be called when leaving the Activity to save some data when going back to it. Is that right? – jul Dec 14 '11 at 12:43
This is for a completely different approach of fragment state persistence across instances: http://developer.android.com/reference/android/app/Fragment.html#setRetainInstance(boolean) – Snicolas May 24 '13 at 08:41

Fragment's onSaveInstanceState() is never called

7 Answers7

Linked