2 following self-invoking functions don't work

Question

Whats wrong with this code?

function test() {

   (function(){
      console.log('1')  
   })()

   (function(){
      console.log('2')
   })()
}

test()

http://jsfiddle.net/VvaCX/

oh please have the habit of ending with `;` even if JavaScipt allows so. For readability and cross-platform sake? — mauris, Dec 15 '11 at 17:10
Classic example of why you just need to add semi-colons to your code! Now don't be stubborn ;) — PeeHaa, Dec 15 '11 at 17:19
I understand that, but this is not your first question. Anyway, just giving some info, don't worry ;) — musefan, Dec 15 '11 at 17:26

musefan · Accepted Answer · 2011-12-15T17:29:14.160

8

You're missing the semi-colons from the end of each function call...

function test() {

    (function(){
        console.log('1');  
    })();

    (function(){
        console.log('2');
    })();
}

test();

Here is a JSFiddle of the working code if you need to test it. For example, in Chrome you can right-click > inspect element > and switch to the "Console" tab

Thanks to @pimvdb for pointing out what this actually attempts to do when you do not have the semi-colons:

It is currently trying to pass the second function as an argument to the result of the first.

edited Dec 15 '11 at 17:29

answered Dec 15 '11 at 17:10

musefan

47,875
21
135
185

4

+1 It is currently trying to pass the second function as an argument to the result of the first. – pimvdb Dec 15 '11 at 17:11
1

Finally, a clear semantic argument for the use of semicolons in JavaScript! I've been looking for this for ages! – Platinum Azure Dec 15 '11 at 17:13
JS's wishy-washy attitude toward semicolons can mask problems like that illustrated here. Can also work against you in the other direction, as described by Crockford on page 102 of The Good Parts. – Christopher Dec 15 '11 at 17:16
@PlatinumAzure: are you sure you looked in the right places? http://stackoverflow.com/questions/444080/do-you-recommend-using-semicolons-after-every-statement-in-javascript#answer-1169596 – PeeHaa Dec 15 '11 at 17:23

score 2 · Answer 2 · answered Dec 15 '11 at 17:12

2

I've just tested. You NEED your semi-colons.

This works:

function test() {

    (function(){
        console.log('1');
    })()

    (function(){
        console.log('2');
    })()
}

test()

Firebug shows the error at console.log('1'),

answered Dec 15 '11 at 17:12

mauris

42,982
15
99
131

2 following self-invoking functions don't work

2 Answers2