This question has almost been "answered to death", but I think there are a few more points that could usefully be made:
Using try / catch
for non-exceptional control flow is bad style (in Java). (There is often debate about what "non-exceptional" means ... but that's a different topic.)
Part of the reason it is bad style is that try / catch
is orders of magnitude more expensive than an regular control flow statement1. The actual difference depends on the program and the platform, but I'd expect it to be 1000 or more times more expensive. Among other things, the creation the exception object captures a stack trace, looking up and copying information about each frame on the stack. The deeper the stack is, the more that needs to be copied.
Another part of the reason it is bad style is that the code is harder to read.
1 - The JIT in recent versions of Java can optimize exception handling to drastically reduce the overheads in some cases. However, these optimizations are not enabled by default.
There are also issues with the way that you've written the example:
Catching Exception
is very bad practice, because there is a chance that you will catch other unchecked exceptions by accident. For instance, if you did that around a call to raw.substring(1)
you would also catch potential StringIndexOutOfBoundsException
s ... and hide bugs.
What your example is trying to do is (probably) a result of poor practice in dealing with null
strings. As a general principle, you should try to minimize the use of null
strings, and attempt to limit their (intentional) spread. Where possible, use an empty string instead of null
to mean "no value". And when you do have a case where you need to pass or return a null
string, document it clearly in your method javadocs. If your methods get called with a null
when they shouldn't ... it is a bug. Let it throw an exception. Don't try to compensate for the bug by (in this example) returning null
.
My question was more general, not only for null
values.
... and most of the points in my answer are not about null
values!
But please bear in mind that there are many cases where you want to allow the occasional null value, or any other value that could produce an exception, and just ignore them. This is the case, for example, when reading key/pair values from somewhere and passing them to a method like the tryTrim() above.
Yes there are situations where null
values are expected, and you need deal with them.
But I would argue that what tryTrim()
is doing is (typically) the wrong way to deal with null
. Compare these three bits of code:
// Version 1
String param = httpRequest.getParameter("foo");
String trimmed = tryTrim(param);
if (trimmed == null) {
// deal with case of 'foo' parameter absent
} else {
// deal with case of 'foo' parameter present
}
// Version 2
String param = httpRequest.getParameter("foo");
if (param == null) {
// deal with case of 'foo' parameter absent
} else {
String trimmed = param.trim();
// deal with case of 'foo' parameter present
}
// Version 3
String param = httpRequest.getParameter("foo");
if (param == null) {
// treat missing and empty parameters the same
param = "";
}
String trimmed = param.trim();
Ultimately you have to deal with the null
differently from a regular string, and it is usually a good idea do this as soon as possible. The further the null
is allowed to propagate from its point origin, the more likely it is that the programmer will forget that a null
value is a possibility, and write buggy code that assumes a non-null value. And forgetting that an HTTP request parameter could be missing (i.e. param == null
) is a classic case where this happens.
I'm not saying that tryTrim()
is inherently bad. But the fact that you feel the need write methods like this is probably indicative of less than ideal null handling.
Finally, there are other ways to model "there isn't a value" in an API. These include:
- Test for unexpected
null
in setters and constructors, and either throw an exception or substitute a different value.
- Add an
is<Field>Set
method ... and throwing an exception in get<Field>
if the result would be null
.
- Use the Null Object Pattern.
- Use empty strings, empty collections, zero length arrays, etc instead of
null
strings, collections or arrays1.
- Using
Optional
.
1 - To mind, this is different from the Null Object Pattern because there isn't necessarily just one instance of the type to denote "nullity". But you can combine the two ideas ... if you are disciplined about it.