CA1062 (Code Analysis) disagrees with ReSharper -- Who wins?

Question

protected override void OnTextInput(TextCompositionEventArgs e)
{
    e.Handled = true;
    DoSomething(e.Text);
}

If I check for null, CA is happy, but ReSharper says that the null check will always be false. I'm not sure who is more trust-worthy here... it seems like a bug in ReSharper possibly since, in theory, someone could extend from my class and call this method directly passing in null. But I guess I'm just looking to double check which tool is correct and which one has the bug in it.

Just out of curiosity, what does ReSharper say if you add an explicit call to OnTextInput somewhere and pass it null? — dgvid, Jan 05 '12 at 21:49
Report the bug at http://youtrack.jetbrains.net/issues/RSRP so that they can fix it — magol, Jan 06 '12 at 06:27

score 7 · Accepted Answer · answered Jan 05 '12 at 21:49

it seems like a bug in ReSharper possibly since, in theory, someone could extend from my class and call this method directly passing in null.

As unlikely as it may seem, this is entirely possible. I would err on the side of caution and follow the Code Analysis recommendation of doing a null check.

CA1062 (Code Analysis) disagrees with ReSharper -- Who wins?

1 Answers1