ProgressDialog doesn't appear in Android

Question

I am trying to have a ProgressDialog appear when I am getting some data, in Activity. The activity runs normally, and the data are obtained, but the ProgressDialog does not appear.

 private void updateData() {
        ProgressDialog dialog = ProgressDialog.show(ParkActivity.this, "fvhnn", "A actualizar. Aguarde por favor...", true);
        ...
        ...
        dialog.dismiss();
        ...
 }

follow the code of my Activity.

public class ParkActivity extends Activity {
    @Override
    public void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        // Set View to register.xml
        setContentView(R.layout.park);

        SharedPreferences settings = getSharedPreferences(PREF_FILE, 0);
        int ocupados = settings.getInt("ocupados", -1);

        if(ocupados == -1) {
            ((TextView) findViewById(R.id.txtPercentageOcupation)).setVisibility(View.INVISIBLE);
            ((TextView) findViewById(R.id.txtLastUpdate)).setVisibility(View.INVISIBLE);
            ((TextView) findViewById(R.id.txtPlacesAvailable)).setVisibility(View.INVISIBLE);
            ((Button) findViewById(R.id.btnParkUpdate)).setVisibility(View.INVISIBLE);

            updateData();
        } else {
            int total = settings.getInt("total", 440);
            long data = settings.getLong("data", 0);

            putData(ocupados, total, data);
        }


        Button btnUpdate = (Button) findViewById(R.id.btnParkUpdate);
        btnUpdate.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View arg0) {
                updateData();
            }
        });
    }

    private void updateData() {
        ProgressDialog dialog = ProgressDialog.show(ParkActivity.this, "fvhnn", "A actualizar. Aguarde por favor...", true);
        SharedPreferences settings = getSharedPreferences(PREF_FILE, 0);
        String session = settings.getString("sessionID", "null");
        int[] vagas = ISEP_Proxy.vagas(session);
        Date dt = new Date();
        putData(vagas[0], vagas[1], dt.getTime());
        dialog.dismiss();

        // save data
        SharedPreferences.Editor editor = settings.edit();
        editor.putInt("ocupados", vagas[0]);
        editor.putInt("total", vagas[1]);
        editor.putLong("data", dt.getTime());

        editor.commit();
    }

    private void putData(int ocupados, int total, long date) {
        String placesFormat = getResources().getString(R.string.PLACES_AVAILABLE);
        String percentageFormat = getResources().getString(R.string.PERCENTAGE_OCUPATION);
        String lastUpdate = getResources().getString(R.string.LAST_UPDATE);
        double percentage =  100.0 * ocupados / total;

        SimpleDateFormat df = new SimpleDateFormat("HH'h'mm 'de' dd-MM-yyyy");

        ((TextView) findViewById(R.id.txtPercentageOcupation)).setVisibility(View.VISIBLE);
        ((TextView) findViewById(R.id.txtLastUpdate)).setVisibility(View.VISIBLE);
        ((TextView) findViewById(R.id.txtPlacesAvailable)).setVisibility(View.VISIBLE);
        ((Button) findViewById(R.id.btnParkUpdate)).setVisibility(View.VISIBLE);

        ((TextView) findViewById(R.id.txtPercentageOcupation)).setText(String.format(percentageFormat, ((int) percentage) + "%"));
        ((TextView) findViewById(R.id.txtPlacesAvailable)).setText(String.format(placesFormat, total - ocupados));
        ((TextView) findViewById(R.id.txtLastUpdate)).setText(String.format(lastUpdate, df.format(date)));
    }
}

Anyone know what the problem is?

EDIT

@Ted Hopp Suggest to use a AsyncTask. I created the class GetISEPData and placed inside the dialog, but now the app gives me an error and closes.

private class GetISEPData extends AsyncTask<Void, Void, Void> {
    Context cx;
    ProgressDialog dialog;

    public GetISEPData (Context context) {
        cx = context;
    }

    @Override
    protected Void doInBackground(Void... params) {
        SharedPreferences settings = getSharedPreferences(PREF_FILE, 0);
        String session = settings.getString("sessionID", "null");
        int[] vagas = ISEP_Proxy.vagas(session);
        Date dt = new Date();
        putData(vagas[0], vagas[1], dt.getTime());

        // save data
        SharedPreferences.Editor editor = settings.edit();
        editor.putInt("ocupados", vagas[0]);
        editor.putInt("total", vagas[1]);
        editor.putLong("data", dt.getTime());

        editor.commit();            
        return null;
    }

    @Override
    protected void onPostExecute(Void result) {
        super.onPostExecute(result);
        dialog = ProgressDialog.show(ParkActivity.this, "", "A actualizar. Aguarde por favor...", true);
    }

    @Override
    protected void onPreExecute() {
        // TODO Auto-generated method stub
        super.onPreExecute();
        dialog.dismiss();
    }       
}

for invoke put this:

    Button btnUpdate = (Button) findViewById(R.id.btnParkUpdate);
    btnUpdate.setOnClickListener(new View.OnClickListener() {
        @Override
        public void onClick(View arg0) {
            new GetISEPData(ParkActivity.this).execute();
        }
    });

possible duplicate of [ProgressDialog doesn't appear](http://stackoverflow.com/questions/3484320/progressdialog-doesnt-appear) — Mat, Jan 12 '12 at 19:07

Ted Hopp · Accepted Answer · 2012-01-12T20:35:27.470

3

In between the call to show() and the call to dismiss(), you need to do the work in a separate thread. Until you return control to the framework, the dialog doesn't have a chance to get drawn. Take a look at AsyncTask for an easy way to do this.

EDIT: In your updated version of your code, you have the logic for onPreExecute and onPostExecute reversed -- you are trying to dismiss the dialog before it is shown!

edited Jan 12 '12 at 20:35

answered Jan 12 '12 at 19:08

Ted Hopp

232,168
48
399
521

thx for responding I created the class GetISEPData and placed inside the dialog, but now the app gives me an error and closes. `private class GetISEPData extends AsyncTask { Context cx; ProgressDialog dialog; public GetISEPData (Context context) { cx = context; } @Override protected Void doInBackground(Void... params) { int[] vagas = ISEP_Proxy.vagas(session); Date dt = new Date(); putData(vagas[0], vagas[1], dt.getTime()); }` – Miguel Borges Jan 12 '12 at 19:52
`@Override protected void onPostExecute(Void result) { super.onPostExecute(result); dialog = ProgressDialog.show(ParkActivity.this, "", "A actualizar. Aguarde por favor...", true); } @Override protected void onPreExecute() { super.onPreExecute(); dialog.dismiss(); } }` in invoke put this: `Button btnUpdate = (Button) findViewById(R.id.btnParkUpdate); btnUpdate.setOnClickListener(new View.OnClickListener() { @Override public void onClick(View arg0) { new GetISEPData(ParkActivity.this).execute(); } });` – Miguel Borges Jan 12 '12 at 19:53
1

@MiguelBorges It's impossible to read code pasted into comments. Can you edit your original post and add the code there? Also, please post details (stack trace) about the error. – Ted Hopp Jan 12 '12 at 19:57
lol. thx. I realized by then, whenever you want to implement a ProcessDialog AsyncTask have to implement one, right? – Miguel Borges Jan 12 '12 at 21:22
@MiguelBorges Yes. Any time-consuming operation requires a worker thread. While there are many ways to do this, using an AsyncTask is one of the easiest. – Ted Hopp Jan 12 '12 at 21:32

score 1 · Answer 2 · answered Jan 12 '12 at 19:14

1

I think it shown, but it also dismissed immediately cause the show() and dismiss() methods are placed in same thread.

answered Jan 12 '12 at 19:14

Nguyen Minh Binh

23,891
30
115
165

no shows. obtaining data is done by Webservice / SOAP, and therefore takes time. – Miguel Borges Jan 12 '12 at 20:34

ProgressDialog doesn't appear in Android

2 Answers2