@FacesConverter prevents method call of p:selectOneMenu and p:ajax

Question

I have a weird problem with a custom @FacesConverter with JBoss-7.1.0.CR1b during an AJAX call in p:selectOneMenu (Primefaces 3.0).

The simplified Converter looks like this, there are no NPE or other exceptions in this class

@FacesConverter("MyConverter")
public class MyConverter implements Converter
{      
  public Object getAsObject(FacesContext fc, UIComponent uic, String value)
  {
    logger.debug("getAsObject value: "+value);
    if (submittedValue.trim().equals("")) {return null;}
    else
    {           
      MyEjb ejb = new MyEjb();
      ejb.setId(Long.parseLong(value()));
      return ejb;  //**** alternative with return null; ****
    }
  }  
  public String getAsString(FacesContext fc, UIComponent uic, Object value)
  { 
    if (value == null || value.equals("")) {return "";}
    else
    {
        MyEjb ejb = (MyEjb)value;
        return ""+ejb.getId(); 
    }  
  }  
}

The converter is used in a p:selectOneMenu:

<h:form>  
  <p:selectOneMenu value="#{clientBean.selected}" converter="MyConverter">
    <f:selectItems value="#{clientBean.all}" var="my"
                   itemLabel="#{my.name}" itemValue="#{my}"/>
      <p:ajax listener="#{clientBean.changed}" />  
  </p:selectOneMenu>
</h:form>

That's not rocket engineering, the changed method simply makes a debug:

public void changed()
{
  logger.info("changed() "+selected);
}

But now the annoying part: The changed() is never called with the code like above, but I get the converter invoked three times:

12:37:51,500 DEBUG getAsObject value: 35
12:37:51,502 DEBUG getAsObject value:
12:37:51,503 DEBUG getAsObject value:

If I change the p:selectOneMenu value="#{clientBean.selectedId}" to a long selectedId and don't use the Converter the method is called once. Even if I return null in getAsObject()the changed() is called (once). I don't assume it's Primefaces related, because I have the same behavior if I use h:selectOneMenu and f:ajax.

@Ondra: how exactly is this problem related to JBoss AS 7? This way you're implying that the problem doesn't manifest on other servers, which is untrue for this particular problem. — BalusC, Feb 19 '12 at 17:14

score 5 · Accepted Answer · edited May 23 '17 at 12:00

You should have a <p:messages />, <p:growl /> or <h:messages /> which is been ajax-updated in your view. You should also pay attention to warnings in server logs about possible missing faces messages. The chance is big that you're seeing the infamous Validation error: Value not valid validation error.

After conversion, JSF will validate if the submitted object is one of the available items as part of safeguard against tampered/hacked requests. JSF will do that by submittedObject.equals(oneOfAvailableObjects) for each of the available objects as you have there in <f:selectItems>. If nothing matches, then JSF will display this validation error.

In your particular case, the MyEjb class has apparently no equals() method or its implementation is broken. See also Right way to implement equals contract.

I have implemented `equals` as you descirbe for _technical equality_ and it works like a charm. Thanks again for your support, BalusC. — Thor, Jan 13 '12 at 19:04

@FacesConverter prevents method call of p:selectOneMenu and p:ajax

1 Answers1