dismissViewControllerAnimated is called but ViewController is not dismissed

Question

I am having a problems with the dismissViewControllerAnimated method not closing down the view.

What is happening in the app here is:

Cell in ItemViewController is selected.
View is pushed to ItemDetailViewControllerand details are sent through a delegate
User selects 'done' and the event is sent via a delegate to be closed in ItemViewController

All of this works except for the View is not dismissed, there are no errors. Can anyone see what is wrong?

- (void)itemDetailViewControllerDidFinish:(ItemDetailViewController *)controller
{
    NSLog(@"Controller: %@", controller);
    // Returns - Controller: <ItemDetailViewController: 0x6b68b60>

    [self dismissViewControllerAnimated:YES completion:nil];
}

what if you send `dismissModalViewControllerAnimated:` instead ? — , Jan 24 '12 at 15:03
@Vince: I did try but it doesn't seem to work if the segue is a 'push'. — Ad Taylor, Jan 24 '12 at 15:08
@AdTaylor - `self` can't be the VC pushed. Isn't it the VC that presented the second to the user ? — , Jan 24 '12 at 15:11

Nick Lockwood · Accepted Answer · 2012-08-06T20:37:59.133

66

What if you call [controller.navigationController popViewControllerAnimated:YES] instead?

For that matter, what if you call [controller dismissViewControllerAnimated:YES completion:nil] instead of calling it on self?

edited Aug 06 '12 at 20:37

answered Jan 24 '12 at 15:11

Nick Lockwood

40,865
11
112
103

10

The exact syntax that worked for me: [self.navigationController popViewControllerAnimated:YES]; – Dan Oct 03 '13 at 17:45
2

Push with pop and present with dismiss – sam_smith Jan 27 '15 at 22:58
3

Looks like self:dismissviewcontroller doesn't work if your page is embedded in a navigation controller. – Peter Webb Feb 27 '15 at 09:49
popViewController Worked like a charm – Abdul Waheed Aug 29 '16 at 06:27

score 10 · Answer 2 · edited May 23 '17 at 12:34

10

The answer is in this page: dismissviewcontrolleranimated-vs-popviewcontrolleranimated

dismissViewController is used when you do not have a navigationcontroller. Most probably you are using a navigation controller, then use self.navigationController popViewController instead.

Also take note of lemax his remark: use NULL, not nill for the completionhandler

edited May 23 '17 at 12:34

Community

1
1

answered Jan 31 '13 at 11:35

Leander

612
7
8

5

Use NULL for non-object pointers. So you shouldn't use NULL here. – Daniel Sanchez Oct 16 '13 at 11:58

Danoli3 · Answer 3 · 2014-03-25T07:02:28.027

5

I had a problem in iOS5 where the standard completion callback was not allowing the view to completely dismiss (only the current pushed view of that modal)

[controller dismissViewControllerAnimated:YES completion:^ {
     //
 }];

Solution for iOS5 is to not have a callback:

[controller dismissViewControllerAnimated:YES completion:nil];

edited Mar 25 '14 at 07:02

answered Oct 01 '13 at 07:37

Danoli3

3,203
3
24
35

Cbas · Answer 4 · 2016-03-25T04:12:07.073

4

Had a problem where calling dismissViewControllerAnimated dismissed the keyboard in a UIViewController, but not the view itself.

Solved it by using two calls:

[self dismissViewControllerAnimated:NO completion:nil];
[self dismissViewControllerAnimated:YES completion:nil];

an instant one for the keyboard, then an animated one for the controller

edited Mar 25 '16 at 04:12

answered Mar 25 '16 at 04:02

Cbas

6,003
11
56
87

score 0 · Answer 5 · answered Mar 29 '17 at 14:46

Your Situation is - ItemViewController -> ItemDetailViewController (pushed on navigationController) Self.dismissViewController(..) dismiss a view controller that is presented over self(in ur case it is ItemViewController). Here, u did not presented any VC over self, instead u pushed a new VC over navigation stack. So, Correct way to dismiss ItemDetailViewController would be

self.navigationController.popViewController(true). please read the description of dismissViewController(....) to get more clarity.

dismissViewControllerAnimated is called but ViewController is not dismissed

5 Answers5

Linked