5

I am using the Python IDE PyCharm and something that is have by default is it will showing warning when I have a mutbale type as a default value. For example, when I have this:

def status(self, options=[]):

PyCharm wants it to looks like:

def status(self, options=None):
    if not options: options = []

My question is whether or not this is a standard way of doing things in the Python community or is this just the way PyCharm thinks it should be done? Are there any disadvantages of having mutable data type as defaults method arguments?

Karl Knechtel
  • 62,466
  • 11
  • 102
  • 153
ryanzec
  • 27,284
  • 38
  • 112
  • 169
  • 1
    If you read the answers to questions here, you'll see that you're repeating the answer to numerous questions. Your code is the standard answer to many, many questions. – S.Lott Jan 27 '12 at 19:52

1 Answers1

9

This is the right way to do it because the same mutable object is used every time you call the same method. If the mutable object is changed afterwards, then the default value won't probably be what it was intended to be.

For example, the following code:

def status(options=[]):
    options.append('new_option')
    return options

print status()
print status()
print status()

will print:

['new_option']
['new_option', 'new_option']
['new_option', 'new_option', 'new_option']

which, as I said above, probably isn't what you're looking for.

jcollado
  • 39,419
  • 8
  • 102
  • 133