8

I have several different processes and I would like them to all log to the same file. These processes are running on a Windows 7 system. Some are python scripts and others are cmd batch files.

Under Unix you'd just have everybody open the file in append mode and write away. As long as each process wrote less than PIPE_BUF bytes in a single message, each write call would be guaranteed to not interleave with any other.

Is there a way to make this happen under Windows? The naive Unix-like approach fails because Windows doesn't like more than one process having a file open for writing at a time by default.

Omnifarious
  • 54,333
  • 19
  • 131
  • 194

2 Answers2

12

It is possible to have multiple batch processes safely write to a single log file. I know nothing about Python, but I imagine the concepts in this answer could be integrated with Python.

Windows allows at most one process to have a specific file open for write access at any point in time. This can be used to implement a file based lock mechanism that guarantees events are serialized across multiple processes. See https://stackoverflow.com/a/9048097/1012053 and http://www.dostips.com/forum/viewtopic.php?p=12454 for some examples.

Since all you are trying to do is write to a log, you can use the log file itself as the lock. The log operation is encapsulated in a subroutine that tries to open the log file in append mode. If the open fails, the routine loops back and tries again. Once the open is successful the log is written and then closed, and the routine returns to the caller. The routine executes whatever command is passed to it, and anything written to stdout within the routine is redirected to the log.

Here is a test batch script that creates 5 child processes that each write to the log file 20 times. The writes are safely interleaved.

@echo off
setlocal
if "%~1" neq "" goto :test

:: Initialize
set log="myLog.log"
2>nul del %log%
2>nul del "test*.marker"
set procCount=5
set testCount=10

:: Launch %procCount% processes that write to the same log
for /l %%n in (1 1 %procCount%) do start "" /b "%~f0" %%n

:wait for child processes to finish
2>nul dir /b "test*.marker" | find /c "test" | >nul findstr /x "%procCount%" || goto :wait

:: Verify log results
for /l %%n in (1 1 %procCount%) do (
  <nul set /p "=Proc %%n log count = "
  find /c "Proc %%n: " <%log%
)

:: Cleanup
del "test*.marker"
exit /b

==============================================================================
:: code below is the process that writes to the log file

:test
set instance=%1
for /l %%n in (1 1 %testCount%) do (
  call :log echo Proc %instance% says hello!
  call :log dir "%~f0"
)
echo done >"test%1.marker"
exit

:log command args...
2>nul (
  >>%log% (
    echo ***********************************************************
    echo Proc %instance%: %date% %time%
    %*
    (call ) %= This odd syntax guarantees the inner block ends with success  =%
            %= We only want to loop back and try again if redirection failed =%
  )
) || goto :log
exit /b

Here is the output that demonstrates that all 20 writes were successful for each process

Proc 1 log count = 20
Proc 2 log count = 20
Proc 3 log count = 20
Proc 4 log count = 20
Proc 5 log count = 20

You can open the resulting "myLog.log" file to see how the writes have been safely interleaved. But the output is too large to post here.

It is easy to demonstrate that simultaneous writes from multiple processes can fail by modifying the :log routine so that it does not retry upon failure.

:log command args...
>>%log% (
  echo ***********************************************************
  echo Proc %instance%: %date% %time%
  %*
)
exit /b

Here are some sample results after "breaking" the :log routine

The process cannot access the file because it is being used by another process.
The process cannot access the file because it is being used by another process.
The process cannot access the file because it is being used by another process.
The process cannot access the file because it is being used by another process.
The process cannot access the file because it is being used by another process.
The process cannot access the file because it is being used by another process.
The process cannot access the file because it is being used by another process.
The process cannot access the file because it is being used by another process.
The process cannot access the file because it is being used by another process.
The process cannot access the file because it is being used by another process.
The process cannot access the file because it is being used by another process.
The process cannot access the file because it is being used by another process.
The process cannot access the file because it is being used by another process.
The process cannot access the file because it is being used by another process.
The process cannot access the file because it is being used by another process.
The process cannot access the file because it is being used by another process.
The process cannot access the file because it is being used by another process.
The process cannot access the file because it is being used by another process.
The process cannot access the file because it is being used by another process.
The process cannot access the file because it is being used by another process.
The process cannot access the file because it is being used by another process.
The process cannot access the file because it is being used by another process.
The process cannot access the file because it is being used by another process.
The process cannot access the file because it is being used by another process.
The process cannot access the file because it is being used by another process.
The process cannot access the file because it is being used by another process.
The process cannot access the file because it is being used by another process.
Proc 1 log count = 12
Proc 2 log count = 16
Proc 3 log count = 13
Proc 4 log count = 18
Proc 5 log count = 14
Community
  • 1
  • 1
dbenham
  • 127,446
  • 28
  • 251
  • 390
  • When you open a file on windows (with CreateFile) you get to choose if other processes can read and/or write to the same file, the 2nd process has to specify compatible share flags... – Anders Feb 19 '12 at 02:46
  • Fair enough. I was mostly speaking for how Windows batch works with redirection - no option there that I'm aware of. Multiple processes can read, even while one process is writing. (I'm not sure if that is always safe). But never more then one process open for write. – dbenham Feb 19 '12 at 03:21
  • @dbenham: Thank you very much for this. It actually solves another big problem I have. It may also solve my logging problem. Is the `>> file ( commands )` syntax documented anywhere? – Omnifarious Feb 19 '12 at 08:24
  • @Omnifarious It is simply standard redirection in append mode being applied to a compound statement enclosed in parentheses. Here is some [marginal Microsoft documentation](http://www.microsoft.com/resources/documentation/windows/xp/all/proddocs/en-us/redirection.mspx?mfr=true), and here is some [good documentation on batch operators, including redirection](http://judago.webs.com/batchoperators.htm) – dbenham Feb 19 '12 at 21:07
  • @dbenham: I haven't worked seriously with Windows or MS-DOS batch files since 1991 or so. So, any sort of documentation is good. :-) Thanks! I know exactly how you'd do this in a Linux system. :-) – Omnifarious Feb 19 '12 at 21:51
  • EDIT - Added `(call )` to inner loop to guarantee success so that code only loops back to try again if the redirection failed. – dbenham Sep 15 '13 at 12:33
3

You can give this Python module a try: http://pypi.python.org/pypi/ConcurrentLogHandler

It provides a drop-in replacement the RotatingFileHandler which allows multiple processes to concurrently log to a single file without dropping or clobbering log events.

I haven't used it, but I found out about it while reading up on a related bug (Issue 4749) in Python.

If you implement your own code to do it instead of using that module, make sure you read up on the bug!

You can use output redirection on Windows like you do in Bash. Pipe the output of the batch files to a Python script that logs through the ConcurrentLogHandler.

Steven T. Snyder
  • 5,847
  • 4
  • 27
  • 58
  • That looks useful. I'm not sure how to handle the logging the batch file does though. Right now I just have it write to a different file. – Omnifarious Feb 18 '12 at 01:13
  • @Omnifarious I think you should be able to rig something up using [output redirection](http://www.microsoft.com/resources/documentation/windows/xp/all/proddocs/en-us/redirection.mspx?mfr=true). `|` works on Windows much like it does in Bash. – Steven T. Snyder Feb 18 '12 at 04:54
  • the package is currently maintained here: https://github.com/Preston-Landers/concurrent-log-handler. And it works really well! – nirvana-msu Jan 17 '20 at 15:16