NullPointerException When Trying To Fetch Current Location

Question

I am trying to Set Location but getting NullPointerException , i have Provided android.permission.ACCESS_COARSE_LOCATION , android.permission.ACCESS_FINE_LOCATION
In manifest file my Source code is as Follow , i am getting Null pointer on List<Address> addresses = new Geocoder(LocationDemo.this,Locale.getDefault()).getFromLocation(currentLocation.getLatitude(), currentLocation.getLongitude(), 1);

My Coding is As Follow

import java.io.IOException;
import java.util.*;
import android.widget.*;
import android.app.Activity;
import android.os.Bundle;
import android.location.*;
import android.content.*;

public class LocationDemo extends Activity {

 TextView addressText;
 Location currentLocation;
 double currentLatitude;
 double currentLongitude;
 String store;
 @Override

public void onCreate(Bundle savedInstanceState) {
     super.onCreate(savedInstanceState);
     setContentView(R.layout.main);
     addressText = (TextView)findViewById(R.id.addressText);
     addressText.setText("ready");
     LocationManager locationManager = 
    (LocationManager)this.getSystemService(Context.LOCATION_SERVICE);
    LocationListener locationListener = new LocationListener() {

    public void onLocationChanged(Location location) {
        updateLocation(location);
    }
    public void onStatusChanged(
            String provider, int status, Bundle extras) {}
    public void onProviderEnabled(String provider) {}
    public void onProviderDisabled(String provider) {}
};
locationManager.requestLocationUpdates(
        LocationManager.NETWORK_PROVIDER, 0, 0, locationListener);
currentLocation = locationManager.getLastKnownLocation(LocationManager.NETWORK_PROVIDER); 

try{
    List<Address> addresses = new Geocoder(LocationDemo.this,Locale.getDefault()).getFromLocation(currentLocation.getLatitude(), currentLocation.getLongitude(), 1);        
    StringBuilder result = new StringBuilder();
    if (addresses.size() > 0) {      
            Address address =  addresses.get(0);
            int maxIndex = address.getMaxAddressLineIndex();
            for (int x = 0; x <= maxIndex; x++ ){
                result.append(address.getAddressLine(x));
                //result.append(",");
            }                    
        }
         addressText.setText(result.toString()); 
        Intent send_add = new Intent();
        send_add.putExtra("address",result.toString());
         store = addressText.getText().toString(); 
}
catch(IOException ex)
{
addressText.setText(ex.getMessage().toString());
} 
} 
void updateLocation(Location location){
   currentLocation = location;
   currentLatitude = currentLocation.getLatitude();
  currentLongitude = currentLocation.getLongitude();
 } 
}

i am importing this code in application that extends Service that is trying to obtain Address on startup of service

Your problems seems to be relevant to [this post](http://stackoverflow.com/a/9075559/593709) — Adil Soomro, Feb 27 '12 at 08:43
I think your currentLocation is null. Try printing it in a logger statement. — Shashank Kadne, Feb 27 '12 at 08:43

score 0 · Answer 1 · answered Feb 27 '12 at 08:52

0

LocationListener[] mLocationListeners = new LocationListener[] {
        new LocationListener(LocationManager.GPS_PROVIDER),
        new LocationListener(LocationManager.NETWORK_PROVIDER) };

try this code in your Location Listener.

answered Feb 27 '12 at 08:52

Vikash Kumar

621
2
6
21

obvious dude but is theiy other way ? – Ronak Mehta Feb 27 '12 at 09:55

score 0 · Accepted Answer · edited Feb 27 '12 at 09:03

Might be you are getting current location as null. as it takes some time to calculate the location .if this is the case , try this

   import java.io.IOException;
    import java.util.*;
    import android.widget.*;
    import android.app.Activity;
    import android.os.Bundle;
    import android.location.*;
    import android.content.*;

    public class LocationDemo extends Activity {

     TextView addressText;
     Location currentLocation;
     double currentLatitude;
     double currentLongitude;
     String store;
     @Override

    public void onCreate(Bundle savedInstanceState) {
         super.onCreate(savedInstanceState);
         setContentView(R.layout.main);
         addressText = (TextView)findViewById(R.id.addressText);
         addressText.setText("ready");
         LocationManager locationManager = 
        (LocationManager)this.getSystemService(Context.LOCATION_SERVICE);
        LocationListener locationListener = new LocationListener() {

        public void onLocationChanged(Location location) {
           setAddress(location)
        } 
        public void onStatusChanged(String provider, int status, Bundle extras) {}
        public void onProviderEnabled(String provider) {}
        public void onProviderDisabled(String provider) {}
    };
        locationManager.requestLocationUpdates(
                LocationManager.NETWORK_PROVIDER, 0, 0, locationListener);
     }






public void setAddress(Location location){
currentLocation = location;
       currentLatitude = currentLocation.getLatitude();
      currentLongitude = currentLocation.getLongitude();
try{
        List<Address> addresses = new Geocoder(LocationDemo.this,Locale.getDefault()).getFromLocation(currentLocation.getLatitude(), currentLocation.getLongitude(), 1);        
        StringBuilder result = new StringBuilder();
        if (addresses.size() > 0) {      
                Address address =  addresses.get(0);
                int maxIndex = address.getMaxAddressLineIndex();
                for (int x = 0; x <= maxIndex; x++ ){
                    result.append(address.getAddressLine(x));
                    //result.append(",");
                }                    
            }
             addressText.setText(result.toString()); 
            Intent send_add = new Intent();
            send_add.putExtra("address",result.toString());
             store = addressText.getText().toString(); 
    }
    catch(IOException ex)
    {
    addressText.setText(ex.getMessage().toString());
    } 
}
}

not working i am importing this code in application that extends Service that is trying to obtain Address on startup of service — Ronak Mehta, Feb 27 '12 at 09:29

score 0 · Answer 3 · edited Jun 06 '17 at 06:54

0

Of course you're getting a null pointer because currentLocation is null till onLocationChanged is called. Thus you have to put your code there:

LocationListener locationListener = new LocationListener() {

    public void onLocationChanged(Location location) {

      // put your code here once you have the location

    }
    public void onStatusChanged(
            String provider, int status, Bundle extras) {}
    public void onProviderEnabled(String provider) {}
    public void onProviderDisabled(String provider) {}
};

edited Jun 06 '17 at 06:54

IntelliJ Amiya

74,896
15
165
198

answered Feb 27 '12 at 08:58

Noureddine AMRI

2,942
1
21
28

i am not getting my code is what changes i have to make http://pastebin.com/DytLbdDy – Ronak Mehta Feb 27 '12 at 09:11

NullPointerException When Trying To Fetch Current Location

3 Answers3