Different ways to instantiate an object

Question

What is the difference between instantiating a new instance of an object like this:

public class MyClass
{
    private Order order = new Order();

    public void MethodOne()
    {
        order.CreateOrder();
    }

    public void MethodTwo()
    {
        order.RemoveOrder();
    }

    public void Dispose();
    {
        order.Dispose();
    }
}

And this:

public class MyClass
{
    private Order order;

    public MyClass()
    {
        order = new Order();
    }

    public void MethodOne()
    {
        order.CreateOrder();
    }

    public void MethodTwo()
    {
        order.RemoveOrder();
    }

    public void Dispose();
    {
        order.Dispose();
    }
}

MethodOne and MethodTwo are still using the same object right? No matter which way I use?

I think this is a duplicate of this question: http://stackoverflow.com/questions/298183/c-sharp-member-variable-initialization-best-practice — Paul Tyng, Feb 28 '12 at 11:06
You can add *readonly* to *order* declaration in both cases. — brgerner, Feb 28 '12 at 11:30

score 2 · Accepted Answer · answered Feb 28 '12 at 11:08

This provide a default value for the object order.

private Order order = new Order();

Imagine you class have several constructors, instantiating using any of them will still make your order object initialized.

If you initialize the object in the constructor, the object order is a null reference until you initialize it yourself (like you do in the constructor).

Now keep in mind that if you add another constructor, you will have to init the object order as well in it, either by calling the default constructor, or by initializing like you are doing:

public class MyClass
{
    private Order order;

    public MyClass()
    {
        order = new Order();
    }

    public MyClass(string name)
        : this()  // either call the default constructor
    {
        // or initialize explicitely
        order = new Order();
    }

}

Good point about the multiple constructors, thanks for the answer! — CallumVass, Feb 28 '12 at 11:13

score 1 · Answer 2 · answered Feb 28 '12 at 11:11

In practice the above would be the same. The main time it will differe is if MyClass had multiple constructors. Then you would need to make sure you add the code to each one (or call the simple constructor) whereas if its set at the delcaration then it will be initialisised no matter which constructor you use.

score 0 · Answer 3 · answered Feb 28 '12 at 11:07

0

Imho, there is no real difference in the mentioned constructs.

answered Feb 28 '12 at 11:07

Arie van Someren

445
3
9

Different ways to instantiate an object

3 Answers3