checking if text is entered. Could not find error

Question

I am trying to control if text is entered here is my code and it does not work i couldnt find whats wrong

<html>
<head>
    <script type="text/javascript">
        function CheckInfos()
        {
            var x=document.forms("name").value;
            if(x==null)
            {
                alert("adınızı kontrol ediniz");
            }
        }
    </script>   
</head>
<body>
    <input type="text" id="name" />
    <input type="button" value="test" onclick="CheckInfos()"/>
</body>

There should be a semicolon after the function in the onclick: — Philip Bevan, Feb 29 '12 at 14:27
@FabienMénager sorry: i was clutching at straws. silly silly. — Philip Bevan, Feb 29 '12 at 20:47

score 3 · Accepted Answer · answered Feb 29 '12 at 14:32

3

Don't use "name" as an ID, but use getElementById.

var value = document.getElementById("foo").value;

But you should use a form :

<form name="myform" action="?" method="get" onsubmit="return CheckInfos(this)">
  <input type="text" name="foo" />
  <input type="submit" value="test"/>
</form>

<script>
function CheckInfos(form) {
  if (form.elements.foo.value == "") {
     alert("error");
  }

  return false;
}
</script>

answered Feb 29 '12 at 14:32

Fabien Ménager

140,109
3
41
60

The reason why I discourage you to use IDs like "name" is because it may cause naming conflicts: http://stackoverflow.com/questions/9158238/why-js-function-name-conflicts-with-element-id . – Fabien Ménager Feb 29 '12 at 14:47

David Laberge · Answer 2 · 2012-02-29T14:30:15.967

2

Try

var x=document.getElementById("name").value;
if (x == '') { alert('message'); } // instead of null thanks @minmin

edited Feb 29 '12 at 14:30

answered Feb 29 '12 at 14:23

David Laberge

15,435
14
53
83

1

it didnt work. I didnt use form element. Could it be a reason? – EkremG Feb 29 '12 at 14:26
2

if (x == '') { alert('message'); } – Min Min Feb 29 '12 at 14:28

score 0 · Answer 3 · answered Feb 29 '12 at 14:31

0

The form attribute is missing in your code that why it doesn't work

answered Feb 29 '12 at 14:31

Kunal Vashist

2,380
6
30
59

it worked without form attribute. Solution is--- if(x =="") --- – EkremG Feb 29 '12 at 14:32

checking if text is entered. Could not find error

3 Answers3