2

In my team I want to prevent developer to check-in code with warnings from code analysis.

Like I found in some blogs and stackoverflow-questions I tried to make this with a check-in policy:

  1. Enable Code Analysis in Visual Studio Project and set the Rulset (Microsoft Minimum Recommended Rules)
  2. Add Check-in Policy "Code Analysis" and set the same Ruleset (Microsoft Minimum Recommended Rules).

The Problem now I have is, that the policy only prevent checkin if there are errors, but not if there are only warnings. Of course I can change the ruleset and set all rules as errors. But then also local builds are not possible.

So, what I want is that that the rules all are warnings and building the project is possible but check-in is prevented also if only warning exists.

My idea was, to set a different ruleset in checkin policy settings (same rules but all rules as error). But by trying check-in y get the error: Code analysis settings are not compatible with code analysis policy.

So my question is, if somebody has a solution or idea how I can solve this problem.

Thanks in advance for your answer!

rhe1980
  • 1,557
  • 1
  • 15
  • 36

2 Answers2

2

I tried this in V2010 (that is, treat warnings as errors) but it only worked for compiler warnings, not CA warnings. So my CA warnings still remained as warnings whereas my compiler warnings now became errors.

vjm
  • 21
  • 2
1

If I get it right the behavior you after after is :

  • In the developer's workstation: Compiling is successful even if there are warnings
  • In the TFS-Build: Compiling breaks if there are warnings

In order to get this:

  1. Remove the "Enable Code Analysis on Build" from your csproj
  2. Remove the check-in policy
  3. Open your build definition for editing & navigate to "Process">"2.Basic" and set "Perform Code Analysis" to "Always"

Now, be careful that you may run in a situation, where build succeeds in every DEV-workstation & fails in TFS. That would be really bad.
One way to avoid this, is to change your build's Trigger into "Gated Check-in", so that if there are warnings - build will fail & developers can't check in.
This last step, is -in some way- a replacement for the check-in policy you removed.

pantelif
  • 8,524
  • 2
  • 33
  • 48
  • thanks for your answer. as you said I think with your solution I get the problem that I cannot see directly in visual studio the warnings. I saw in some post that in tfs2008 it was possible to set "treat warnings as errors" which cover exatly my problem. But it seems like in tfs2010 this option isn't available.. now i'm thinking in make a custom checkin policy, but i don't really like this idea ;-) – rhe1980 Feb 29 '12 at 19:09