Add automatic classes to each

Question

I have a list of < li >'s but without classes, I want to make for EACH < li > a different class.. something like this

< li class="1" >
< li class="2" >
< li class="3" >

Here is the code that I have:

<ul id="tralila">
    <?php
    foreach($lists as $key=>$region)
    { 
    ?>
        <li>
            <?php  $regionLink =  "index.php?option=$option&Itemid=$listitemid&task=regions.region&rid=$region->id";
                   echo '<a href="'.$regionLink.'">'.$region->title.'</a>';?> 
        </li>
    <?php
        $location = $key+1;
    } ?>
</ul>

score 1 · Answer 1 · answered Mar 03 '12 at 20:41

1

You can try:

<?php
$i = 1;
foreach($lists as $key=>$region)
{ 
?>
    <li class="<?php echo "className$i"; ?>">
        <?php  $regionLink =  "index.php?option=$option&Itemid=$listitemid&task=regions.region&rid=$region->id";
               echo '<a href="'.$regionLink.'">'.$region->title.'</a>';?> 
    </li>
<?php
    $location = $key+1;
    $i++;
} ?>

Or, instead, you could use the $key from your foreach instead of creating, and incrementing, a counter variable.

answered Mar 03 '12 at 20:41

David Thomas

249,100
51
377
410

Thank you everybody. I tried nosbor's code and it worked like a charm. Thank you all!! Cheers Alex – Alexandru Vlas Mar 03 '12 at 20:56
1

+1 for a sensible answer by fixing the proposed invalid class names: http://stackoverflow.com/questions/448981/what-characters-are-valid-in-css-class-names – Treffynnon Mar 05 '12 at 09:36

score 0 · Answer 2 · edited May 23 '17 at 11:48

0

So this is how you would do it using the key from $lists. Note I have added a prefix of li- as classes cannot start with a digit. See: Which characters are valid in CSS class names/selectors?

<ul id="tralila">
    <?php
    foreach($lists as $key=>$region)
    { 
    ?>
        <li class="<?php echo 'li-' . htmlentities($key); ?>">
            <?php  $regionLink =  "index.php?option=$option&Itemid=$listitemid&task=regions.region&rid=$region->id";
                   echo '<a href="'.$regionLink.'">'.$region->title.'</a>';?> 
        </li>
    <?php
        $location = $key+1;
    } ?>
</ul>

As all of the classes are unique I would use IDs instead of a class though.

edited May 23 '17 at 11:48

Community

1
1

answered Mar 03 '12 at 20:41

Treffynnon

21,365
6
65
98

Thank you everybody. I tried nosbor's code and it worked like a charm. Thank you all!! Cheers Alex – Alexandru Vlas Mar 03 '12 at 20:56
Perhaps the downvoter could explain the problem with this code so I can learn from their greater wisdom on the topic? – Treffynnon Mar 05 '12 at 09:37

score -1 · Accepted Answer · answered Mar 03 '12 at 20:42

-1

Something like this?:

<ul id="tralila">
    <?php
    $class_name = 0;
    foreach($lists as $key=>$region)
    { 

    ?>
        <li class="<?=++$class_name;?>">
            <?php  $regionLink =  "index.php?option=$option&Itemid=$listitemid&task=regions.region&rid=$region->id";
                   echo '<a href="'.$regionLink.'">'.$region->title.'</a>';?> 
        </li>
    <?php
        $location = $key+1;
    } ?>
</ul>

answered Mar 03 '12 at 20:42

nosbor

2,826
3
39
63

@AlexandruVlas No its not. This will create an invalid class name: http://stackoverflow.com/questions/448981/what-characters-are-valid-in-css-class-names – Treffynnon Mar 03 '12 at 20:48
– Alexandru Vlas Mar 03 '12 at 20:55
1

Thank you everybody. I tried nosbor's code and it worked like a charm. Thank you all!! Cheers Alex – Alexandru Vlas Mar 03 '12 at 20:56
1

@AlexandruVlas: There are better and earlier-posted answers to choose from. My biggest gripe about this one is using `=` for an `echo` shortcut, which is not recommended. – Evan Mulawski Mar 03 '12 at 20:56
but what can the "=" do bad to my site? because I see that it works ok .... what would you recommend ? Thanks – Alexandru Vlas Mar 03 '12 at 20:58
@AlexandruVlas: http://stackoverflow.com/questions/200640/are-php-short-tags-acceptable-to-use – Evan Mulawski Mar 03 '12 at 21:03
Thanks. I understood now. Thanks everybody ! – Alexandru Vlas Mar 03 '12 at 21:07
@EvanMulawski: Come on. Be constructive; edit and fix, don't comment and diss. Hey, that's not bad. – Mar 05 '12 at 16:03

Add automatic classes to each

3 Answers3