perl check file contents and match username

Question

I am new to perl programming. I have a scenario where a username is entered in a file, lets say info.log. So, now I want to check whether this username is present in the file contents or not

 $user = $ENV{USER};
 open (READ_USER_INFO_LOG, "info.log") || die("-E- Unable to open \"info.log\n");
          @content = <READ_USER_INFO_LOG>;
          close READ_USER_INFO_LOG;
          foreach $line(@content)
          {
             if($line has $user)
             {
                  print "Usenrmae found";
                   break;
             }
           }

score 7 · Answer 1 · edited May 23 '17 at 11:46

Okay, a few things:

Always, always, always use strict; and use warnings;. Each and every single time.
Bareword filehandles are bad. Use a three argument open:
open(my $read_user_info_log,"<","info.log") or die "-E- Unable to open \"info.log\"\n";
$line has $user doesn't mean anything. Instead, you can check each line via a regular expression: if($line=~/$user/){...}
Perl's equivalent of break is last.
You may also want to chomp the lines of your file to remove the trailing end of line characters:
chomp(my @content=<$read_user_info_log>);

Honestly, I'd recommend reading the (newly released) sixth edition of Learning Perl.

score 1 · Answer 2 · answered Mar 05 '12 at 05:50

1

I think you may want to change the line:

 if($line has $user)

to

 if ($line =~ /$user/)

This way, a regular expression will search the line for $user anywhere within it.

answered Mar 05 '12 at 05:50

EMiller

2,792
4
34
55

score 0 · Accepted Answer · answered Mar 05 '12 at 05:49

 $user = $ENV{USER};
 open (READ_USER_INFO_LOG, "info.log") || die("-E- Unable to open \"info.log\n");
          @content = <READ_USER_INFO_LOG>;
          close READ_USER_INFO_LOG;
          foreach $line(@content)
          {
             if($line =~ /$user/)
             {
                  print "Usenrmae found";
                   break;
             }
           }

perl check file contents and match username

3 Answers3