Code getting stuck on insert query

Question

I am running a windows form base application, I am using background worker class for httpwebrequest. And using a webbrowser control, both are saving data to an excel sheet. It was working fine or maybe it was luck , now I see sometime the code gets stuck on the insert statement, it just goes in the

myCommand.ExecuteScalar();

does not come out .And after some time i see this:

The CLR has been unable to transition from COM context 0x7833a8 to COM context 0x7838b0 for 60 seconds. The thread that owns the destination context/apartment is most likely either doing a non pumping wait or processing a very long running operation without pumping Windows messages. This situation generally has a negative performance impact and may even lead to the application becoming non responsive or memory usage accumulating continually over time. To avoid this problem, all single threaded apartment (STA) threads should use pumping wait primitives (such as CoWaitForMultipleHandles) and routinely pump messages during long running operations.

The query where it gets stuck is:

try
{

    myCommand.CommandText = "Insert into [outputsheet$] (website,[facebook page],DealTitle,Dealtime,Dealprice,Dealvalue,Dealdiscount,Dealsaving,Linktitle,address,Category,[Type of Deal]) Values('" + 
        webaddress.Replace("'", "''") + "','" + facbookaddress.Replace("'", "''") + "','" + title.Replace("'", "''") + "','" + dealtime.Replace("'", "''") + "','" + 
        amount.Replace("'", "''") + "','" + value.Replace("'", "''") + "','" + discount.Replace("'", "''") + "','" + saving.Replace("'", "''") + "','" + 
        titleweb.Replace("'", "''") + "','" + address.Replace("'", "''") + "','" + categoryName.Replace("'", "''") + "','Now Deals')";
    myCommand.ExecuteScalar();

}
catch (Exception exp)
{

}

Kindly help, is there anything i need to do .How to avoid it. Thank you

There is really no need to "sanitize" your SQL that way... there are existing libraries that are much better at it. — Ed S., Mar 09 '12 at 23:00
Oh, i do have a clean name function which does that but wanted to show all the things in the query :). — confusedMind, Mar 09 '12 at 23:16
But what I am saying is that there already exists libraries specifically for this purpose which have been heavily tested and do more than a simple replace on `'`. — Ed S., Mar 09 '12 at 23:20
oh , i wasnt awware of that :S..as link would be helpful for future. — confusedMind, Mar 09 '12 at 23:24

score 0 · Answer 1 · answered Mar 09 '12 at 23:15

0

It might have something to do with MDA, as indicated in the post on this Microsoft forum (a few posts down, kind of have to fish for it): http://social.msdn.microsoft.com/forums/en-US/vsdebug/thread/8e04941e-32e1-4901-b360-4859106a5412

answered Mar 09 '12 at 23:15

brazilianldsjaguar

1,409
1
20
45

Nikola Markovinović · Answer 2 · 2012-03-09T23:38:37.143

0

Perhaps you might try encapsulating ExecuteNonQuery in lock() to avoid possibility of sending a request to excel while it is busy doing the previous one?

EDIT: example

If your code that does the insert is encapsulated in a class, you would do something like this:

static private object thisLock = new object();

and later:

lock(thisLock)
{
   myCommand.ExecuteNonQuery();
}

I haven't done a lot of multithreading so I might be way off the mark.

edited Mar 09 '12 at 23:38

answered Mar 09 '12 at 23:19

Nikola Markovinović

18,963
5
46
51

Can you please provide an example. – confusedMind Mar 09 '12 at 23:28
Just did ;-) but check the disclaimer. – Nikola Markovinović Mar 09 '12 at 23:40
Nope same issue, i better try this :[link](http://stackoverflow.com/questions/2797677/contextswitchdeadlock-was-detected-error-in-c-sharp) – confusedMind Mar 10 '12 at 00:10

Code getting stuck on insert query

2 Answers2