ViewHolder not working

Question

I was following this tutorial http://xjaphx.wordpress.com/2011/06/16/viewholder-pattern-caching-view-efficiently/. however, it isnt working. Can you guys help me how to make this working?

class Custom extends Activity {

 private ListView listview;
 private ArrayList mListItem;

 @Override
 protected void onCreate(Bundle savedInstanceState) {
  super.onCreate(savedInstanceState);
        setContentView(R.layout.custom);

  listview = (ListView) findViewById(R.id.list_view);
  mListItem = ItemsDisplay.getItems(true);

  listview.setAdapter(new CustomListAdapter(this, R.id.list_view,mListItem));
 }

 static class ViewHolder {
        public TextView textView;
    }

    private class CustomListAdapter extends ArrayAdapter {
        private ArrayList mList; //--CloneChangeRequired
        private Context mContext;

        public CustomListAdapter(Context context, int textViewResourceId,
                ArrayList list) { //--CloneChangeRequired
            super(context, textViewResourceId, list);
            this.mList = list;
            this.mContext = context;
        }   

        public View getView(int position, View convertView, ViewGroup parent) {
            View view = convertView;

            final ToggleButton tb;

             System.out.println("position "+position+" mList.size"+mList.size());
             if (view == null) {

              LayoutInflater vi = (LayoutInflater) getSystemService(Context.LAYOUT_INFLATER_SERVICE);
              view = vi.inflate(R.layout.list_item_bn, null);
              ViewHolder holder = new ViewHolder();
              holder.textView = (TextView)convertView.findViewById(R.id.tv_name);
              view.setTag(holder);
             }

             ItemsDisplay listItem = (ItemsDisplay) mList.get(position);
             System.out.println("listItem.getName() " +listItem.getName());
                if (listItem != null) {

                 ViewHolder holder1 = (ViewHolder)view.getTag();
                 holder1.textView.setText(listItem.getName());

                }

            return view;  
        }

    }
}

i already looked into these posts, but im not sure why my code still isnt working. How to implement a view holder? ListView with ArrayAdapter and ViewHolder adding icons to the wrong item

score 0 · Answer 1 · answered Dec 18 '14 at 09:08

Hope this works :- Solution: you have to setTag() in "if" condition and getTag() in "else" part.

        public View getView(int position, View convertView, ViewGroup parent) {
        View view = convertView;
        ViewHolder holder ;
        final ToggleButton tb;

         System.out.println("position "+position+" mList.size"+mList.size());
         if (view == null) {
          holder = new ViewHolder();
          LayoutInflater vi = (LayoutInflater) getSystemService(Context.LAYOUT_INFLATER_SERVICE);
          view = vi.inflate(R.layout.list_item_bn, null);

          holder.textView = (TextView)convertView.findViewById(R.id.tv_name);
          view.setTag(holder);
         }
         else{
           holder = (ViewHolder)view.getTag();
         }
         //set the list data here..
         ItemsDisplay listItem = (ItemsDisplay) mList.get(position);

         holder1.textView.setText(listItem.getName());



        return view;  
    }

score 0 · Accepted Answer · answered Mar 12 '12 at 08:19

0

change to:

        final ToggleButton tb;

         System.out.println("position "+position+" mList.size"+mList.size());
         if (convertView == null) {

          LayoutInflater vi = (LayoutInflater) getSystemService(Context.LAYOUT_INFLATER_SERVICE);
          convertView = vi.inflate(R.layout.list_item_bn, null);
          ViewHolder holder = new ViewHolder();
          holder.textView = (TextView)convertView.findViewById(R.id.tv_name);
          convertView.setTag(holder);
         }

         ItemsDisplay listItem = (ItemsDisplay) mList.get(position);
         System.out.println("listItem.getName() " +listItem.getName());
            if (listItem != null) {

             ViewHolder holder1 = (ViewHolder)convertView.getTag();
             holder1.textView.setText(listItem.getName());

            }

        return convertView;

answered Mar 12 '12 at 08:19

idiottiger

5,147
2
25
21

can you look into this code too why it isnt working? all i want to do is use a different layout on the last item of the listview. – antonoVodka Mar 12 '12 at 08:49
int lastpos = mList.size()-1; System.out.println("position: "+position+" mlist: "+lastpos); if(position==lastpos){ view = vi.inflate(R.layout.list_item_record, null); holder.textView = (TextView)view.findViewById(R.id.record_view); }else{ view = vi.inflate(R.layout.list_item_bn, null); holder.textView = (TextView)view.findViewById(R.id.tv_name); } view.setTag(holder); – antonoVodka Mar 12 '12 at 08:49
i already created a question on this. please check. thanks http://stackoverflow.com/questions/9664100/different-layout-on-listview – antonoVodka Mar 12 '12 at 09:01

AndroDev · Answer 3 · 2012-03-12T08:30:35.617

Try this:

public View getView(int position, View convertView, ViewGroup parent) {
    View view = convertView;
    ViewHolder holder;
    final ToggleButton tb;
    System.out.println("position "+position+" mList.size"+mList.size());
    if (view == null) {
        LayoutInflater vi = (LayoutInflater) getSystemService(Context.LAYOUT_INFLATER_SERVICE);
        view = vi.inflate(R.layout.list_item_bn, null);
        holder = new ViewHolder();
        holder.textView = (TextView)view.findViewById(R.id.tv_name);
        view.setTag(holder);
            }
            else {
                holder = (ViewHolder)view.getTag();
            }
    ItemsDisplay listItem = (ItemsDisplay) mList.get(position);
    System.out.println("listItem.getName() " +listItem.getName());
    if (listItem != null) {
        holder.textView.setText(listItem.getName());
        }
        return view;  
    }

ViewHolder not working

3 Answers3

Linked