OnClientClick fired before ValidationGroup

Question

This is the code i'm using:

            <telerik:RadTextBox ID="txtTitre" runat="server" Skin="Windows7" Width="250">
            </telerik:RadTextBox>
            <asp:RequiredFieldValidator ID="RequiredFieldValidator1" runat="server" ErrorMessage="*"
                ForeColor="Red" ControlToValidate="txtTitre" ValidationGroup="validationincident"></asp:RequiredFieldValidator>

And my ASP button:

        <asp:Button ID="Button1" runat="server" Text="Soumettre ce ticket" OnClick="Button1_Click"
            OnClientClick="CloseDialog()" UseSubmitBehavior="false" ValidationGroup="validationincident" />

My problem is it seems OnClientClick is fired before ValidationGroup since the JS function called in my OnClientClick Closes my window.

So the window closes and the "*" (error message) is only displayed when i reopen my window.

I need my ValidationGroup to be checked first! Thanks in advance for your help

score 19 · Accepted Answer · answered Mar 15 '12 at 11:41

19

Use Page_ClientValidate() which checks the client validations

<asp:Button ID="Button1" runat="server" Text="Soumettre ce ticket" OnClick="Button1_Click"
            OnClientClick="if(Page_ClientValidate()) CloseDialog();" UseSubmitBehavior="false" ValidationGroup="validationincident" />

answered Mar 15 '12 at 11:41

PraveenVenu

8,217
4
30
39

i used this and wonder why the messagebox appears twice? i usesd a validation summary and set is show message box to true, any fix? thanks – Albert Laure Nov 11 '13 at 08:07

score 2 · Answer 2 · answered Dec 17 '15 at 07:37

Use Page_ClientValidate() which checks the client validations

<asp:Button ID="Button1" runat="server" Text="Button" 
     OnClientClick="if(Page_ClientValidate()) CloseDialog();" OnClick="Button1_Click"/>

In addition, you can also specify the validation group Page_ClientValidate(validationGroup), in case you have multiple validations on your page:

<asp:Button ID="Button1" runat="server" Text="Button" ValidationGroup="myGroup"
      OnClientClick="if(Page_ClientValidate('myGroup')) CloseDialog();" OnClick="Button1_Click" />

score 1 · Answer 3 · answered Mar 15 '12 at 12:28

1

Make causesValidation="true" for button.

answered Mar 15 '12 at 12:28

ankit rajput

182
2
5

Gourab Dhargupta · Answer 4 · 2018-07-18T09:55:12.957

-1

I ran into the same Problem. This is how i solved it.

 <asp:Button ID="Button1" runat="server" Text="Button" ValidationGroup="myGroup" OnClientClick="Page_ClientValidate()){ return CloseDialog();}else { return false;}" OnClick="Button1_Click" />

edited Jul 18 '18 at 09:55

answered Jul 18 '18 at 09:46

Gourab Dhargupta

1
1

OnClientClick fired before ValidationGroup

4 Answers4