2

I have many threads running in my C# application and each of those threads accesses a TextBox to log its events. When I set the CheckForIllegalCrossThreadCalls property to false, I am able to block many cross-threading errors:

System.InvalidOperationException: Cross-thread operation not valid: Control 'myTextBox'
accessed from a thread other than the thread it was created on.

What is the best solution for this problem? Using delegates or disabling CheckForIllegalCrossThreadCalls as I have tried? Many articles say that disabling CheckForIllegalCrossThreadCalls is not a good programming practice.

DavidRR
  • 18,291
  • 25
  • 109
  • 191
sanchop22
  • 2,729
  • 12
  • 43
  • 66

2 Answers2

12

Disabling CheckForIllegalCrossThreadCalls is like complaining that you get hit by an airbag when crashing your car: the correct solution isn't to remove the airbag, it's to avoid crashing the car.

You simply shouldn't be making UI updates from the wrong thread. You may get away with it most of the time (having disabled the check) but that doesn't mean that it's a good idea - it leaves you open to subtle errors which will only show up occasionally and be really hard to track down.

So yes, use Control.Invoke, Dispatcher.Invoke, BackgroundWorker etc to marshal to the right thread for UI access. That's why those calls/types exist.

Jon Skeet
  • 1,421,763
  • 867
  • 9,128
  • 9,194
0

An answer to a different question has the answer to you. The short answer is: No. Switch to BackgroundWorkers.

Community
  • 1
  • 1
SimpleVar
  • 14,044
  • 4
  • 38
  • 60