Android : Why onClick method is not working?

Question

<uses-sdk android:minSdkVersion="8" />

onClick method defined in xml

 <TextView
    android:id="@+id/titlemainpage"
    android:layout_width="wrap_content"
    android:layout_height="wrap_content"       
    android:text="Social To Dos"   
    android:onClick="testing" />

testing method used in java class is

public void testing(View v){

    Toast.makeText(this, "Clicked", Toast.LENGTH_LONG).show();

    textview.setTextColor(Color.CYAN);
}

You want to override onClick. See [this](http://stackoverflow.com/questions/4613333/clickable-textview-in-android) for more info. — keyser, Mar 26 '12 at 07:52
@ShahzadImam : add `android:clickable="true"` for `textview` — ρяσѕρєя K, Mar 26 '12 at 07:53
@imrankhan:Sorry imran i had not seen ur answer.u answered b4 all... — Shahzad Imam, Mar 26 '12 at 08:08
You have to set setOnClickListener on onCreateView e.g. mBinding.llSpeedHome.setOnClickListener(this) — Ashraf Amin, Jul 14 '22 at 03:15

Android Killer · Accepted Answer · 2015-07-09T05:29:44.167

37

Add one more attribute to the textview in xml:

android:clickable="true"

edited Jul 09 '15 at 05:29

answered Mar 26 '12 at 07:54

Android Killer

18,174
13
67
90

1

Thanks a lot!! It was working out of the box since the day I started making my app... But suddenly today: The TextView's onClick="methodName" was not at all being called on pre-lollipop devices. Why it worked so far is a mystery now :P – Vinay Vissh Feb 28 '17 at 21:24
Don't forget to add setOnClickListener on onCreateView too e.g. mBinding.llSpeedHome.setOnClickListener(this) – Ashraf Amin Jul 14 '22 at 03:16

Samuel Robert · Answer 2 · 2016-09-07T17:23:05.133

2

Buttons are by default clickable but TextViews are not. Unless you explicitly setup the onClick listener at runtime textViews won't be clickable on pre-Lollipop devices.

So if you want to make a TextView clickable which is hooked with a listener in XML layout file you should use

android:clickable="true"

edited Sep 07 '16 at 17:23

answered Aug 17 '16 at 06:36

Samuel Robert

10,106
7
39
60

score 1 · Answer 3 · answered Mar 03 '17 at 14:17

1

Dont forget to remove the on click listener (if you have set that programmatically inside the containing activity).

answered Mar 03 '17 at 14:17

Vigneshwaran Murugesan

747
4
19

score 0 · Answer 4 · answered Jul 14 '22 at 03:15

0

You have to set setOnClickListener on onCreateView e.g. mBinding.llSpeedHome.setOnClickListener(this)

answered Jul 14 '22 at 03:15

Ashraf Amin

343
3
7

score -3 · Answer 5 · answered Mar 26 '12 at 07:51

-3

I might be wrong but I think you have to implement a listener rather than using a simple function.

Check this website.

answered Mar 26 '12 at 07:51

M Rajoy

4,028
14
54
111

onClick via XML is a feature since 1.6: http://developer.android.com/about/versions/android-1.6.html – Volker Stolz Jan 26 '16 at 17:37

Android : Why onClick method is not working?

5 Answers5