git stash show -p | git apply --reverse
Warning, that would not in every case: "git apply -R
"(man) did not handle patches that touch the same path twice correctly, which has been corrected with Git 2.30 (Q1 2021).
This is most relevant in a patch that changes a path from a regular file to a symbolic link (and vice versa).
See commit b0f266d (20 Oct 2020) by Jonathan Tan (jhowtan
).
(Merged by Junio C Hamano -- gitster
-- in commit c23cd78, 02 Nov 2020)
apply
: when -R
, also reverse list of sections
Helped-by: Junio C Hamano
Signed-off-by: Jonathan Tan
A patch changing a symlink into a file is written with 2 sections (in the code, represented as "struct patch"): firstly, the deletion of the symlink, and secondly, the creation of the file.
When applying that patch with -R
, the sections are reversed, so we get: (1) creation of a symlink, then (2) deletion of a file.
This causes an issue when the "deletion of a file" section is checked, because Git observes that the so-called file is not a file but a symlink, resulting in a "wrong type" error message.
What we want is: (1) deletion of a file, then (2) creation of a symlink.
In the code, this is reflected in the behavior of previous_patch()
when invoked from check_preimage()
when the deletion is checked.
Creation then deletion means that when the deletion is checked, previous_patch()
returns the creation section, triggering a mode conflict resulting in the "wrong type" error message.
But deletion then creation means that when the deletion is checked, previous_patch()
returns NULL
, so the deletion mode is checked against lstat, which is what we want.
There are also other ways a patch can contain 2 sections referencing the same file, for example, in 7a07841c0b ("git-apply
: handle a patch that touches the same path more than once better", 2008-06-27, Git v1.6.0-rc0 -- merge). "git apply -R
"(man) fails in the same way, and this commit makes this case succeed.
Therefore, when building the list of sections, build them in reverse order (by adding to the front of the list instead of the back) when -R
is passed.