Attempt to re-open an already-closed object: java.lang.IllegalStateException:?

Question

I know this question has asked many times in SO,but i couldn't figure out my exact problem.

I am using the following code to get the data from the database(Table1) and update another Table2 based on retrieval value. Its working fine in some android versions but when i gone to test with Android 4.0.3. I am geting this java.lang.IllegalStateException:?.attempt to re-open an already-closed object at sum_cursor.moveToNext();.

I am using this code in AsyncTask.

 /** Sum of total matched values*/
            Cursor sum_cursor = db.gettotalMatchvalue(this);
             if(sum_cursor!=null)
             {
                 sum_cursor.moveToFirst();
                 for(int j=0; j<sum_cursor.getCount();j++)
                 {    
                     float totalmatchedscore = sum_cursor.getInt(0);
                     float totalingredients = Float.parseFloat(sum_cursor.getString(sum_cursor.getColumnIndex(APPDatabase.CK_TOTALINCREDIENTS)));
                     /**average = totalscore/totalingredients*/
                     double average = totalmatchedscore/totalingredients;
                     int id = Integer.parseInt(sum_cursor.getString(sum_cursor.getColumnIndex(APPDatabase.CK_ID))); 

                 db.updateAverage(id, average); 
                 sum_cursor.moveToNext(); //Here is the problem
                 }  
             }   
             db.close();

My update method coding

/** Update average */
public void updateAverage(int id,double average)
{
    SQLiteDatabase db = getWritableDatabase();
    ContentValues values = new ContentValues();
    values.put(CK_FINALVALUE,average);
    db.update(TABLE, values,CK_ID+" = "+id , null);   
}

What i am doing wrong here?

I know many of you come across this situation. Could you help me guys.

Thanks for your help.

Maybe you have closed the database outside of the async task. Have you checked for that? — Todd Davies, Jul 24 '12 at 15:04
Is the system that 4.0.3 is running on any faster than the other systems you're using, if so you could have some race conditions occurring. — Todd Davies, Jul 24 '12 at 15:07
An observation: your code for looping over the cursor is more complex than it needs to be. See http://stackoverflow.com/questions/10723770/what-is-the-neatest-way-to-iterate-over-the-results-in-an-android-cursor — Graham Borland, Jul 25 '12 at 08:54

score 23 · Accepted Answer · answered Jul 25 '12 at 08:45

You can't update a table while iterating over the results of a query. There are good reasons for this; what if the data you are adding would cause a change to the data you're iterating over? Your cursor would not return valid data.

Trying to store data back into the table in updateAverage() is causing the problem. You should just remember the average value during your loop, and then update it once at the end after you've finished looping over your cursor.

To further explain the exact error you're getting: the act of inserting new data is causing the database to close all the cursors which are currently open, as a safety measure. So when you call sum_cursor.moveToNext() after updating the average, the cursor is a bit surprised to find that it's already been closed.

Thanks for your fabulous information.. From your info what i got is store the average value in array or list and then update it in another loop.. Am i right — vinothp, Jul 25 '12 at 08:49
thanks i will try it and let you know.. and thanks for your immediate support +1 for that — vinothp, Jul 25 '12 at 08:52

score 2 · Answer 2 · answered Jul 24 '12 at 15:04

2

What if you comment out db.updateAverage(id, average) ?

answered Jul 24 '12 at 15:04

Alexander Kulyakhtin

47,782
38
107
158

thanks for your answer.. actually `db.updateAverage(id, average)` is very important.. based on this update only i am going to next step – vinothp Jul 24 '12 at 15:10
@Vinoth I mean, if you comment it out does then the error go away? – Alexander Kulyakhtin Jul 24 '12 at 15:24
sorry alex i couldn't test now because that phone was my friends.. i can test only tomorrow and let you know.. its really wired – vinothp Jul 24 '12 at 15:33
I mean, db.updateAverage seems to be the only place in your code of which no one except you can know. – Alexander Kulyakhtin Jul 24 '12 at 15:39
@Vinoth Perhaps db.update invalidates your current Cursor. Anyway, db.update changes the table contents and you are still keeping the old cursor, that's incorrect. – Alexander Kulyakhtin Jul 25 '12 at 08:08
@Alex thanks what can i do now.. have u got any idea shall i move `sum_cursor.moveToNext` before db.update.. will that work – vinothp Jul 25 '12 at 08:21

score 0 · Answer 3 · answered Sep 18 '14 at 11:04

You can achieve your goal with pure SQL it is faster and better from architecture point of View because all logic will be in one SQL transaction

REPLACE INTO table_where_to_put  SELECT *, (totalmatchedscore/totalingredients) as average  FROM table_with_input_data

Use REPLACE OR UPDATE

Attempt to re-open an already-closed object: java.lang.IllegalStateException:?

3 Answers3

Linked