Android getIntent() returns the first intent

Question

I have developed an application to download a video file and store it in the SD card. In the process I also update the progress and status of the download as a status bar notification using the NotificationManager.

My class called the DownloadTask.java extends the AsyncTask. So here I update the progress using the onProgressUpdate() method where in I use the NotificationManager for the purpose. Everything works like a charm except, on completion of download I want to click the notification to open the specific video file. So this is what i have done:

mNotificationManager = (NotificationManager) mContext.getSystemService(Context.NOTIFICATION_SERVICE);

int icon = android.R.drawable.stat_sys_download_done;
long when = System.currentTimeMillis();

mNotification = new Notification(icon, "", when);
mContentTitle_complete = mContext.getString(R.string.download_complete);
notificationIntent = new Intent(mContext,OpenDownloadedVideo.class);
notificationIntent.putExtra("fileName", file);
mContentIntent = PendingIntent.getActivity(mContext, 0, notificationIntent, 0);
mNotification.setLatestEventInfo(mContext, file, mContentTitle_complete, mContentIntent);
mNotification.flags = Notification.FLAG_AUTO_CANCEL;
mNotificationManager.notify(NOTIFICATION_ID, mNotification);

Note that the fileName and NOTIFICATION_ID are unique in my case.

The Activity OpenDownloadedVideo.java opens the file by:

public void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    try {  
        fileName = getIntent().getExtras().getString("fileName");
        Intent i = new Intent(Intent.ACTION_VIEW);
        File videoFileToPlay = new File(Environment.getExternalStorageDirectory()+"/MyFolder"+"/"+fileName);
        i.setDataAndType(Uri.fromFile(videoFileToPlay), "video/*");
        startActivity(i);
        finish();
    } catch(Exception e) {
        //
    }
}

So when I download a video for the first time and click on the notification the appropriate video file will be opened. However next time when I download another video, and click on the notification the first file which was downloaded will be opened again.

This is because getIntent inside OpenDownloadedVideo returns the first Intent created and not the latest. How can I correct this?

Also, please note that the problem scenario exists when I download more than one video, e.g. if I download five different video files and there are five notifications in the status bar. The same file will be opened each time a notification is clicked.

ban-geoengineering · Answer 1 · 2017-07-25T12:13:52.560

12

/**
 * Override super.onNewIntent() so that calls to getIntent() will return the
 * latest intent that was used to start this Activity rather than the first
 * intent.
 */
@Override
public void onNewIntent(Intent intent){
    super.onNewIntent(intent); // Propagate.
    setIntent(intent); // Passing the new intent to setIntent() means this new intent will be the one returned whenever getIntent() is called.
}

edited Jul 25 '17 at 12:13

answered Oct 30 '14 at 12:23

ban-geoengineering

18,324
27
171
253

score 11 · Answer 2 · answered May 22 '13 at 00:32

11

actually you just need create PendingIntent with PendingIntent.FLAG_UPDATE_CURRENT ,like this:

mContentIntent = PendingIntent.getActivity(mContext, 0, notificationIntent, PendingIntent.FLAG_UPDATE_CURRENT);

answered May 22 '13 at 00:32

Royer

172
1
6

score 9 · Answer 3 · edited Jun 20 '20 at 09:12

9

From the Android Activity.onNewIntent() documentation

Note that getIntent() still returns the original Intent. You can use setIntent(Intent) to update it to this new Intent.

So when you get the new Intent, you need to explicitly set it as the activity intent.

edited Jun 20 '20 at 09:12

Community

1
1

answered Aug 24 '12 at 11:31

codinguser

5,562
2
33
40

also, to retrieve the new intent you have to override onNewIntent(), calling getIntent() will return the old one even if you use setIntent() – DoruChidean Oct 15 '15 at 13:38
This is a great answer. I needed to basically use setIntent or call the super method for onNewIntent() to make sure getIntent returned the latest intent. – welshk91 Apr 03 '16 at 04:58

score 5 · Accepted Answer · edited May 23 '17 at 12:17

@Alex and @Codinguser, thank you for your replies. Much appreciated. However I found a different answer that worked for me. When creating a PendingIntent for the Intent pass a unique value to it. In my case I was doing this:

mContentIntent = PendingIntent.getActivity(mContext, 0, notificationIntent, 0);

but now I'm using NOTIFICATION_ID since it was unique. I've changed the above call to:

mContentIntent = PendingIntent.getActivity(mContext, NOTIFICATION_ID,
                                           notificationIntent, 0);

That's all and it works.

I found some information on it in the question Mulitple Instances of Pending Intent

score 0 · Answer 5 · answered Aug 24 '12 at 10:58

0

What if you make your OpenDownloadedVideo activity SINGLE_TOP and override onNewIntent?

answered Aug 24 '12 at 10:58

Alexander Kulyakhtin

47,782
38
107
158

how do i do that ?? sorry Im quite new to this. – Bopanna Aug 24 '12 at 11:00
I don't know if it will help or not. In manifest editor you add SINGLE_TOP for your Activity launch mode. Then you override your Activity's onNewIntent() and put the same code in there as you have in onCreate – Alexander Kulyakhtin Aug 24 '12 at 11:04
I have made the `OpenDownloadedVideo` activity `SINGLE_TOP` and inside the activity i have overriden the `onNewIntent` as well as you suggested.... But when the activity is launched or re-launched it doesn't seem to go inside the `onNewIntent` method. – Bopanna Aug 28 '12 at 06:16
@Bopanna Perhaps it's not relaunched but paused and then resumed? – Alexander Kulyakhtin Aug 28 '12 at 08:53

score 0 · Answer 6 · answered Mar 11 '19 at 17:42

0

in the activity you're intent is launching. Add (override) the following function:

@Override
protected void onNewIntent(final Intent intent) {
        super.onNewIntent(intent);
        this.setIntent(intent);
}

answered Mar 11 '19 at 17:42

Elad

1,523
13
10

Android getIntent() returns the first intent

6 Answers6