12

Well, this is not exactly a question, as I'm not really "stuck" on my code, but I've found some strange behavior for Android API regarding accessing the external storage and the File.createTempFile() method, and I'd like to understand what's happening...

Please note that my manifest does not include the <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE">.

Part 1 :

I have the following code which does work as a charm :

File tempFile = new File(Environment.getExternalStorageDirectory(),
                      "my_temp_file.png");

it creates a temporary file for me, and I can write datas in it without any trouble.

Question 1 : Why does it work, as I'm not supposed to have writing rights on my SDCard ?

Part 2 :

I've tried to change my code to use the createTempFile which is the official method to create temporary file. So I've tried :

File tempFile = File.createTempFile("my_temp", "png", 
                      Environment.getExternalStorageDirectory());

and added the WRITE_EXTERNAL_STORAGE in my manifest.xml. Guess what ? This does not work, and I get a java.io.IOException :

09-07 14:07:29.061: E/_CLOG(19982): java.io.IOException: Permission denied
09-07 14:07:29.061: E/_CLOG(19982):     at java.io.File.createNewFileImpl(Native Method)
09-07 14:07:29.061: E/_CLOG(19982):     at java.io.File.createNewFile(File.java:1257)
09-07 14:07:29.061: E/_CLOG(19982):     at java.io.File.createTempFile(File.java:1322)
09-07 14:07:29.061: E/_CLOG(19982):     at com.(...).onClick(ProfileImageUpdater.java:58)

Question 2 : Why this doesn't work, whereas imho it should ?

Orabîg
  • 11,718
  • 6
  • 38
  • 58
  • Which android api are you using? I believe if one sets the api to level 4 then certain permission are not enforced – tomi Sep 07 '12 at 12:57

3 Answers3

14

try like this...

File outputDir = context.getCacheDir(); // context being the Activity pointer
File outputFile = File.createTempFile("prefix", "extension", outputDir);

Edit :

for Question 2

It may be issue as below link...

Environment.getExternalStorageDirectory does not return the path to the removable storage

Community
  • 1
  • 1
Priyank Patel
  • 12,244
  • 8
  • 65
  • 85
  • I tryed and you're right, it works, and it's a better place for temp files than the external dir. However, this does not answer my questions... Please, re-read. – Orabîg Sep 07 '12 at 12:31
4

you're getting this error because you declare on the manifest.xml permission to write to the external storage. you need to add this permission.

also, do never ever ever ever write files (specially temporary ones) directly on the getExternalStorage().

This will put directly on the SD-card and will create a mess. For temporary files that is only to be seen by your own application you should use:

getExternalStorage() + "/Android/data/<package_name>/cache/"

replacing by your app packaged, e.g. com. Orabig.myFirstApp that special folder is automatically deleted from the system if the user uninstall the application, keeping the system free from temporary files.

edit:

Please note that my manifest does not include the

you have to!

edit: also, if you creating temporary media files (PNG for example) is good practice to create an empty file named .nomedia on that folder. That way you avoid the Media Scanner scanning it and showing it on the gallery.

last edit:

and before creating files you must create the folder by calling mkdirs() on the File object.

Budius
  • 39,391
  • 16
  • 102
  • 144
  • I guess you mean `new File(Environment.getExternalStorageDirectory(), "/Android/data//cache/temp_crop_file.png");` ? – Orabîg Sep 07 '12 at 12:25
  • I was pointing to the folder only. Then you create any file you want over there. =] and don't forget you HAVE TO DECLARE on the manifest or else you'll always get an error. – Budius Sep 07 '12 at 12:26
  • Thanks for the tip about the directory (good point) and the .nomedia (very good point). However, you did not read carefully my question when you say "you have to". My first code DO work, but I'm asking : "why does it work", not "what do I have to do to make it work". :) – Orabîg Sep 07 '12 at 12:28
  • ops, you're right. I didn't fully read. Just re-read now. And honestly, I don't know why it worked. It really shouldn't. Sorry, can't help. ps. there's an extra edit about creating the dirs first. – Budius Sep 07 '12 at 12:31
-1

I finally figured out what was hapenning...

Question 1 : In fact, the file that was created was meant to be used by the system application to retrieve and crop an image from the user's gallery. So my app didn't have to own the WRITE_EXTERNAL_STORAGE permission, as the file was written by the system itself.

Question 2 : I'm not sure. I guess that the Android do not allow to create a temporary file where I was trying to (as it's not the right place for it)

Orabîg
  • 11,718
  • 6
  • 38
  • 58