80

We now have the "dot" notation for properties. I've seen various back and forths about the merits of dot notation vs. message notation. To keep the responses untainted I'm not going to respond either way in the question.

What is your thought about dot notation vs. message notation for property accessing?

Please try to keep it focused on Objective-C - my one bias I'll put forth is that Objective-C is Objective-C, so your preference that it be like Java or JavaScript aren't valid.

Valid commentary is to do with technical issues (operation ordering, cast precedence, performance, etc), clarity (structure vs. object nature, both pro and con!), succinctness, etc.

Note, I'm of the school of rigorous quality and readability in code having worked on huge projects where code convention and quality is paramount (the write once read a thousand times paradigm).

jscs
  • 63,694
  • 13
  • 151
  • 195
groundhog
  • 4,770
  • 2
  • 24
  • 24
  • 1
    The source code editor should adjust to the programmer's personal preference, without changing the characters of the file itself. That way everybody would get what they like. – Arne Evertsson May 06 '10 at 09:15

19 Answers19

64

Do not use dot for behavior. Use dot to access or set attribute like stuff, typically attributes declared as properties.

x = foo.name; // good
foo.age = 42; // good

y = x.retain; // bad

k.release; // compiler should warn, but some don't. Oops.

v.lockFocusIfCanDraw; /// ooh... no. bad bad bad

For folks new to Objective-C, I would recommend not using the dot for anything but stuff declared as @property. Once you have a feel for the language, do what feels right.

For example, I find the following perfectly natural:

k = anArray.count;
for (NSView *v in myView.subviews) { ... };

You can expect that the clang static analyzer will grow the ability to allow you to check that the dot is being used only for certain patterns or not for certain other patterns.

bbum
  • 162,346
  • 23
  • 271
  • 359
  • Dot notation is used only for accessor methods. This mean that cal be used as alternative to [foo getBar], or [foo setBar: bar]; it cannot be used for a generic method. – apaderno Dec 17 '09 at 03:15
  • 13
    That is incorrect. Dot notation is a straight forward synonym for an equivalent method call; nothing more, nothing less. – bbum Dec 17 '09 at 05:31
  • 2
    I wonder why dot notation was not restricted to @property-declared accessors. It seems like it would have allowed class authors to resolve gray areas over which methods should be allowed in dot notation, and it wouldn't feel so ambiguous whether or not to use methods like `.uppercaseString` if the class was allowed to express its intent and have it enforced by the compiler. Perhaps there's something I'm missing that requires the current implementation of dot notation. –  Jul 04 '10 at 22:08
  • 4
    It could have been limited to `@property` only but that would both require the consumer of an API to learn another boolean dimension of information and designers of API to quite likely drown in arguments over what should and should not be an `@property`. Note that Xcode prefers -- weights more heavily -- `@property` implied methods when completing code.... It is encouraged, but not enforced. – bbum Jul 05 '10 at 03:58
  • While this is excellent coding practice, I am confused why this top-voted answer doesn't answer the original posted question, which is: should we code with `myObj.prop` or `[myObj prop]`? – rodamn Mar 18 '14 at 22:15
  • 1
    @rodamn It does answer that; it recommends to use the dot with `@property` declared accessors only when new to the language. As one gains confidence with coding in Objective-C, do what feels right. Interesting; many of us have swung back to very very limited use of the dot. – bbum May 03 '14 at 18:01
22

Let me start off by saying that I started programming in Visual/Real Basic, then moved on to Java, so I'm fairly used to dot syntax. However, when I finally moved to Objective-C and got used to brackets, then saw the introduction of Objective-C 2.0 and its dot syntax, I realized that I really don't like it. (for other languages it's fine, because that's how they roll).

I have three main beefs with dot syntax in Objective-C:

Beef #1: It makes it unclear why you might be getting errors. For example, if I have the line:

something.frame.origin.x = 42;

Then I'll get a compiler error, because something is an object, and you can't use structs of an object as the lvalue of an expression. However, if I have:

something.frame.origin.x = 42;

Then this compiles just fine, because something is a struct itself that has an NSRect member, and I can use it as an lvalue.

If I were adopting this code, I would need to spend some time trying to figure out what something is. Is it a struct? Is it an object? However, when we use the bracket syntax, it's much clearer:

[something setFrame:newFrame];

In this case, there is absolutely no ambiguity if something is an object or not. The introduction of ambiguity is my beef #1.

Beef #2: In C, dot syntax is used to access members of structs, not call methods. Programmers can override the setFoo: and foo methods of an objects, yet still access them via something.foo. In my mind, when I see expressions using dot syntax, I'm expecting them to be a simple assignation into an ivar. This is not always the case. Consider a controller object that mediates an array and a tableview. If I call myController.contentArray = newArray;, I would expect it to be replacing the old array with the new array. However, the original programmer might have overridden setContentArray: to not only set the array, but also reload the tableview. From the line, there's no indication of that behavior. If I were to see [myController setContentArray:newArray];, then I would think "Aha, a method. I need to go see the definition of this method just to make sure I know what it's doing."

So I think my summary of Beef #2 is that you can override the meaning of dot syntax with custom code.

Beef #3: I think it looks bad. As an Objective-C programmer, I'm totally used to bracket syntax, so to be reading along and see lines and lines of beautiful brackets and then to be suddenly broken with foo.name = newName; foo.size = newSize; etc is a bit distracting to me. I realize that some things require dot syntax (C structs), but that's the only time I use them.

Of course, if you're writing code for yourself, then use whatever you're comfortable with. But if you're writing code that you're planning on open sourcing, or you're writing something you don't expect to maintain forever, then I would strong encourage using bracket syntax. This is, of course, just my opinion.

Blog post against dot syntax: https://bignerdranch.com/blog/dot-notation-syntax/

Rebuttal to above post: http://eschatologist.net/blog/?p=226 (with original article in favor of dot syntax: http://eschatologist.net/blog/?p=160)

Giovanni Cappellotto
  • 4,597
  • 1
  • 30
  • 33
Dave DeLong
  • 242,470
  • 58
  • 448
  • 498
  • 5
    Beef #1 seems a little specious to me. I don't see how that's a concern any more than you might try sending a message to a struct and then have to figure out that the variable is actually a struct. Do you actually see a lot of people who understand how it works getting confused by this in practice? This seems like the sort of thing that you'd mess up once, learn about the lvalue thing, and then do it right in the future — just like, say, not trying to treat NSNumbers like ints. – Chuck Aug 09 '09 at 03:32
  • 2
    @Chuck it is somewhat of an edge case, but I do quite a bit of contract development, which involves inheriting projects and having to work with them. *Usually* `something` is an object, but I've come across a couple places where the original authors have created structs (for speed, lower memory usage, etc), and I have to spend a good couple minutes trying to figure out why the code doesn't compile. – Dave DeLong Aug 14 '09 at 15:59
14

I'm a new Cocoa/Objective-C developer, and my take on it is this:

I stick to the messaging notation, even though I started with Obj-C 2.0, and even though the dot notation is more familiar feeling (Java is my first language.) My reason for this is pretty simple: I still don't understand exactly why they added the dot notation to the language. To me it seems like an unnecessary, "impure" addition. Although if anyone can explain how it benefits the language, I'd be happy to hear it.

However, I consider this a stylistic choice, and I don't think there is a right or wrong way, as long as it's consistent and readable, just as with any other stylistic choice (like putting your opening curly brace on the same line as the method header or the next line).

Ellie P.
  • 4,133
  • 3
  • 30
  • 30
  • 2
    +1 great answer. I'd really like to know the "why" behind it as well. Perhaps bbum or mmalc knows the answer... (they both work at ) – Dave DeLong Aug 08 '09 at 18:25
11

Objective-C dot notation is a syntactic sugar that is translated to normal message passing, so under the hood changes nothing and makes no difference at runtime. Dot notation it is absolutely not faster than message passing.

After this needed little preamble here's pros and cons seen by me :

Dot notation pros and cons

  • pros

    • readability : dot notation is easier to read than nested brackets massages passing
    • It simplifies interaction with Attributes and Properties: using dot notation for properties and message notation for methods you can achieve separation of state and behavior at the synthax level
    • It is possible to use compound assignment operator (1).
    • using the @property and dot notation the compiler do a lot of work for you, it can generate code for good Memory Management when getting and setting the property; this is why dot notation is suggested by Apple itself official guides.
  • cons

    • Dot notation is allowed only for access to a declared @property
    • Since Objective-C is a layer above standard C(language extension), the dot notation doesn’t really make clear if the accessed entity is a an object or a struct. Often, it looks like you are accessing properties of a struct.
    • calling a method with the dot notation you lose named parameters readability advantages
    • when mixed message notation and dot notation seems like you are coding in two different languages

Code Examples :

(1)Compound operator usage code example :

//Use of compound operator on a property of an object
anObject.var += 1;
//This is not possible with standard message notation
[anObject setVar:[anObject var] + 1];
aleroot
  • 71,077
  • 30
  • 176
  • 213
7

Using the style of a language, consistent with the language itself, is the best advice here. However, this isn't a case of writing functional code in an OO system (or vice versa) and the dot notation is part of the syntax in Objective-C 2.0.

Any system can be misused. The existence of the preprocessor in all C based languages is enough to do really quite weird things; just look at the Obfuscated C Contest if you need to see exactly how weird it can get. Does that mean the preprocessor is automatically bad and that you should never use it?

Using the dot syntax for accessing properties, which have been defined as such in the interface, is open to abuse. The existence of abuse in potentia shouldn't necessarily be the argument against it.

Property access may have side-effects. This is orthogonal to the syntax used to acquire that property. CoreData, delegation, dynamic properties (first+last=full) will all necessarily do some work under the covers. But that would be confusing 'instance variables' with 'properties' of an object. There's no reason why properties should necessarily need to be stored as-is, especially if they can be computed (e.g. length of a String, for example). So whether you use foo.fullName or [foo fullName] there's still going to be dynamic evaluation.

Lastly, the behaviour of the property (when used as an lvalue) is defined by the object itself, like whether a copy is taken or whether it is retained. This makes it easier to change the behaviour later - in the property definition itself - rather than having to re-implement methods. That adds to the flexibility of the approach, with the resulting likelihood of less (implementation) errors occurring. There's still the possibility of choosing the wrong method (i.e. copy instead of retain) but that's an architectural rather than implementation issue.

Ultimately, it boils down to the 'does it look like a struct' question. This is probably the main differentiator in the debates so far; if you have a struct, it works differently than if you have an object. But that's always been true; you can't send a struct a message, and you need to know if it's stack-based or reference/malloc based. There are already mental models which differ in terms of usage ([[CGRect alloc] init] or struct CGRect?). They've never been unified in terms of behaviour; you need to know what you're dealing with in each case. Adding property denotation for objects is very unlikely to confuse any programmer who knows what their data types are; and if they don't, they've got bigger problems.

As for consistency; (Objective-)C is inconsistent within itself. = is used both for assignment and equality, based on lexical position in the source code. * is used for pointers and multiplication. BOOLs are chars, not bytes (or other integer value), despite YES and NO being 1 and 0 respectively. Consistency or purity isn't what the language was designed for; it was about getting things done.

So if you don't want to use it, don't use it. Get it done a different way. If you want to use it, and you understand it, it's fine if you use it. Other languages deal with the concepts of generic data structures (maps/structs) and object types (with properties), often using the same syntax for both despite the fact that one is merely a data structure and the other is a rich object. Programmers in Objective-C should have an equivalent ability to be able to deal with all styles of programming, even if it's not your preferred one.

AlBlue
  • 23,254
  • 14
  • 71
  • 91
6

I've mostly been raised in the Objective-C 2.0 age, and I prefer the dot notation. To me, it allows the simplification of code, instead of having extra brackets, I can just use a dot.

I also like the dot syntax because it makes me really feel like I'm accessing a property of the object, instead of just sending it a message (of course the dot-syntax really does translate into message sending, but for the sake of appearances, the dot feels different). Instead of "calling a getter" by the old syntax, it really feels like I'm directly getting something useful from the object.

Some of the debate around this is concerned with "But we already have dot-syntax, and it's for structs!". And that's true. But (and again, this is just psychological) it basically feels the same to me. Accessing a property of an object using dot-syntax feels the same as accessing a member of a struct, which is more or less the intended effect (in my opinion).

****Edit: As bbum pointed out, you can also use dot-syntax for calling any method on an object (I was unaware of this). So I will say my opinion on dot-syntax is only for dealing with properties of an object, not everyday message sending**

jbrennan
  • 11,943
  • 14
  • 73
  • 115
6

I use it for properties because

for ( Person *person in group.people){ ... }

is a little easier to read than

for ( Person *person in [group  people]){ ... }

in the second case readability is interupted by putting your brain into message sending mode, whereas in the first case it is clear you are accessing the people property of the group object.

I will also use it when modifying a collection, for instance:

[group.people addObject:another_person];

is a bit more readable than

[[group people] addObject:another_person];

The emphasis in this case should be in the action of adding an object to the array instead of chaining two messages.

rebo
  • 1,067
  • 1
  • 7
  • 10
3

I much prefer the messaging syntax... but just because that is what I learned. Considering a lot of my classes and what not are in Objective-C 1.0 style, I wouldn't want to mix them. I have no real reason besides "what I'm used to" for not using the dot syntax... EXCEPT for this, this drives me INSANE

[myInstance.methodThatReturnsAnObject sendAMessageToIt]

I don't know why, but it really infuriates me, for no good reason. I just think that doing

[[myInstance methodThatReturnsAnObject] sendAMessageToIt]

is more readable. But to each his own!

micmoo
  • 5,991
  • 3
  • 22
  • 16
  • 3
    I do this from time to time, but only if I'm accessing a property. For example: `[self.title lowercaseString]` or something. But I can see stylistically why it's bothersome to mix and match syntax. The only reason I do it is to keep straight what's a property and what is a method that returns an object (I know properties are really just that, but you hopefully get what I mean). – jbrennan Aug 08 '09 at 18:25
3

Honestly, I think it comes down to a matter of style. I personally am against the dot syntax (especially after just finding out that you can use it for method calls and not just reading/writing variables). However, if you are going to use it, I would strong recommend not using it for anything other than accessing and changing variables.

3

One of the main advantages of object-oriented programming is that there is no direct access to internal state of the objects.

Dot syntax seems to me to be an attempt to make it look and feel as though state is being accessed directly. But in truth, it's just syntactic sugar over the behaviors -foo and -setFoo:. Myself, I prefer to call a spade a spade. Dot syntax helps readability to the extent that code is more succinct, but it doesn't help comprehension because failing to keep in mind that you're really calling -foo and -setFoo: could spell trouble.

Synthesized accessors seem to me to be an attempt to make it easy to write objects in which state is accessed directly. My belief is that this encourages exactly the kind of program design that object-oriented programming was created to avoid.

On balance, I would rather dot syntax and properties had never been introduced. I used to be able to tell people that ObjC is a few clean extensions to C to make it more like Smalltalk, and I don't think that's true any more.

hatfinch
  • 3,095
  • 24
  • 35
2

Many people seems to be mixing up 'properties' with 'instance variables'. The point of the properties is to make it possible to modify the object without having to know its internals, I think. The instance variable is, most of the time, the 'implementation' of a property (which in turn is the 'interface'), but not always: sometimes a property does not correspond to an ivar, and instead it calculates a return value 'on the fly'.

That's why I believe the idea that "the dot syntax tricks you into thinking you're accessing the variable so it's confusing" is wrong. Dot or bracket, you shouldn't make assumptions about the internals: it's a Property, not an ivar.

Nicolas Miari
  • 16,006
  • 8
  • 81
  • 189
  • As a side note, Objective-C object _references_ are not direct C structs variables, but rather more like 'pointers to structs', so the dot syntax wouldn't make sense to access members directly; it is the arrow operator `->` that fulfills that role (whenever said ivars aren't access-restricted, of course). – Nicolas Miari Jun 08 '15 at 09:00
2

In my opinion, the dot syntax makes Objective-C less Smalltalk-esque. It can make code look simpler, but adds ambiguity. Is it a struct, union, or object?

dreamlax
  • 93,976
  • 29
  • 161
  • 209
1

I think I might switch to messaging instead of dot notation because in my head object.instanceVar is just instanceVar that belongs to object, to me it doesn't look at all like a method call, which it is, so there could be things going on in your accessor and whether you use instanceVar or self.instanceVar could have much more of a difference than simply implicit vs. explicit. Just my 2¢.

mk12
  • 25,873
  • 32
  • 98
  • 137
1

Use dot notation (whenever you can)

On instance methods returning some value

Do not use dot notation

On instance methods returning void, on init methods or on Class method.

And my personal favorite exception

NSMutableArray * array = @[].mutableCopy;
Nicolas Manzini
  • 8,379
  • 6
  • 63
  • 81
1

The dot notation tries to make messages look like accesses to a member of a struct, which they are not. Might work fine in some cases. But soon someone will come up with something like this:

NSView *myView = ...;
myView.frame.size.width = newWidth;

Looks fine. But is not. It's the same as

[myView frame].size.width = newWidth;

which doesn’t work. The compiler accepts the first, but rightfully not the second. And even if it emitted an error or warning for the first this is just confusing.

Sven
  • 22,475
  • 4
  • 52
  • 71
1

Call me lazy but if I had to type a single '.' vs. two [ ] each time to get the same results I would prefer a single . I hate verbose languages. The () in lisp drove me nuts. Elegant language such as mathematics are concise and effective, all others fall short.

Joe
  • 11
  • 1
  • 1
    The problem is Mathematics, though concise and effective, is not a regular language and so we can't parse and compile it. Notice, for example, in math functions it's common to write them with parentheses, because it would be much more difficult to follow without. – jbrennan Nov 07 '10 at 02:48
0

I personally don't use dot-notation at all in code. I only use it in CoreData KVC binding expression when required.

The reason for not using them in code for me is that the dot-notation hides the setter semantics. Setting a property in dot-notation always looks like assignment regardless of the setter semantics (assign/retain/copy). Using the message-notation makes it visible that the receiving object has control over what happens in the setter and underlines the fact the those effects need to be considered.

I'm still considering whether I might want to use dot-notation when retrieving the value of a KVC compliant or declared property because it admittedly is a bit more compact and readable and there are no hidden semantics. Right now I'm sticking with message-notation for sake of consistency.

VoidPointer
  • 17,651
  • 15
  • 54
  • 58
  • 1
    There still might be hidden things going on. A getter can do other things than just return an instance variable. Even if it is a declared property the getter doesn’t have to be synthesized or it could have been overridden in a subclass. – Sven Aug 30 '10 at 12:41
-1

OK, dot notation in Objective-C looks strange, indeed. But I still can't do the following without it:

int width = self.frame.size.width;

Works fine, but:

int height = [[[self frame] size] height];

Gives me "Cannot convert to a pointer type". I'd really like to keep my code looking consistent with message notation, though.

  • 5
    -frame returns an NSRect, which is a C struct, not an Objective-C object. That's why the second example causes a compiler error. It should be: int height = [self frame].size.height; –  Feb 19 '11 at 09:29
  • 1
    Agreed. But the dot after the bracket looks awful! I usually store the rect in a local variable first. – Nicolas Miari Jun 17 '12 at 06:07
-2

This is a great question and I see many different answers to this. Although many have touched upon the topics, I will try to answer this from a different angle (some might have done it implicitly):

If we use the 'dot' notation, the resolution of the target for the method is done at compile time. If we use message passing, the resolution of the target is deferred to run-time execution. If the targets are resolved at compile time, the execution is faster, since resolving the targets at the run-time includes a few overheads. (Not that the time difference will matter much). Since we have defined the property in the interface of the object already, there is no point in differing the resolution of the target for a property to run-time and hence dot-notation is the notation that we should use for accessing property.

Jas
  • 77
  • 1
  • 2
  • Are you aware that in ObjectiveC selectors are in any case evaluated, resolved and invoked at runtime? Hence the dot-notation is a pure synonym for the old bracket style. There are no technical differences whatsoever. Your speed assumptions are plain wrong - try it, use Instruments and see yourself. – Till Apr 29 '12 at 11:59