Counting letter occurrence

Question

The program needs to count and display the number of times that the specified charector appears in the text file.

Currently turning up zero for the total. I'm not if I should be using a different loop, I've also tried using a 'for' loop.

// Hold user input and sum
String fileName;    // Holds the name of the file
String letter;      // Letter to search for in the file
int total = 0;      // Holds the total number of characters in the file


// Get the name of the file and character from the user
fileName = JOptionPane.showInputDialog("Please enter the name of a file:");
letter = JOptionPane.showInputDialog("Please enter a letter contained in the string");


// Open the file for reading
File file = new File(fileName);         
Scanner inputFile = new Scanner(file);  // Declare new scanner object for file reading


// Set accumulator to zero
int count = 0;

if (inputFile.nextLine().equalsIgnoreCase(letter)) {                                

    count++;          // add letter occurrence

    total += count;   // add the letter occurrence to the total
}

is each line only one letter long? – RNJ Feb 22 '13 at 09:47 — RNJ, Feb 22 '13 at 09:47
each line is a word, the .txt is a paragraph – Kyle Feb 22 '13 at 09:57 — Kyle, Feb 22 '13 at 09:57

score 5 · Accepted Answer · answered Feb 22 '13 at 09:52

    BufferedReader reader = new BufferedReader(new FileReader("somefile.txt"));
    int ch;
    char charToSearch='a';
    int counter=0;
    while((ch=reader.read()) != -1) {
        if(charToSearch == (char)ch) {
            counter++;
        }
    };
    reader.close();

    System.out.println(counter);

Is this of any help?

Jaydeep Rajput · Answer 2 · 2013-02-22T10:33:24.513

1

There is bug in your code.Correct code below-

   String fileName;    // Holds the name of the file
    String letter;      // Letter to search for in the file

    // Get the name of the file and character from the user
    fileName = "C:\\bin\\GWT.txt";
    letter = "X";


    // Open the file for reading
    File file = new File(fileName);         
    Scanner inputFile = new Scanner(file);  // Declare new scanner object for file reading


    // Set accumulator to zero
    int count = 0;
    while(inputFile.hasNext()) {
      if (inputFile.nextLine().toLowerCase().contains(letter.toLowercase())) { 
           count++;          // add letter occurrence
       }
    }
    System.out.println(count);

edited Feb 22 '13 at 10:33

answered Feb 22 '13 at 09:56

Jaydeep Rajput

3,605
17
35

This is also case sensitive – Kyle Feb 22 '13 at 10:14
blnr, Edited the code above for case insensitive check. You can also refer following - http://stackoverflow.com/questions/5054995/how-to-replace-case-insensitive-literal-substrings-in-java – Jaydeep Rajput Feb 22 '13 at 10:34

score 0 · Answer 3 · answered Feb 22 '13 at 09:50

0

This answer is assuming each line in your text file contains just one letter as your question suggests.

You need to wrap your if statement in a loop as currently you are only checking the first line of the file:

     while(inputFile.hasNext()) {
         if (inputFile.nextLine().equalsIgnoreCase(letter))    {                                

             count++;          // add letter occurrence

             total += count;   // add the letter occurrence to the total
         }
     }

Also you can replace:

count++;
total+= count;

with just

total++;

answered Feb 22 '13 at 09:50

cowls

24,013
8
48
78

Updated with the wrapped 'while' loop, still does not work, 0 occurrences of the letter – Kyle Feb 22 '13 at 09:54
Can you paste an example text file – cowls Feb 22 '13 at 09:57

score 0 · Answer 4 · answered Feb 22 '13 at 09:55

0

String line=""
while(inputFile.hasNext()) {
  line = inputFile.nextLine();
  for(int i=0; i<line.length(); i++ ){
     if (line.charAt(i)== letter)                                    
         count++;          

 }
}

answered Feb 22 '13 at 09:55

Achintya Jha

12,735
2
27
39

Counting letter occurrence

4 Answers4

Linked