Javascript splitting by commas

Question

i am relatively new to stackoverflow and have searched for some time for an answer to my question. I found some links like this one How to split a comma-separated string? but still can't quite understand what I am doing wrong with my short little javascript program.

Anyway here it is. Help would be appreciated.

I basically am trying to create a prompt that asks the user to input 3 numbers seperated by commas, then change that string into an array so that I can multiply the values later on. So far, when i try to console.log this my results are as follows : 1,2 It doesn't print out the third digit(3rd number entered by the user).

var entry = prompt("Triangle side lengths in cm (number,number,number):")
if(entry!=null && entry!="") {
entryArray = entry.split(",");


for (i=0; i<3; i++)
{
entryArray[i] = entry.charAt([i]);
}
}
console.log(entryArray[0] + entryArray[1] + entryArray[2]);

Why is that for loop even required ?? the split itself will give you an array with 1 2 and 3. — mohkhan, Jul 10 '13 at 06:24

score 1 · Answer 1 · answered Jul 10 '13 at 06:25

Split creates an array already. So, if you enter 1,2,3, you get an array like this when you split it: ["1", "2", "3"]. In your for loop, you are getting the characters from the original input, not your array. In order to add them, you need to change the input to numbers since they are considered strings. So your for loop should look like this:

for (i=0; i<3; i++)
{
    entryArray[i] = parseFloat(entryArray[i]);
}

overwriting the strings with the digits.

score 0 · Answer 2 · answered Jul 10 '13 at 06:24

0

Try

for (i=0; i<3; i++)
{
    entryArray.push(parseInt(entryArray[i]);
}

answered Jul 10 '13 at 06:24

Harsha Venkataramu

2,887
1
34
58

Yup what you suggested works perfectly it seems. Thank you very much. I never thought of using parseInt – mike Jul 10 '13 at 06:26
My Bad , missed it.Sorry! :) – Harsha Venkataramu Jul 10 '13 at 06:28

score 0 · Answer 3 · edited Jul 10 '13 at 06:33

0

try this code, i removed your looping which was overwriting the array.

var entry = prompt("Triangle side lengths in cm (number,number,number):");
if(entry!=null && entry!="") {
    entryArray = entry.split(",");
    console.log(entryArray[0] + entryArray[1] + entryArray[2]);
    }

edited Jul 10 '13 at 06:33

NREZ

942
9
13

answered Jul 10 '13 at 06:27

DevZer0

13,433
7
27
51

score 0 · Answer 4 · answered Jul 10 '13 at 06:28

You can remove the body of the for。like this:

var entry = prompt("Triangle side lengths in cm (number,number,number):")
console.log(entry);
if(entry!=null && entry!="") {
entryArray = entry.split(",");
console.log(entryArray);
}

console.log(entryArray[0] + entryArray[1] + entryArray[2]);

Javascript splitting by commas

4 Answers4

Linked