Non-static method ..... should not be called statically

Question

I have recently done an update to PHP 5.4, and I get an error about static and non-static code.

This is the error:

PHP Strict Standards:  Non-static method VTimer::get() 
should not be called statically in /home/jaco/public_html/include/function_smarty.php on line 371

This is the line 371:

$timer  = VTimer::get($options['magic']);

I hope somebody can help.

score 139 · Accepted Answer · edited Jul 27 '22 at 17:50

139

That means it should be called like:

$timer = (new VTimer)->get($options['magic']);

The difference between static and non-static is that the first one doesn't need instantiation so you can call the classname then append :: to it and call the method immediately. Like so:

ClassName::method();

and if the method is not static you need to initialize it like so:

$var = new ClassName();
$var->method();

However, in PHP >=5.4 you can use this syntax instead as a shorthand:

(new ClassName)->method();

edited Jul 27 '22 at 17:50

ESP32

8,089
2
40
61

answered Oct 30 '13 at 21:23

mamdouh alramadan

8,349
6
36
53

3

Or perhaps he should change the method to be static (since this is an existing codebase now being run in an upgraded PHP environment). – webbiedave Oct 30 '13 at 21:30
@mamdouh You are great, the error is gone. Thank you for your help. Have a nice evening. sincerely, Jaco – Novice Hobby PHP Boy Oct 30 '13 at 21:34
@user2938848 - you are welcome. I hope you mark the answer as accepted, as it works with you :) – mamdouh alramadan Oct 30 '13 at 21:48
By faster calling : (new ClassName)->method(); you mean shorthand. Right? – Piyush Balapure Apr 17 '15 at 04:28
Im sure that syntax is the intention. – blackmambo Oct 23 '15 at 16:51

score 22 · Answer 2 · answered Jun 21 '16 at 04:42

22

You can also change the method to be static like so:

class Handler {
    public static function helloWorld() {
        echo "Hello world!";
    }
}

answered Jun 21 '16 at 04:42

deadghost

5,017
3
34
46

score 8 · Answer 3 · answered May 01 '20 at 11:53

The most elegant way would be :

(new ClassName)->method();

You can also convert your function to static function call() {}, but that depends on your function and what you're doing with it.

If you need to instantiate a class then avoid doing so, treat static functions like constants, they can not have objects and require predefined variables.

score 2 · Answer 4 · answered Jun 03 '22 at 11:51

2

public function functionName($variable)

Change to

public static function functionName($variable)

answered Jun 03 '22 at 11:51

Shehan Jayalath

447
3
13

Non-static method ..... should not be called statically

4 Answers4

Linked

Related