if statement in python not working with or and integers

Question

I'm having a problem with an if statement which has an or in it as well. I am essentially trying to have it so that if either of the player's score is 50, the game ends. I'm trying to have my code saying something like this:

if ball.score2 or ball.score1 == 50: 
    EndGame()

However, when I have this, as soon as the thing which ups ball.score2 (but this only happens for whichever one is first in the if statement, so here it does not do it if ball.score1 is upped) happens, and it is meant to be upped by 5, it runs the EndGame(). They work individually, so if I have:

if ball.score2 == 50:
     EndGame()

It will end the game when ball.score2 gets to 50, but not when I use them both like in the first example. Could someone help?

Yeah your right that one solves the problem - sorry, didn't see it when i looked — , Apr 01 '14 at 20:02

score 2 · Accepted Answer · answered Apr 01 '14 at 19:56

2

You need to check the equality of each scores:

if ball.score2 == 50 or ball.score == 50:
    EndGame()

answered Apr 01 '14 at 19:56

Chris Arena

1,602
15
17

it might also be good to recommend adding parenthesis for additional clarity. – Bryan Oakley Apr 01 '14 at 20:01
I always wondered if it's possible to do something about it so I wouldn't need to check everything separately and without writing a function with *args for example ? – Granitas Apr 01 '14 at 20:03
1

@Granitas: `if 50 in [ball.score2, ball.score]`. See the marked duplicate question for more info. – Colin DeClue Apr 01 '14 at 20:27
oh it's so obvious... how about if we would replace or with and? – Granitas Apr 01 '14 at 20:38
For and: `if len(set([ball.score2, ball.score1, 50])) <= 1` ... but it's not as clear or intuitive. – Chris Arena Apr 01 '14 at 21:28

if statement in python not working with or and integers

1 Answers1