layout_margin in CardView is not working properly

Question

I am playing with the new CardView, but the margins don't seem to be applying.

<?xml version="1.0" encoding="utf-8"?>

<android.support.v7.widget.CardView
xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:card_view="http://schemas.android.com/apk/res-auto"
android:id="@+id/card_view"
android:layout_gravity="center"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_marginTop="18dp"
android:layout_marginLeft="18dp"
android:layout_marginRight="18dp"
card_view:cardCornerRadius="4dp"
card_view:cardBackgroundColor="#FFA"
card_view:layout_margind="4dp">

<LinearLayout
    android:layout_width="match_parent"
    android:layout_height="wrap_content"
    android:orientation="vertical">

<TextView
    android:id="@+id/info_text"
    android:layout_width="wrap_content"
    android:layout_height="wrap_content"
    android:text="Hello World!"/>

<TextView
    android:layout_width="wrap_content"
    android:layout_height="wrap_content"
    android:text="Hello World!"/>

<TextView
    android:layout_width="wrap_content"
    android:layout_height="wrap_content"
    android:text="Hello World!"/>

<TextView
    android:layout_width="wrap_content"
    android:layout_height="wrap_content"
    android:text="Hello World!"/>

<TextView
    android:layout_width="wrap_content"
    android:layout_height="wrap_content"
    android:text="Hello World!"/>

</LinearLayout>

</android.support.v7.widget.CardView>

By the way, I'm using it in a Fragment that is in a ViewPager. The card extends the entire width of the screen (match_parent) even though I am using android:layout_marginLeft="18dp" and android:layout_marginRight="18dp" on the CardView.

Any ideas what I might be doing wrong?

score 37 · Answer 1 · edited Oct 08 '15 at 00:55

37

If you use RecyclerView to add CardView, android:layout_margin should be sufficient.

But using ListView to add CardView, you might do this:

<FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools"
android:layout_width="match_parent"
android:layout_height="wrap_content" >

<android.support.v7.widget.CardView
    xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:tools="http://schemas.android.com/tools"
    android:layout_width="match_parent"
    android:layout_height="wrap_content"
    android:layout_marginLeft="11dp"
    android:layout_marginRight="11dp"
    android:layout_marginTop="11dp">
       (other layout ...)
</android.support.v7.widget.CardView>

</FrameLayout>

But it is usually not the optimal one.

edited Oct 08 '15 at 00:55

pumpkinpie65

960
2
14
16

answered Aug 29 '14 at 03:52

zonda

850
7
14

2

Seems like an ugly hack but worked for me. Will do this until I convert to `RecylerView`. – TheLettuceMaster Nov 22 '14 at 22:18
3

AbsListView.LayoutParams does not extend ViewGroup.MarginLayoutParams. http://developer.android.com/reference/android/widget/AbsListView.LayoutParams.html Thus, margins will not work for immediate child Views. RecyclerView.LayoutParams does extend MLP, though, thankfully. – Eric Cochran May 30 '15 at 08:21

score 27 · Answer 2 · edited May 23 '17 at 12:09

27

I had the same issues before, I found answer in here... CardView layout_width="match_parent" does not match parent RecyclerView width

At the time of inflating the CardView xml inside your ViewPager, pass the ViewGroup in it. this will allow inflater to know which layout parameters to refer.

To inflate the layout file use something like below:

View v = LayoutInflater.from(viewGroup.getContext()).inflate(R.layout.view_list_item, viewGroup,false);

Hope that helps

edited May 23 '17 at 12:09

Community

1
1

answered Jul 08 '14 at 06:02

Nixit Patel

4,435
5
30
57

Where would I use that code? I am using a FragmentStatePagerAdapter. – Eric Cochran Jul 08 '14 at 15:47
at the time you are inflating view, either in fragment or adapter. – Nixit Patel Jul 08 '14 at 22:33
1

Perfect, thanks! Never saw this in any RecyclerView/CardView tutorials. – josh2112 Sep 17 '15 at 14:53

score 7 · Accepted Answer · answered Feb 28 '15 at 09:59

7

ViewPager.LayoutParams does not extend ViewGroup.MarginLayoutParams

It's that simple.

http://developer.android.com/reference/android/support/v4/view/ViewPager.LayoutParams.html

answered Feb 28 '15 at 09:59

Eric Cochran

8,414
5
50
91

score 2 · Answer 4 · answered Aug 04 '19 at 10:23

You need to put your card view inside a layout in order to properly show margins, especially if the card view is shown as an item in a recycler view.

<LinearLayout
    android:layout_height="wrap_content"
    android:layout_width="match_parent"
    xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:card_view="http://schemas.android.com/apk/res-auto">

<androidx.cardview.widget.CardView
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        card_view:cardBackgroundColor="@android:color/white"
        card_view:cardElevation="2dp"
        android:layout_marginBottom="25dp"/>
</LinearLayout>

This is not efficient, but it gets the work done. This should not have been downvoted! — Koushik Shom Choudhury, Mar 18 '20 at 05:11
yes worked for me as well & my cardview is not under any list of recyclerview — Nadimuddin, Oct 08 '20 at 16:11

score -1 · Answer 5 · answered May 23 '18 at 18:54

-1

Set app:cardPreventCornerOverlap property to false in cardView <android.support.v7.widget.CardView ... app:cardPreventCornerOverlap="false" ...

answered May 23 '18 at 18:54

Jorge Arindia

9
1

there is no such attribute – Shailendra Madda Mar 09 '22 at 14:20

layout_margin in CardView is not working properly

5 Answers5