241

I am trying to dismiss a ViewController in swift by calling dismissViewController in an IBAction

  @IBAction func cancel(sender: AnyObject) {
    self.dismissViewControllerAnimated(false, completion: nil)
    println("cancel")
}

@IBAction func done(sender: AnyObject) {
    self.dismissViewControllerAnimated(false, completion: nil)
    println("done")
}

random image of a segue

I could see the println message in console output but ViewController never gets dismissed. What could be the problem?

Naresh
  • 16,698
  • 6
  • 112
  • 113
rshankar
  • 3,045
  • 2
  • 18
  • 19

20 Answers20

458

From you image it seems like you presented the ViewController using push

The dismissViewControllerAnimated is used to close ViewControllers that presented using modal

Swift 2

navigationController.popViewControllerAnimated(true)

Swift 4

navigationController?.popViewController(animated: true)

dismiss(animated: true, completion: nil)
Cal
  • 422
  • 6
  • 20
Zoon Nooz
  • 5,836
  • 2
  • 22
  • 16
193

I have a solution for your problem. Please try this code to dismiss the view controller if you present the view using modal:

Swift 3:

self.dismiss(animated: true, completion: nil)

OR

If you present the view using "push" segue

self.navigationController?.popViewController(animated: true)
satheesh
  • 2,770
  • 2
  • 14
  • 19
21

if you do this i guess you might not get println message in console,

@IBAction func cancel(sender: AnyObject) {
  if(self.presentingViewController){
    self.dismissViewControllerAnimated(false, completion: nil)
    println("cancel")
   }
}

@IBAction func done(sender: AnyObject) {
  if(self.presentingViewController){
    self.dismissViewControllerAnimated(false, completion: nil)
    println("done")
  }    
}
BaSha
  • 2,356
  • 3
  • 21
  • 38
  • 1
    http://stackoverflow.com/questions/30840235/cant-dismiss-my-previous-alertcontroller-completely. Any Help,please?I am stuck at that for so long who still cant find solution – Thiha Aung Jun 16 '15 at 08:17
19

In Swift 3.0 to 4.0 it's as easy as typing this into your function:

self.dismiss(animated: true, completion: nil)

Or if you're in a navigation controller you can "pop" it:

self.navigationController?.popViewController(animated: true)
Chase McElroy
  • 383
  • 3
  • 8
  • dismiss not working, because I'm using pushViewController. Only self.navigationController?.popViewController(animated: true) working. – Naresh Jul 17 '18 at 09:48
15
  1. embed the View you want to dismiss in a NavigationController
  2. add a BarButton with "Done" as Identifier
  3. invoke the Assistant Editor with the Done button selected
  4. create an IBAction for this button
  5. add this line into the brackets:

    self.dismissViewControllerAnimated(true, completion: nil)
    
Bob Gilmore
  • 12,608
  • 13
  • 46
  • 53
LAOMUSIC ARTS
  • 642
  • 2
  • 10
  • 15
15

Use:

self.dismiss(animated: true, completion: nil)

instead of:

self.navigationController.dismissViewControllerAnimated(true, completion: nil)
Cal
  • 422
  • 6
  • 20
jobima
  • 5,790
  • 1
  • 20
  • 18
12

From Apple documentations:

The presenting view controller is responsible for dismissing the view controller it presented

Thus, it is a bad practise to just invoke the dismiss method from it self.

What you should do if you're presenting it modal is:

presentingViewController?.dismiss(animated: true, completion: nil)
OhadM
  • 4,687
  • 1
  • 47
  • 57
11

If you presenting a controller without a Navigation Controller, you can call the following code from a method of the presented controller.

self.presentingViewController?.dismiss(animated: true, completion: nil)

If your ViewController is presented modally, optional presentingViewController will be not nil and the code will be executed.

Peyotle
  • 2,255
  • 1
  • 15
  • 16
7

Based on my experience, I add a method to dismiss me as extension to UIViewController:

extension UIViewController {
    func dismissMe(animated: Bool, completion: (()->())?) {
        var count = 0
        if let c = self.navigationController?.viewControllers.count {
            count = c
        }
        if count > 1 {
            self.navigationController?.popViewController(animated: animated)
            if let handler = completion {
                handler()
            }
        } else {
            dismiss(animated: animated, completion: completion)
        }
    }
}

Then I call this method to dismiss view controller in any UIViewController subclass. For example, in cancel action:

class MyViewController: UIViewController {
   ...
   @IBAction func cancel(sender: AnyObject) {
     dismissMe(animated: true, completion: nil)
   }
   ...
}
Guy Daher
  • 5,526
  • 5
  • 42
  • 67
David.Chu.ca
  • 37,408
  • 63
  • 148
  • 190
6

So if you wanna dismiss your Viewcontroller use this. This code is written in button action to dismiss VC

  @IBAction func cancel(sender: AnyObject) {
   dismiss(animated: true, completion: nil)
  }
Sai kumar Reddy
  • 1,751
  • 20
  • 23
  • 1
    While this code snippet may solve the question, [including an explanation](http://meta.stackexchange.com/questions/114762/explaining-entirely-code-based-answers) really helps to improve the quality of your post. Remember that you are answering the question for readers in the future, and those people might not know the reasons for your code suggestion. – DimaSan Mar 25 '17 at 21:52
6

Since you used push presented viewController, therefore, you can use

self.dismiss(animated: false, completion: nil)
Ionic
  • 71
  • 1
  • 4
5

Don't create any segue from Cancel or Done to other VC and only write this code your buttons @IBAction

@IBAction func cancel(sender: AnyObject) {
    dismiss(animated: false, completion: nil)
}
Fatih
  • 51
  • 1
  • 3
4

Here is the one way to dismiss present view controller and move back to previous view controller. You can do this through Storyboard only.

  1. Open Storyboard
  2. Right click on Cancel button and drag it to previous view controller, where you want to move back to previous controller
  3. Now release the right click and you can see some actions which performs on cancel button
  4. Now choose "popover present" option from list
  5. Now you can dismiss your current view by click on cancel button

Please try this, It's working with me.

Second Way - Use - navigationController.popViewControllerAnimated(true)

Best luck..

Chetan Bhalara
  • 10,326
  • 6
  • 32
  • 51
  • http://stackoverflow.com/questions/30840235/cant-dismiss-my-previous-alertcontroller-completely. Any Help,please?I am stuck at that for so long who still cant find solution – Thiha Aung Jun 16 '15 at 08:17
  • 3
    This is wrong. You are never dismissing the view you are instead presenting a new view controller on top of the current one, causing a memory leak. This will most likely get your app rejected from the app store. – 3366784 May 08 '17 at 06:45
4

If you using the present method in the parent VC then you should call this function, to dismiss the child VC use this

self.dismiss(animated: true, completion: nil)

if you calling child VC by using push method, to dismiss the child VC use this

self.navigationController?.popViewController(animated: true)
3

For reference, be aware that you might be dismissing the wrong view controller. For example, if you have an alert box or modal showing on top of another modal. (You could have a Twitter post alert showing on top of your current modal alert, for example). In this case, you need to call dismiss twice, or use an unwind segue.

mcfroob
  • 1,044
  • 1
  • 11
  • 13
3

Try this:

@IBAction func close() {
  dismiss(animated: true, completion: nil)
}
Derek Pollard
  • 6,953
  • 6
  • 39
  • 59
  • The method called "dismissViewController" it only takes a single parameter, which I suppose would look like to dismiss animated to previous view, this is the simplest solution. –  Apr 05 '19 at 15:12
2

If you are presenting a ViewController modally, and want to go back to the root ViewController, take care to dismiss this modally presented ViewController before you go back to the root ViewController otherwise this ViewController will not be removed from Memory and cause Memory leaks.

Crashalot
  • 33,605
  • 61
  • 269
  • 439
dan
  • 873
  • 8
  • 11
2

In Swift 3.0

If you want to dismiss a presented view controller

self.dismiss(animated: true, completion: nil)
Ramakrishna
  • 712
  • 8
  • 26
2

In Swift 4.1 and Xcode 9.4.1

If you use pushViewController to present new view controller, use this

self.navigationController?.popViewController(animated: false)
Naresh
  • 16,698
  • 6
  • 112
  • 113
2
@IBAction func back(_ sender: Any) {
        self.dismiss(animated: false, completion: nil)
    }
eng mohamed emam
  • 549
  • 6
  • 13