How to pass List through activities

Question

ArrayList<Item> arrayOfList;

I want to pass arrayOfList; to next activity on Itemclick of listview

Tried Things

    Intent sec = new Intent(this, IndividualPage.class);
    Bundle b = new Bundle();
    b.putParcelableArrayList("mylist", arrayOfList);
    sec.putExtras(b);

To retrieve the arraylist

        Bundle b = this.getIntent().getExtras();
        ArrayList<Item> cats = b.getParcelableArrayList("mylist");
        System.out.println(cats);

But i am getting null in console.

Is there any other efficient way to pass the data.

Item.java

public class Item implements Parcelable {

private String Name;
private String Location;
private String Image;
private String Sector;
private int Founded;
private String Status;
private int RowVAls;



public String getName() {
    return Name;
}

public void setName(String Name) {
    this.Name = Name;
}

public String getLocation() {
    return Location;
}

public void setLocation(String Location) {
    this.Location = Location;
}

public String getImage() {
    //return "http://23.253.164.20:8099/"+Image;
    return "http://23.253.164.20:8099/"+Image;
}

public void setImage(String Image) {
    this.Image = Image;
}

public String getSector() {
    return Sector;
}

public void setSector(String Sector) {
    this.Sector = Sector;
}

public int getFounded() {
    return Founded;
}

public void setFounded(int Founded) {
    this.Founded = Founded;
}

public String getStatus() {
    return Status;
}

public void setStatus(String Status) {
    this.Status = Status;
}

public int getRowVAls() {
    return RowVAls;
}

public void setRowVAls(int RowVAls) {
    this.RowVAls = RowVAls;
}

protected Item(Parcel in) {
        Name = in.readString();
        Location = in.readString();
        Image = in.readString();
        Sector = in.readString();
        Founded = in.readInt();
        Status = in.readString();
        RowVAls = in.readInt();
    }

    @SuppressWarnings("unused")
    public static final Parcelable.Creator<Item> CREATOR = new Parcelable.Creator<Item>() {
        @Override
        public Item createFromParcel(Parcel in) {
            return new Item(in);
        }

        @Override
        public Item[] newArray(int size) {
            return new Item[size];
        }
    };


@Override
public int describeContents() {
    return 0;
}

@Override
public void writeToParcel(Parcel dest, int flags) {
    dest.writeString(Name);
    dest.writeString(Location);
    dest.writeString(Image);
    dest.writeString(Sector);
    dest.writeInt(Founded);
    dest.writeString(Status);
    dest.writeInt(RowVAls);
}

Note:- Item is neither Parcelable nor Serializable . And i would not like to make any changes in that.

Getting null even after i have implemented the ITEM as Parcelable — Vaibs_Cool, Jul 22 '15 at 08:02

score 2 · Accepted Answer · answered Jul 22 '15 at 07:46

2

You should make your Item implement Parcelable. Try this site to make your Item Parcelable

answered Jul 22 '15 at 07:46

Renjith

3,274
19
39

I have made item parcelable – Vaibs_Cool Jul 22 '15 at 07:51
Still are you getting null? – Renjith Jul 22 '15 at 07:52
Yes .. I am getting null – Vaibs_Cool Jul 22 '15 at 08:02
Try setting a normal string and check whether you are able to retrieve that – Renjith Jul 22 '15 at 08:27
I had tried by dummy data ArrayList which i am getting at the next activity – Vaibs_Cool Jul 22 '15 at 09:26
Try cleaning and rebuilding your project once and also make sure that arrayOfList is not null while adding to bundle. Also try directly setting the list in intent intent.putParcelableArrayListExtra("list",arrayList); intent.getParcelableArrayExtra("list") – Renjith Jul 22 '15 at 09:30
Let us [continue this discussion in chat](http://chat.stackoverflow.com/rooms/83953/discussion-between-renjith-and-vaibs-cool). – Renjith Jul 22 '15 at 09:35

score 1 · Answer 2 · answered Jul 22 '15 at 07:46

1

Item is neither Parcelable nor Serializable . And i would not like to make any changes in that.

then you can't. I would strongly recommend you to look into the Parcelable interface, avoiding tricks like making the field public static

answered Jul 22 '15 at 07:46

Blackbelt

156,034
29
297
305

now i have implemented the ITEM as parcelable but still i am getting `null` – Vaibs_Cool Jul 22 '15 at 08:08

score 0 · Answer 3 · answered Jul 22 '15 at 07:53

As others have said, you can't do it properly without implementing parcelable - which sometimes isn't possible.

You're only other option is to architect a way in which you can put your list in a static context so it's accessible from wherever.

You could create a singleton SparseArray and related integer, and pass around the integer between activities describing the position in the SparseArray. You'd just have to ensure that you incremented your integer and removed the item from the SparseArray once you'd grabbed it. Off the top of my head -

private class ComplexObjectPassing {
    private static SparseArray<Object> sArray = new SparseArray<Object>();
    private static int count = 0;

    public static int putObject(Object obj) {
        count++;
        sArray.put(count, obj);
    }

    public static Object getObject(int index) {
        Object obj = sArray.get(index);
        sArray.put(index, null);
        return obj;
    }
}

Obviously, this would end with a huge memory leak when you passed things and they weren't pulled out by the new activity. All of the alternatives are going to have downsides and need to be carefully managed to reduce inevitable problems.

How to pass List through activities

3 Answers3