Sharing Variables between classes in Java

Question

I have to create a maze game in my class. I've created the maze, but I need to share the variables from the main class to the other classes (it is a requirement).

Here is my main code:

import java.io.*;
import java.util.Scanner;

public class MazeGame 
{


    public static void main(String[] args) 
    {
        getVariables();  
    }

    static void getVariables()
    {
        String fileName = "C:\\Users\\baileyjstewart\\Documents\\NetBeansProjects\\MazeGame\\src\\Maze.input";
        int size;
        int row;
        int column;
        String line = null;

        try {
            // FileReader reads text files in the default encoding.
            FileReader fileReader = new FileReader(fileName);

            // Always wrap FileReader in BufferedReader.
            BufferedReader bufferedReader = new BufferedReader(fileReader);

            Scanner s = new Scanner(new File("C:\\Users\\baileyjstewart\\Documents\\NetBeansProjects\\MazeGame\\src\\Maze.input"));

            int[][] array = new int[size = s.nextInt()][size];
            for (row = 0; row < size; row++)
                {
                   for(column = 0; column < size; column++)
                   {
                       array[row][column] = s.nextInt();
                       if(array[row][column] == 0)
                       {
                           System.out.print("  ");
                           //System.out.print(array [row][column] + " ");
                       }
                       else if(array[row][column] == 1)
                       {
                           System.out.print("X "); 
                       }
                       else if(array[row][column] == 2)
                       {
                           System.out.print("E ");
                       }
                   }   
                   System.out.println(" ");
                }

            // Always close files.
            bufferedReader.close();         
        }
        catch(FileNotFoundException ex) {
            System.out.println(
                "Unable to open file '" + 
                fileName + "'");                
        }
        catch(IOException ex) {
            System.out.println(
                "Error reading file '");

        }

    }
}

And I'm trying to share the variables row, column, and size into my Location class:

import java.io.*;
import java.util.Scanner;

public class Location 
{

    MazeGame Location = new MazeGame();


    public Location()
    {
        String Wall;
        String Space;
        String Endpoint;
        Boolean Visited;
        Boolean hereNow;   
    }

    public void getVariables()
    {
        Location.getVariables();
        if(row == 0)
        {

        }

    }



}

Thank you in advance for any help.

You should really rename your mazeGame instance in `Location`, and should follow naming standards. For your problem, one solution is to "promote" `row`, `column` and `size` to class fields, and add getters to `MazeGame` (then you can use those getters in `Location`) — , Sep 22 '15 at 15:47
You need to read a tutorial on basic object-oriented principles — tnw, Sep 22 '15 at 15:47
`MazeGame Location = new MazeGame();` variable name cannot be the same as class name — sam, Sep 22 '15 at 15:47
possible duplicate of [Access variables from another method](http://stackoverflow.com/questions/12123979/access-variables-from-another-method) — Fernando Matsumoto, Sep 22 '15 at 16:03

score 0 · Answer 1 · edited May 23 '17 at 12:29

public class Location 
{

MazeGame Location = new MazeGame();
....

This wont work because the class name is exactly the same as the variable name.

Also, your Location class is never used because the program entry point ( main function ) is declared in the MazeGame class.

I wrote another answer elsewhere that goes into explaining constructors, classes, and setters/getters that you may want to read.

Let me know if you need more examples or if you still don't understand.

PNB · Answer 2 · 2015-09-24T14:32:57.660

As others have pointed out, the class name 'Location' is same as the variable (object) name. You need to read about OOP rules and principles.

One way you to share variables across classes will be to declare the variable as 'static'. Please remember that 'static' variables are not encouraged and they are considered as evil.

Still, if you would like to see how your code can share variables across classes, here is your code with some changes (though this is NOT perfect).

import java.io.BufferedReader;
import java.io.IOException;
import java.io.InputStreamReader;

public class MazeGame 
{

    protected static int row;

    public static void main(String[] args) throws IOException 
    {
        getVariables();  
    }

    public int getRow() {
        return MazeGame.row;
    }

    static void getVariables() throws IOException
    {
        InputStreamReader isr = new InputStreamReader(System.in);
        BufferedReader br = new BufferedReader(isr);
        System.out.println("Enter a value for row : ");
        String strRow = br.readLine();
        MazeGame.row = Integer.parseInt(strRow);

        Location ln = new Location();
        ln.getVariables();
    }
}


import java.io.IOException;

public class Location 
{

     MazeGame Locationx = new MazeGame();

    public Location()
    {

    }

    public void getVariables() throws IOException
    {
         System.out.println("The value of class variable row, initially is: "+MazeGame.row); // class variable

         Locationx.row = 21; // object variable
         System.out.println("The value of object variable row, after modification is: "+Locationx.row);

         MazeGame.row = 23; // class variable
         System.out.println("The value of class variable row, after modification is: "+MazeGame.row);
     }
}

Sharing Variables between classes in Java

2 Answers2