TextInputLayout.setError() leaves empty space after clearing the error

Question

I recently used TextInputLayout and it's setError() method. The problem I'm getting is, when I clear the error by calling setError(null) it leaves so much of empty space at the bottom.

Normal:

With error:

After clearing error:

After looking at the source, I found that they are making the view INVISIBLE instead of GONE

.setListener(new ViewPropertyAnimatorListenerAdapter() {
@Override
public void onAnimationEnd(View view) {
    view.setVisibility(INVISIBLE); // here it is

    updateLabelVisibility(true);
} }).start();

I'm wondering why is it so? How to resolve this to avoid the empty space?

Actually are you giving your own animation for it? – Sharath Dec 12 '15 at 18:04 — Sharath, Dec 12 '15 at 18:04

score 167 · Accepted Answer · edited Oct 03 '16 at 18:14

167

Check out the docs for

public void setErrorEnabled (boolean enabled)

It says

Whether the error functionality is enabled or not in this layout. Enabling this functionality before setting an error message via setError(CharSequence), will mean that this layout will not change size when an error is displayed.

Well based on this, try setting setErrorEnabled(true) before setError(), and, set setErrorEnabled(false) after setError(null).

edited Oct 03 '16 at 18:14

Mangesh

5,491
5
48
71

answered Dec 12 '15 at 17:57

harshitpthk

4,058
2
24
32

2

You are right. Thanks for pointing this out. But still it occupies a lot of space and also it is not predictable while previewing the layout. I still don't understand why they made it so. – Mangesh Dec 12 '15 at 18:17
well not really sure why they implemented this way, yes having View.GONE would be better to save space but could have created problems for some complex view groups if they were underneath TextInputLayout and they would have to shift down. – harshitpthk Dec 12 '15 at 18:23
1

on seterror it expands. but setting error to null or settingErrorEnabled to false does not collapse back the layout. – Sagar Nayak Feb 15 '18 at 18:53
2

setError calls setErrorEnabled(true) internally – Florian Walther Mar 24 '18 at 12:56
Excelent! I created two extension functions for this: fun TextInputLayout.showError(errorText: String) { this.isErrorEnabled = true this.error = errorText } fun TextInputLayout.removeError() { this.isErrorEnabled = false this.error = null } – Jose Flavio Quispe Irrazábal Jan 26 '20 at 18:39

score 55 · Answer 2 · edited Oct 03 '16 at 15:44

55

Method setErrorEnabled(false) will clear the extra space, so call it after setError(null).

edited Oct 03 '16 at 15:44

Mangesh

5,491
5
48
71

answered Jan 22 '16 at 21:47

Mike Margulies

551
3
5

This response gives me the result I was expecting. Thanks. – Laranjeiro Apr 04 '16 at 10:03
Thanks. Exactly what I needed! – ice_chrysler Jul 06 '18 at 11:26
Why do we need `setError(null)`? – Sam Chen Feb 18 '20 at 13:52

score 6 · Answer 3 · answered Jul 02 '16 at 15:18

Dont use setErrorEnabled(boolean), it just doesnt show up the error from the second time.

public class MyTextInputLayout extends android.support.design.widget.TextInputLayout {

public MyTextInputLayout(Context context) {
    super(context);
}

public MyTextInputLayout(Context context, AttributeSet attrs) {
    super(context, attrs);
}

public MyTextInputLayout(Context context, AttributeSet attrs, int defStyleAttr) {
    super(context, attrs, defStyleAttr);
}

@Override
public void setError(@Nullable CharSequence error) {
    super.setError(error);

    View layout = getChildAt(1);
    if (layout != null) {
        if (error != null && !"".equals(error.toString().trim())) {
            layout.setVisibility(VISIBLE);
        } else {
            layout.setVisibility(GONE);
        }
    }
}
}

Then just setError(errorMessage); or setError(null);

Works fine, but it promptly deletes the text. Is there a way to animate it? — Andrew, Feb 24 '21 at 07:38

score 4 · Answer 4 · edited Oct 03 '16 at 15:23

See this page. Google will release the fix in future support library version. It says,

If you want to fix it now you can extends the TextInputLayout and override the setErrorEnabled() method, but I cant guarantee the backward compatibility. Because its some danger to change state in TextInputLayout.

public class TextInputLayout extends android.support.design.widget.TextInputLayout{


    public TextInputLayout(Context context) {
        super(context);
    }

    public TextInputLayout(Context context, AttributeSet attrs) {
        super(context, attrs);
    }

    public TextInputLayout(Context context, AttributeSet attrs, int defStyleAttr) {
        super(context, attrs, defStyleAttr);
    }

    @Override
    public void setErrorEnabled(boolean enabled) {
        super.setErrorEnabled(enabled);
        if (enabled) {
            return;
        }
        if (getChildCount() > 1) {
            View view = getChildAt(1);
            if (view != null) {
                view.setVisibility(View.GONE);
            }
        }
    }
}

@HRaval the bug has fixed in support library v23.2.0, but I have not verify it — Shaode Lu, Feb 26 '16 at 03:44

score 4 · Answer 5 · answered Apr 16 '17 at 06:09

I create a custom view for avoiding repeated code and override setError method.

    public class UserInputView extends TextInputLayout {

        public UserInputView(Context context) {
           this(context, null);
        }

        public UserInputView(Context context, AttributeSet attrs) {
            this(context, attrs, 0);
        }

        public UserInputView(Context context, AttributeSet attrs, int defStyleAttr) {
            super(context, attrs, defStyleAttr);
        }

        @Override
        public void setError(@Nullable CharSequence error) {
            boolean isErrorEnabled = error != null;
            setErrorEnabled(isErrorEnabled);
            super.setError(error);
        }

     }

score 4 · Answer 6 · answered Mar 16 '18 at 14:51

The source code of TextInputLayout show the following: If you need to clear the error, just use

til.setErrorEnabled(false);

This will hide the error text and stretch the bottom space to its standard size.

In case you need to set the error again, just use

til.setError("Your text");

which automatically calls til.setErrorEnabled(true) as it assumes you need the error functionality.

score 3 · Answer 7 · answered Jun 30 '20 at 20:33

3

This is extension in kotlin solving problem:

fun TextInputLayout.clearError() {
    error = null
    isErrorEnabled = false
}

answered Jun 30 '20 at 20:33

Renetik

5,887
1
47
66

score 0 · Answer 8 · answered Jun 01 '16 at 11:08

The following code works fine

    textInputLatout.getEditText().addTextChangedListener(new TextWatcher() {
        @Override
        public void beforeTextChanged(CharSequence s, int start, int count, int after) {

        }

        @Override
        public void onTextChanged(CharSequence s, int start, int before, int count) {
            if (s.length() < 1) {
               textInputLayout.setErrorEnabled(true);
                textInputLayout.setError("Please enter a value");
            }

            if (s.length() > 0) {
                textInputLayout.setError(null);
                textInputLayout.setErrorEnabled(false);
            }

        }

        @Override
        public void afterTextChanged(Editable s) {

        }
    });

score 0 · Answer 9 · answered Feb 06 '17 at 08:22

0

By using mTextInputLayout.setErrorEnabled(false); i have solved this problem

answered Feb 06 '17 at 08:22

Rohit Sharma

167
2
14

superkytoz · Answer 10 · 2015-12-12T18:02:54.957

-3

Then you should override it like so:

@Override
public void onAnimationEnd(View view)
{
    view.setVisibility(GONE); // <-- this is where you make it GONE

    updateLabelVisibility(true); 
}

Or try this i.e. on a button or whatever you are using:

final Button btn = (Button) findViewById(R.id.btn);
btn.setVisibility(View.GONE); //<--- makes the button gone

edited Dec 12 '15 at 18:02

answered Dec 12 '15 at 17:52

superkytoz

1,267
4
23
43

1

Sorry but I'm not getting what are you saying. – Mangesh Dec 12 '15 at 18:04
A view can be anything like a button for example. – superkytoz Dec 12 '15 at 18:07

TextInputLayout.setError() leaves empty space after clearing the error

10 Answers10

Linked