Static Value Android Studio

Question

I have two Activities. And a static integer called as counter.

So if I press a button in activity 'A' then counter = counter + 1.

Here is the code from activity a:

public static int counter = 0;
cmdOk.setOnClickListener(new View.OnClickListener() {
        @Override
        public void onClick(View v) {
        counter = counter + 1;
        if (counter == 5)
        {
             tagihan.txtShip1.setTextColor(Color.parseColor("#000000"));
             tagihan.txtNilai1.setTextColor(Color.parseColor("#000000"));
             tagihan.txtSupir1.setTextColor(Color.parseColor("#000000"));
        }
}

And here it is from activity b :

cmdSuccess.setOnClickListener(new View.OnClickListener() {
        @Override
        public void onClick(View v) {
        a.counter = a.counter + 1;
        if (a.counter == 5)
        {
             tagihan.txtShip1.setTextColor(Color.parseColor("#000000"));
             tagihan.txtNilai1.setTextColor(Color.parseColor("#000000"));
             tagihan.txtSupir1.setTextColor(Color.parseColor("#000000"));
        }
}

My problem is when i tried to press a button from activity a 3 times it work perfectly. So the values are 3 now.

But when i tried press a button from activity b, the value is going restart into 0. Actually i didn't destroy activity a.

So what i want is the value is going continouosly even i press from activity a or b.

Any ideas ?

Edited :

I have edit the code. Tagihan activity is what im trying to accomplished. So when the counter is 5, then tagihan activity is changing.

Sharing static dynamic variables amongst activities is not preferred because you have little control over the Activity lifecycle. What is the problem you are trying to accomplish? — OneCricketeer, Feb 12 '16 at 04:05
how you passing activity a 's instance to b . can you please show? — KDeogharkar, Feb 12 '16 at 04:05
Why don't you store the counter in whatever this `tagihan` variable is? — OneCricketeer, Feb 12 '16 at 04:10
Is it going to be success ? the a and b activite is calling from tagihan activity variable. is it what you mean ? — Leonard Febrianto, Feb 12 '16 at 04:12
Possible duplicate of [What's the best way to share data between activities?](http://stackoverflow.com/questions/4878159/whats-the-best-way-to-share-data-between-activities) — OneCricketeer, Feb 12 '16 at 04:13
you can store it in sharedprefrence as well you can make it on application class also — Vishal Thakkar, Feb 12 '16 at 04:13
I don't know what `tagihan` is because it is not initialized in the code you've shown, but it looks to be the exact same object, so why not store it in an **instance** of that variable instead of a static variable? — OneCricketeer, Feb 12 '16 at 04:15

ΦXocę 웃 Пepeúpa ツ · Answer 1 · 2016-02-12T04:11:02.577

Dont use static data, this is a bad approach and is not a common OOP-way to develope, instead try passing data between activities...

Act1

Intent intent = new Intent(activity2.this, activity1.class);
intent.putExtra("message", message);
startActivity(intent);

Act2:

Bundle bundle = getIntent().getExtras();
String message = bundle.getString("message");

Android development web is giving an introduction to this: http://developer.android.com/training/basics/firstapp/starting-activity.html

score 1 · Answer 2 · answered Feb 12 '16 at 04:50

After your edit, I can see that you need a "global varfiable" that can be read/write for all the activities:

Solution: All activities are embedded in an Application, so if you habe fields/members in the application you can access to them with a stadard setter/getter

you need:

Define an application

public class MyApplication extends Application {

    private int counterVariable;

    public int counterVariable() {
        return this.counterVariable;
    }

    public void setCounterVariable(int someVariable) {
        this.counterVariable = someVariable;
    }
}

add the App to the manifest:

<application 
  android:name="MyApplication" 
  android:icon="@drawable/icon" 
  android:label="@string/app_name">

Then in your activities get and set the variable like so:

// cast to Application and call the setter
((MyApplication) this.getApplication()).counterVariable(1);

// cast to Application and call the getter
int counter = ((MyApplication) this.getApplication()).getCounterVariable ();

score 0 · Answer 3 · answered Feb 12 '16 at 04:54

Please use the below code:

// Generalized form of Avoiding the Static value holding:

public class SPDataHandler {


 private Context mContext;
 private SharedPreferences mPreference;
 public SPDataHandler(Context context) {
        this.mContext = context;
        this.mPreference = mContext.getSharedPreferences("SAMPLE_SP", Context.MODE_PRIVATE);
   }
    /**
     * COMMON SETTER FOR INTEGER DATA
     */
    private void setIntegerData(String key, int value) {
        SharedPreferences.Editor editor = mPreference.edit();
        editor.putInt(key, value);
        editor.commit();
    }
    /**
     * COMMON GETTER FOR INTEGER SP DATA
     */
    private int getIntegerSpData(String key, int defaultValue) {
        return this.mPreference.getInt(key, defaultValue);
    }


    // Your Getter and Setter

     public int getmCount() {
        return this.getIntegerSpData("Count", 1);
    }

    public void setmCount(int cont) {
        this.setIntegerData("Count", cont);
    }
}

// Your Activity A

SPDataHandler handler = new  SPDataHandler(this);
int count = handler.getmCount();
cmdOk.setOnClickListener(new View.OnClickListener() {
        @Override
        public void onClick(View v) {
        count = count + 1;
        handler.setmCount(count); // Change the logic based on your requirement
        if (count == 5)
        {
             tagihan.txtShip1.setTextColor(Color.parseColor("#000000"));
             tagihan.txtNilai1.setTextColor(Color.parseColor("#000000"));
             tagihan.txtSupir1.setTextColor(Color.parseColor("#000000"));
        }
}


// Your Activity B
SPDataHandler handler = new  SPDataHandler(this);
int count = handler.getmCount();
cmdSuccess.setOnClickListener(new View.OnClickListener() {
        @Override
        public void onClick(View v) {
       count = count + 1;
        handler.setmCount(count); // Change the logic based on your requirement
        if (count  == 5)
        {
             tagihan.txtShip1.setTextColor(Color.parseColor("#000000"));
             tagihan.txtNilai1.setTextColor(Color.parseColor("#000000"));
             tagihan.txtSupir1.setTextColor(Color.parseColor("#000000"));
        }
}

Static Value Android Studio

3 Answers3

Linked