23

I am using the constructor QWidget(QWidget *parent). This parent widget contains a lot of child widgets. I need to clear all the child widgets from the parent at runtime. How can I do this?

msrd0
  • 7,816
  • 9
  • 47
  • 82
saravanan
  • 1,605
  • 6
  • 20
  • 25
  • Answers to the question http://stackoverflow.com/questions/4272196/qt-remove-all-widgets-from-layout/18496300#18496300 may be relevant. – Alex S Aug 28 '13 at 19:15

5 Answers5

28

Previous answer is wrong!! You cannot use findChildren to delete a widget's children, because Qt4's findChildren recursively lists children. Therefore, you will delete children of children, which then may be deleted twice, potentially crashing your app.

More generally, in Qt, taking a list of QObject pointers and deleting them one by one is dangerous, as destroying an object may chain-destroy other objects, due to the parent ownership mechanism, or by connecting a destroyed() signal to a deleteLater() slot. Therefore, destroying the first objects in the list may invalidate the next ones.

You need to list children widgets either by:

  • Passing the Qt::FindDirectChildrenOnly flag to findChild if you are using Qt5 (which did not exist when the question was asked...)
  • Using QLayout functions for listing items,
  • Using QObject::children, and for each test if it is a widget using isWidgetType() or a cast
  • Using findChild() in a loop and delete the result until it returns a null pointer
Kuba hasn't forgotten Monica
  • 95,931
  • 16
  • 151
  • 313
galinette
  • 8,896
  • 2
  • 36
  • 87
24

To take care of the recursivity problem pointed out by @galinette you can just remove the widgets in a while loop

while ( QWidget* w = findChild<QWidget*>() )
    delete w;
Matthias Kuhn
  • 1,162
  • 2
  • 14
  • 42
  • 2
    This is the most suitable answer in my opinion – Michal Feb 18 '15 at 08:40
  • 1
    Have a look at https://stackoverflow.com/a/35802122/2319028 if you are using Qt5 (which you should nowadays), the answer is much more complete. But this code still works. – Matthias Kuhn Aug 06 '19 at 19:48
  • This still seems the best answer for Qt version 4. According to the documentation for QObject::findChild() (https://doc.qt.io/archives/qt-4.8/qobject.html#findChild), if more than one child [sic, but what they really mean is descendant] matches the search criteria, the *most direct* [emphasis mine] ancestor [sic, but what they really mean is descendant] is returned. Thus, a direct child widget is certain to be destroyed first, which in turn will recursively destroy more indirect descendant widgets under that. – Mike Finch Aug 06 '19 at 20:33
11

Summarizing and supplementing:

For Qt5 in one line:

qDeleteAll(parentWidget->findChildren<QWidget*>("", Qt::FindDirectChildrenOnly));

For Qt5 for a lot of children, using setUpdatesEnabled():

parentWidget->setUpdatesEnabled(false);
qDeleteAll(parentWidget->findChildren<QWidget*>("", Qt::FindDirectChildrenOnly));
parentWidget->setUpdatesEnabled(true);

Note that this is not exception safe! While Qt does not at this time appear to throw exceptions here, the signal destroyed() could be connected to code that does throw, or an overridden Object::childEvent(QChildEvent*) could throw.

Better would be to use a helper class:

class UpdatesEnabledHelper
{
    QWidget* m_parentWidget;
public:
    UpdatesEnabledHelper(QWidget* parentWidget) : m_parentWidget(parentWidget) { parentWidget->setUpdatesEnabled(false); }
    ~UpdatesEnabledHelper() { m_parentWidget->setUpdatesEnabled(true); }
};

...

UpdatesEnabledHelper helper(parentWidget);
qDeleteAll(parentWidget->findChildren<QWidget*>("", Qt::FindDirectChildrenOnly));

For Qt4:

QList<QWidget*> childWidgets = parentWidget->findChildren<QWidget*>();
foreach(QWidget* widget, childWidgets)
    if (widget->parentWidget() == parentWidget)
        delete widget;

Removing from the QLayout works in both Qt4 and Qt5:

QLayoutItem* child;
while (NULL != (child = layout->takeAt(0))) // or nullptr instead of NULL
    delete child;

QObjects (and therefore QWidgets) remove themselves (automagically) from their parent in their (QObject) destructor.

Edward LeBlanc
  • 309
  • 4
  • 10
6

From Qt docs

The following code fragment shows a safe way to remove all items from a layout:

QLayoutItem *child;
while ((child = layout->takeAt(0)) != 0) {
    ...
    delete child;
}
ManuelSchneid3r
  • 15,850
  • 12
  • 65
  • 103
-6

You can use the following in your parent widget class:

QList<QWidget *> widgets = findChildren<QWidget *>();
foreach(QWidget * widget, widgets)
{
    delete widget;
}
Yulia Rogovaya
  • 924
  • 1
  • 8
  • 26
  • 9
    There is also a function provided by Qt called qDeleteAll, which takes a container and deletes every item in the container. So you could simplify this to qDeleteAll(findChildren()); – Caleb Huitt - cjhuitt Oct 15 '10 at 18:23
  • 3
    if there are LOTS of children, you might also consider to setUpdatesEnabled(false); qDeleteAll(findChildren()); setUpdatesEnabled(true); – MadH Nov 26 '10 at 14:26
  • This answer is wrong, it works only if child widgets have no children themselves. Otherwise, grandchildren will be deleted twice. Because findChildren recursively lists all children, grandchildren, etc... – galinette Jul 17 '14 at 10:32