Is there anything wrong with this FragmentPagerAdapter approach?

Question

public class MyPagerAdapter extends FragmentPagerAdapter {

    private List<Fragment> fragmentList;
    /**
     * Use this method to add pages in order
     */
    private void initializeFragmentList() {
        fragmentList = new ArrayList<>();
        fragmentList.add(LocationCriteriaFragment.newInstance("FirstFragment", "Instance 1"));
        fragmentList.add(NeighborhoodRatingFragment.newInstance("", ""));
        fragmentList.add(PropertyCriteriaFragment.newInstance("", ""));
        fragmentList.add(ExteriorPhotoEnhancedFeaturesFragment.newInstance());
        fragmentList.add(InteriorPhotoEnhancedFeaturesFragment.newInstance());
    }
    public MyPagerAdapter(android.support.v4.app.FragmentManager fm) {
        super(fm);
        initializeFragmentList();
    }

    public List<Fragment> getFragmentList() {
        return fragmentList;
    }

    @Override
    public Fragment getItem(int pos) {
        return fragmentList.get(pos);
    }

    @Override
    public int getCount() {
        return fragmentList.size();
    }
}

I'm using this as an adapter for a ViewPager. Is this a good approach for getting fragment references easily based on positions? Will it give a huge unexpected crash during some part of Fragment/Activity lifecycle?

I see no problems. It's all good. If you want code-review, you may post it on http://codereview.stackexchange.com. — Gurupad Mamadapur, Feb 08 '17 at 12:41
I disagree with my previous comment, FragmentPagerAdapter is better suited in this case instead of FragmentStatePagerAdapter. — Gurupad Mamadapur, Feb 08 '17 at 12:53
In my opinion using this approach you will not be able to take advantage of the "Lazy initialization of fragment objects" as your fragments will be created the moment your adapter is created which is fine unless your fragments are heavy in that case it will create a noticeable lag while initial rendering. Have a look here https://developer.android.com/reference/android/support/v4/app/FragmentPagerAdapter.html — raktale, Feb 08 '17 at 12:53

Jd Prajapati · Answer 1 · 2017-02-08T12:48:43.537

0

Try to use FragmentPagerStateAdapter insteadof FragmentPagerAdapter.

FragmentPagerAdapter stores the previous data which is fetched from the adapter while FragmentStatePagerAdapter takes the new value from the adapter everytime it is executed

edited Feb 08 '17 at 12:48

answered Feb 08 '17 at 12:40

Jd Prajapati

1,953
13
24

It'd be better if you add an explanation as to why it is better. – Gurupad Mamadapur Feb 08 '17 at 12:42
Read [this](http://stackoverflow.com/questions/18747975/difference-between-fragmentpageradapter-and-fragmentstatepageradapter?rq=1). You'll know that FragmentPagerAdapter is better here. – Gurupad Mamadapur Feb 08 '17 at 12:55

Is there anything wrong with this FragmentPagerAdapter approach?

1 Answers1