class not working perfectly on dynamically generated button jQuery, Bootstrap

Question

I'm generating a table using jQuer, Ajax . All the thing working fine but the edit button not working perfectly. I want to copy all data-(properties) on click. If I do the same with php it works fine, But I need using jquery. here is my code.

==================== table code ===========

$("#get_spare_list").click(function() {
    var ht = "";
    $.ajax({
        url: "<?php echo base_url('Spare/get_all_spare_json'); ?>",
        type: 'POST',
        dataType: 'json',
        data: {"param1": 'value1'},
    })
    .done(function(data) {
        var no = 1;
        var ht = "<table class='table'><thead><tr><th>No</th><th>Name</th><th>Code</th><th>Min qty</th><th>uni</th><th>Group</th><th>Sub Category</th><th>Part Number</th><th>Location</th><th>Image</th><th>Barcode</th><th>Tyre</th><th>Back</th></tr></thead>";
        $.each(data, function(key, val) {
            ht +="<tr>"+"<td>"+no+"</td>"+"<td>"+val.name+"</td>"+"<td>"+val.code+"</td>"+"<td>"+val.min_qty+"</td>"+"<td>"+val.unit+"</td>"+"<td>"+val.group+"</td><td>"+val.sub_category+"</td><td>"+val.part_number+"</td><td>"+val.location+"</td>";
            if (val.image) {
                ht += "<td><a target='_blank' href='"+"<?php echo base_url('../images/'); ?>/"+val.image+"'><button class='fa fa-picture-o'></button></a></td>";
            }else{
                 ht += "<td></td>";
            }
            ht += "<td><button class='btn btn-info btn-xs' onclick=PrintBar('val.code')>Print</button></td>";
            ht +="<td>"+val.tyre+"</td>";
            ht += "<td>";
                if (val.reusable) {
                    ht +="yes";
                }else{
                    ht+="no";
                };
            ht += "</td>";
            ht += "<td><button class='btn edit btn-info btn-xs' data-toggle='modal' data-target='#editModel' data-id='"+val.id+"' data-name='"+val.name+"'  data-code='"+val.code+"'  data-min_qty='"+val.min_qty+"'  data-unit='"+val.unit+"'  data-group='"+val.group+"'  data-sub_category='"+val.sub_category+"' data-part_number='"+val.part_number+"' data-location='"+val.location+"'  data-tyre_number='"+val.tyre+"' data-back='"+val.reusable+"'><span class='fa fa-edit'></span></button></td>";
            ht += "</tr>";
            no++;
        });
        $("#js_res").append(ht);
        console.log(ht);
    })
    .fail(function() {
        alert("error");
    });
});

======== Class code to copy data ============

$(".edit").click(function() {
    $("#id").val($(this).data('id'));
    $("#name").val($(this).data('name'));
    $("#code").val($(this).data('code'));
    $("#min_qty").val($(this).data('min_qty'));
    $("#unit").val($(this).data('unit'));
    $("#group").val($(this).data('group'));
    $("#sub_category").val($(this).data('sub_category'));
    $("#part_number").val($(this).data('part_number'));
    var location = $(this).data('location');
    var l1 = location.split("->");
    $("#room").val($.trim(l1[0]));
    $("#rake").val(l1[1]);
    $("#line").val(l1[2]);
    $("#box").val(l1[3]);
    if ($(this).data('tyre_number')) {
        $("input[name=tyre][value=" + $(this).data('tyre_number') + "]").prop('checked', true);
    }else{
        $("input[name=tyre][value='']").prop('checked', true);
    };
    if ($(this).data('back') == "1") {
        $("#back").attr('checked', true);
    }else{
        $("#back").removeAttr('checked');
    };
});

Possible duplicate of [In jQuery, how to attach events to dynamic html elements?](http://stackoverflow.com/questions/1359018/in-jquery-how-to-attach-events-to-dynamic-html-elements) — vijayP, May 04 '17 at 07:29
also your `onclick=PrintBar('val.code')` should be `onclick=PrintBar('"+val.code+"')` — Ataur Rahman Munna, May 04 '17 at 07:31

Super User · Accepted Answer · 2017-05-04T07:37:03.890

1

Instead of click function you can use .on() function

$(document).on('click','.edit', function() { will bind the event on the .edit elements which are not present at the time of binding event. This is called event delegation

$(document).on("click", ".edit", function() {

    // your code here
})

edited May 04 '17 at 07:37

answered May 04 '17 at 07:29

Super User

9,448
3
31
47

1

$(document).on('click','.edit', function() { will bind the event on the .edit elements which are not present at the time of binding event. This is called event delegation. – Super User May 04 '17 at 07:32
Also onclick event should work here though it is dynamically generated. – Ataur Rahman Munna May 04 '17 at 07:35

score 0 · Answer 2 · edited May 23 '17 at 11:54

This is because the element is dynamically generated, so does not exist on initial page load.

Use $.fn.on()

From the documentation

$(staticAncestors).on(eventName, dynamicChild, function() {});

In your case, it would be:

$(document).on("click", ".edit", function() {

    $("#id").val($(this).data('id'));
    $("#name").val($(this).data('name'));
    $("#code").val($(this).data('code'));
    $("#min_qty").val($(this).data('min_qty'));
    $("#unit").val($(this).data('unit'));
    $("#group").val($(this).data('group'));
    $("#sub_category").val($(this).data('sub_category'));
    $("#part_number").val($(this).data('part_number'));
    var location = $(this).data('location');
    var l1 = location.split("->");
    $("#room").val($.trim(l1[0]));
    $("#rake").val(l1[1]);
    $("#line").val(l1[2]);
    $("#box").val(l1[3]);
    if ($(this).data('tyre_number')) {
        $("input[name=tyre][value=" + $(this).data('tyre_number') + "]").prop('checked', true);
    }else{
        $("input[name=tyre][value='']").prop('checked', true);
    };
    if ($(this).data('back') == "1") {
        $("#back").attr('checked', true);
    }else{
        $("#back").removeAttr('checked');
    };
})

For more detail on why this doesn't work, see: Event binding on dynamically created elements?

class not working perfectly on dynamically generated button jQuery, Bootstrap

2 Answers2